fix: remove obsolete wait-cloud-init argument from E2E test commands

- Update GitHub Actions workflow to use correct E2E test command format
- Fix documentation in README.md, copilot-instructions.md, and main.rs
- E2E tests now run all playbooks without requiring specific arguments
- Resolve clippy linting errors in test files for code quality

The E2E tests have evolved to run a complete deployment workflow
instead of individual playbooks, making the wait-cloud-init argument
obsolete and causing command failures.

Author: josecelano

.github/copilot-instructions.md

@@ -35,6 +35,6 @@ This is a deployment infrastructure proof-of-concept for the Torrust ecosystem.
 - **Build**: `cargo build`
 - **Test**: `cargo test`
 - **Lint**: `cargo run --bin linter all` (mandatory before commits)
-- **E2E**: `cargo run --bin e2e-tests wait-cloud-init`
+- **E2E**: `cargo run --bin e2e-tests`
 
 Follow the project conventions and ensure all checks pass.

.github/workflows/test-e2e.yml

@@ -48,11 +48,11 @@ jobs:
         run: |
           cargo build --bin e2e-tests --release
 
-      - name: Run wait-cloud-init E2E test
+      - name: Run E2E test
         run: |
           # Run the E2E test with verbose output for better debugging
           # Use sudo -E and preserve PATH to ensure cargo is accessible
-          sudo -E env "PATH=$PATH" cargo run --bin e2e-tests -- wait-cloud-init --verbose
+          sudo -E env "PATH=$PATH" cargo run --bin e2e-tests -- --verbose
         env:
           # Preserve environment variables for the E2E test
           RUST_LOG: debug

README.md

@@ -115,14 +115,14 @@ cargo run --bin linter shellcheck  # Shell script linting
 Use the E2E tests binary to run automated infrastructure tests:
 
 ```bash
-# Run the wait-cloud-init test
-cargo run --bin e2e-tests -- wait-cloud-init
+# Run the E2E tests
+cargo run --bin e2e-tests
 
 # Keep the test environment after completion
-cargo run --bin e2e-tests -- wait-cloud-init --keep
+cargo run --bin e2e-tests -- --keep
 
 # Run with verbose output
-cargo run --bin e2e-tests -- wait-cloud-init --verbose
+cargo run --bin e2e-tests -- --verbose
 
 # See all available options
 cargo run --bin e2e-tests -- --help

src/main.rs

@@ -14,7 +14,7 @@ fn main() {
     println!();
     println!("🧪 Running E2E Tests:");
     println!("   Use the e2e-tests binary to run end-to-end tests:");
-    println!("   cargo run --bin e2e-tests -- wait-cloud-init");
+    println!("   cargo run --bin e2e-tests");
     println!();
     println!("📖 For detailed instructions, see: README.md");
 }

tests/template_integration.rs

@@ -46,41 +46,41 @@ mod integration_tests {
         // Verify the output file exists and has the right content
         assert!(output_path.exists());
 
-        let content = std::fs::read_to_string(&output_path)?;
+        let file_content = std::fs::read_to_string(&output_path)?;
 
         // Verify variables were substituted
-        assert!(content.contains("ansible_host: 192.168.1.100"));
-        assert!(content.contains("ansible_ssh_private_key_file: /home/user/.ssh/testing_rsa"));
+        assert!(file_content.contains("ansible_host: 192.168.1.100"));
+        assert!(file_content.contains("ansible_ssh_private_key_file: /home/user/.ssh/testing_rsa"));
 
         // Verify no template variables remain
-        assert!(!content.contains("{{ansible_host}}"));
-        assert!(!content.contains("{{ansible_ssh_private_key_file}}"));
+        assert!(!file_content.contains("{{ansible_host}}"));
+        assert!(!file_content.contains("{{ansible_ssh_private_key_file}}"));
 
         // Verify it's valid YAML structure
-        assert!(content.contains("all:"));
-        assert!(content.contains("torrust-vm:"));
-        assert!(content.contains("ansible_user: torrust"));
+        assert!(file_content.contains("all:"));
+        assert!(file_content.contains("torrust-vm:"));
+        assert!(file_content.contains("ansible_user: torrust"));
 
         println!("✅ Real inventory template rendered successfully");
         Ok(())
     }
 
     /// Test variable validation with real template
     #[test]
-    fn test_real_template_variable_validation() -> Result<()> {
+    fn test_real_template_variable_validation() {
         let template_path = PathBuf::from("templates/ansible/inventory.yml.tera");
 
         // Skip test if template file doesn't exist
         if !template_path.exists() {
             println!("Skipping test: inventory template not found");
-            return Ok(());
+            return;
         }
 
         // Test that missing variables are caught during construction
         let result = InventoryTemplate::new(
             template_path.clone(),
-            "".to_string(), // Empty IP should still work for construction
-            "".to_string(), // Empty SSH key should still work for construction
+            String::new(), // Empty IP should still work for construction
+            String::new(), // Empty SSH key should still work for construction
         );
 
         // Construction should succeed even with empty values
@@ -96,8 +96,6 @@ mod integration_tests {
 
         assert!(result.is_err());
         println!("✅ Invalid template path correctly rejected");
-
-        Ok(())
     }
 
     /// Test that template rendering doesn't modify any files in the templates directory
@@ -175,8 +173,8 @@ mod integration_tests {
 
             // Verify output in build directory
             assert!(output_path.exists());
-            let content = std::fs::read_to_string(&output_path)?;
-            assert!(content.contains("10.0.0.100"));
+            let file_content = std::fs::read_to_string(&output_path)?;
+            assert!(file_content.contains("10.0.0.100"));
         }
 
         println!("✅ Build directory workflow completed successfully");