feat: add structured logging instrumentation for command-level operations

- Add tracing attributes feature to Cargo.toml dependency
- Add #[instrument] to ProvisionCommand::execute() with provision_command span
- Add #[instrument] to ConfigureCommand::execute() with configure_command span
- Add #[instrument] to TestCommand::execute() with test_command span
- Update structured logging implementation plan to reflect Phase 1 completion

This implements Phase 1 of the structured logging plan, creating hierarchical
spans for all command-level operations with consistent naming and field
conventions.

Author: josecelano

Cargo.toml

@@ -36,5 +36,5 @@ tempfile = "3.0"
 tera = "1.0"
 thiserror = "1.0"
 torrust-linting = { path = "packages/linting" }
-tracing = "0.1"
+tracing = { version = "0.1", features = [ "attributes" ] }
 tracing-subscriber = "0.3"

docs/structured-logging-implementation-plan.md

@@ -28,40 +28,40 @@ Level 1: Commands (Top-level orchestration)
 
 ### Phase 1: Commands (Level 1) - Foundation
 
-**Status**: 🔴 **Not Started**  
+**Status**: � **Completed**  
 **Priority**: High  
 **Estimated Effort**: 2-3 days
 
 #### Tasks
 
-- [ ] **1.1** Add `#[instrument]` to `ProvisionCommand::execute()`
+- [x] **1.1** Add `#[instrument]` to `ProvisionCommand::execute()`
 
   - File: `src/commands/provision.rs`
   - Span name: `provision_command`
   - Fields: `command_type="provision"`
 
-- [ ] **1.2** Add `#[instrument]` to `ConfigureCommand::execute()`
+- [x] **1.2** Add `#[instrument]` to `ConfigureCommand::execute()`
 
   - File: `src/commands/configure.rs`
   - Span name: `configure_command`
   - Fields: `command_type="configure"`
 
-- [ ] **1.3** Add `#[instrument]` to `TestCommand::execute()`
+- [x] **1.3** Add `#[instrument]` to `TestCommand::execute()`
 
   - File: `src/commands/test.rs`
   - Span name: `test_command`
   - Fields: `command_type="test"`
 
-- [ ] **1.4** Verify dependencies and features
+- [x] **1.4** Verify dependencies and features
   - Ensure `tracing = { features = ["attributes"] }` in `Cargo.toml`
   - Test span creation and nesting
 
 #### Acceptance Criteria
 
-- All command-level operations are wrapped in spans
-- Spans include relevant contextual fields
-- Log output shows hierarchical structure at command level
-- E2E tests pass with new spans
+- ✅ All command-level operations are wrapped in spans
+- ✅ Spans include relevant contextual fields
+- ✅ Log output shows hierarchical structure at command level
+- ✅ E2E tests pass with new spans
 
 #### Files to Modify
 
@@ -274,15 +274,15 @@ Level 1: Commands (Top-level orchestration)
 ### Overall Progress
 
 - **Total Tasks**: 25
-- **Completed**: 0 (0%)
+- **Completed**: 4 (16%)
 - **In Progress**: 0 (0%)
-- **Not Started**: 25 (100%)
+- **Not Started**: 21 (84%)
 
 ### Phase Progress
 
 | Phase                   | Status         | Tasks Complete | Progress |
 | ----------------------- | -------------- | -------------- | -------- |
-| Phase 1: Commands       | 🔴 Not Started | 0/4            | 0%       |
+| Phase 1: Commands       | � Completed    | 4/4            | 100%     |
 | Phase 2: Steps          | 🔴 Not Started | 0/11           | 0%       |
 | Phase 3: Remote Actions | 🔴 Not Started | 0/4            | 0%       |
 | Phase 4: Optimization   | 🔴 Not Started | 0/6            | 0%       |
@@ -384,8 +384,15 @@ tracing = { version = "0.1", features = ["attributes"] }
 
 ---
 
-**Next Steps**: Begin Phase 1 implementation with `ProvisionCommand` instrumentation.
+**Next Steps**: Begin Phase 2 implementation with Step-level instrumentation, starting with Infrastructure Steps.
 
 **Dependencies**: None - can start immediately with existing tracing setup.
 
 **Risk Assessment**: Low - Non-breaking changes, backward compatible, can be implemented incrementally.
+
+**Phase 1 Completion Notes**:
+
+- ✅ All command-level operations now have tracing spans
+- ✅ Spans use consistent naming convention and fields
+- ✅ All tests pass and linting checks succeed
+- ✅ Ready to proceed to Phase 2 (Steps instrumentation)

src/commands/configure.rs

@@ -1,6 +1,6 @@
 use std::sync::Arc;
 
-use tracing::info;
+use tracing::{info, instrument};
 
 use crate::command::CommandError;
 use crate::command_wrappers::ansible::AnsibleClient;
@@ -38,6 +38,11 @@ impl ConfigureCommand {
     /// Returns an error if any step in the configuration workflow fails:
     /// * Docker installation fails
     /// * Docker Compose installation fails
+    #[instrument(
+        name = "configure_command",
+        skip_all,
+        fields(command_type = "configure")
+    )]
     pub fn execute(&self) -> Result<(), ConfigureCommandError> {
         info!(
             command = "configure",

src/commands/provision.rs

@@ -1,7 +1,7 @@
 use std::net::IpAddr;
 use std::sync::Arc;
 
-use tracing::info;
+use tracing::{info, instrument};
 
 use crate::ansible::AnsibleTemplateRenderer;
 use crate::command::CommandError;
@@ -105,6 +105,11 @@ impl ProvisionCommand {
     /// * Unable to retrieve instance information
     /// * SSH connectivity cannot be established
     /// * Cloud-init does not complete successfully
+    #[instrument(
+        name = "provision_command",
+        skip_all,
+        fields(command_type = "provision")
+    )]
     pub async fn execute(&self) -> Result<IpAddr, ProvisionCommandError> {
         info!(
             command = "provision",

src/commands/test.rs

@@ -1,5 +1,5 @@
 use std::net::IpAddr;
-use tracing::{error, info};
+use tracing::{error, info, instrument};
 
 use crate::command::CommandError;
 use crate::command_wrappers::ssh::credentials::SshCredentials;
@@ -50,6 +50,7 @@ impl TestCommand {
     /// * Cloud-init completion validation fails
     /// * Docker installation validation fails
     /// * Docker Compose installation validation fails
+    #[instrument(name = "test_command", skip_all, fields(command_type = "test"))]
     pub async fn execute(&self) -> Result<(), TestCommandError> {
         info!(
             command = "test",