step: [#220] implement HttpApiSection DTO

Author: josecelano

docs/implementation-plans/issue-220-test-command-architecture.md

@@ -43,7 +43,7 @@ Phase 0: Architecture Fix
   [x] Step 0.1: Create tracker DTO module structure
   [x] Step 0.2: Implement UdpTrackerSection DTO
   [x] Step 0.3: Implement HttpTrackerSection DTO
-  [ ] Step 0.4: Implement HttpApiSection DTO
+  [x] Step 0.4: Implement HttpApiSection DTO
   [ ] Step 0.5: Implement TrackerCoreSection DTO
   [ ] Step 0.6: Implement TrackerSection DTO
   [ ] Step 0.7: Update domain types to use SocketAddr

src/application/command_handlers/create/config/tracker/http_api_section.rs

@@ -0,0 +1,95 @@
+use std::net::SocketAddr;
+
+use serde::{Deserialize, Serialize};
+
+use crate::application::command_handlers::create::config::errors::CreateConfigError;
+use crate::domain::tracker::HttpApiConfig;
+
+#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
+pub struct HttpApiSection {
+    pub bind_address: String,
+    pub admin_token: String,
+}
+
+impl HttpApiSection {
+    /// Converts this DTO to a domain `HttpApiConfig`
+    ///
+    /// # Errors
+    ///
+    /// Returns `CreateConfigError::InvalidBindAddress` if the bind address cannot be parsed as a valid IP:PORT combination.
+    pub fn to_http_api_config(&self) -> Result<HttpApiConfig, CreateConfigError> {
+        // Validate that the bind address can be parsed as SocketAddr
+        let _bind_address = self.bind_address.parse::<SocketAddr>().map_err(|e| {
+            CreateConfigError::InvalidBindAddress {
+                address: self.bind_address.clone(),
+                source: e,
+            }
+        })?;
+
+        // For now, keep as String since domain type still uses String
+        // This will be updated in Step 0.7 when we enhance domain types
+        Ok(HttpApiConfig {
+            bind_address: self.bind_address.clone(),
+            admin_token: self.admin_token.clone(),
+        })
+    }
+}
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn it_should_convert_valid_config_to_http_api_config() {
+        let section = HttpApiSection {
+            bind_address: "0.0.0.0:1212".to_string(),
+            admin_token: "MyAccessToken".to_string(),
+        };
+
+        let result = section.to_http_api_config();
+        assert!(result.is_ok());
+
+        let config = result.unwrap();
+        assert_eq!(config.bind_address, "0.0.0.0:1212");
+        assert_eq!(config.admin_token, "MyAccessToken");
+    }
+
+    #[test]
+    fn it_should_fail_for_invalid_bind_address() {
+        let section = HttpApiSection {
+            bind_address: "invalid-address".to_string(),
+            admin_token: "token".to_string(),
+        };
+
+        let result = section.to_http_api_config();
+        assert!(result.is_err());
+
+        if let Err(CreateConfigError::InvalidBindAddress { address, .. }) = result {
+            assert_eq!(address, "invalid-address");
+        } else {
+            panic!("Expected InvalidBindAddress error");
+        }
+    }
+
+    #[test]
+    fn it_should_be_serializable() {
+        let section = HttpApiSection {
+            bind_address: "0.0.0.0:1212".to_string(),
+            admin_token: "MyAccessToken".to_string(),
+        };
+
+        let json = serde_json::to_string(&section).unwrap();
+        assert!(json.contains("bind_address"));
+        assert!(json.contains("0.0.0.0:1212"));
+        assert!(json.contains("admin_token"));
+        assert!(json.contains("MyAccessToken"));
+    }
+
+    #[test]
+    fn it_should_be_deserializable() {
+        let json = r#"{"bind_address":"0.0.0.0:1212","admin_token":"MyAccessToken"}"#;
+        let section: HttpApiSection = serde_json::from_str(json).unwrap();
+        assert_eq!(section.bind_address, "0.0.0.0:1212");
+        assert_eq!(section.admin_token, "MyAccessToken");
+    }
+}

src/application/command_handlers/create/config/tracker/mod.rs

@@ -4,8 +4,10 @@
 //! environment creation. These types use raw primitives (String) for
 //! JSON deserialization and convert to rich domain types (`SocketAddr`).
 
+mod http_api_section;
 mod http_tracker_section;
 mod udp_tracker_section;
 
+pub use http_api_section::HttpApiSection;
 pub use http_tracker_section::HttpTrackerSection;
 pub use udp_tracker_section::UdpTrackerSection;