refactor: [#107] simplify error handling with From trait for ProgressReporterError

- Add From<ProgressReporterError> implementations for DestroySubcommandError and CreateSubcommandError
- Replace verbose .map_err(|e| Error::ProgressReportingFailed { source: e }) with simple ? operator
- Eliminates ~80 lines of boilerplate across destroy and create handlers
- Follows idiomatic Rust patterns for automatic error conversion

Author: josecelano

src/presentation/commands/create/errors.rs

@@ -130,6 +130,16 @@ Tip: This is a critical bug - please report it with full logs using --log-output
     },
 }
 
+// ============================================================================
+// ERROR CONVERSIONS
+// ============================================================================
+
+impl From<ProgressReporterError> for CreateSubcommandError {
+    fn from(source: ProgressReporterError) -> Self {
+        Self::ProgressReportingFailed { source }
+    }
+}
+
 impl CreateSubcommandError {
     /// Provides detailed troubleshooting guidance for this error
     ///

src/presentation/commands/create/subcommands/environment.rs

@@ -57,45 +57,31 @@ pub fn handle_environment_creation(
     let mut progress = ProgressReporter::new(user_output.clone(), 3);
 
     // Step 1: Load configuration
-    progress
-        .start_step("Loading configuration")
-        .map_err(|e| CreateSubcommandError::ProgressReportingFailed { source: e })?;
+    progress.start_step("Loading configuration")?;
     let config = load_configuration(progress.output(), env_file)?;
-    progress
-        .complete_step(Some(&format!(
-            "Configuration loaded: {}",
-            config.environment.name
-        )))
-        .map_err(|e| CreateSubcommandError::ProgressReportingFailed { source: e })?;
+    progress.complete_step(Some(&format!(
+        "Configuration loaded: {}",
+        config.environment.name
+    )))?;
 
     // Step 2: Initialize dependencies
-    progress
-        .start_step("Initializing dependencies")
-        .map_err(|e| CreateSubcommandError::ProgressReportingFailed { source: e })?;
+    progress.start_step("Initializing dependencies")?;
     let command_handler = factory.create_create_handler(&ctx);
-    progress
-        .complete_step(None)
-        .map_err(|e| CreateSubcommandError::ProgressReportingFailed { source: e })?;
+    progress.complete_step(None)?;
 
     // Step 3: Execute create command (provision infrastructure)
-    progress
-        .start_step("Creating environment")
-        .map_err(|e| CreateSubcommandError::ProgressReportingFailed { source: e })?;
+    progress.start_step("Creating environment")?;
     let environment = execute_create_command(progress.output(), &command_handler, config)?;
-    progress
-        .complete_step(Some(&format!(
-            "Instance created: {}",
-            environment.instance_name().as_str()
-        )))
-        .map_err(|e| CreateSubcommandError::ProgressReportingFailed { source: e })?;
+    progress.complete_step(Some(&format!(
+        "Instance created: {}",
+        environment.instance_name().as_str()
+    )))?;
 
     // Complete with summary
-    progress
-        .complete(&format!(
-            "Environment '{}' created successfully",
-            environment.name().as_str()
-        ))
-        .map_err(|e| CreateSubcommandError::ProgressReportingFailed { source: e })?;
+    progress.complete(&format!(
+        "Environment '{}' created successfully",
+        environment.name().as_str()
+    ))?;
 
     // Display final results
     display_creation_results(progress.output(), &environment);
@@ -131,9 +117,7 @@ fn load_configuration(
 ) -> Result<EnvironmentCreationConfig, CreateSubcommandError> {
     user_output
         .lock()
-        .map_err(|_| CreateSubcommandError::ProgressReportingFailed {
-            source: crate::presentation::progress::ProgressReporterError::UserOutputMutexPoisoned,
-        })?
+        .map_err(|_| crate::presentation::progress::ProgressReporterError::UserOutputMutexPoisoned)?
         .progress(&format!(
             "Loading configuration from '{}'...",
             env_file.display()
@@ -175,19 +159,15 @@ fn execute_create_command(
 ) -> Result<Environment, CreateSubcommandError> {
     user_output
         .lock()
-        .map_err(|_| CreateSubcommandError::ProgressReportingFailed {
-            source: crate::presentation::progress::ProgressReporterError::UserOutputMutexPoisoned,
-        })?
+        .map_err(|_| crate::presentation::progress::ProgressReporterError::UserOutputMutexPoisoned)?
         .progress(&format!(
             "Creating environment '{}'...",
             config.environment.name
         ));
 
     user_output
         .lock()
-        .map_err(|_| CreateSubcommandError::ProgressReportingFailed {
-            source: crate::presentation::progress::ProgressReporterError::UserOutputMutexPoisoned,
-        })?
+        .map_err(|_| crate::presentation::progress::ProgressReporterError::UserOutputMutexPoisoned)?
         .progress("Validating configuration and creating environment...");
 
     #[allow(clippy::manual_inspect)]

src/presentation/commands/destroy/errors.rs

@@ -91,6 +91,16 @@ Tip: This is a critical bug - please report it with full logs using --log-output
     },
 }
 
+// ============================================================================
+// ERROR CONVERSIONS
+// ============================================================================
+
+impl From<ProgressReporterError> for DestroySubcommandError {
+    fn from(source: ProgressReporterError) -> Self {
+        Self::ProgressReportingFailed { source }
+    }
+}
+
 impl DestroySubcommandError {
     /// Get detailed troubleshooting guidance for this error
     ///

src/presentation/commands/destroy/handler.rs

@@ -68,50 +68,36 @@ pub fn handle_destroy_command(
     let mut progress = ProgressReporter::new(user_output.clone(), 3);
 
     // Step 1: Validate environment name
-    progress
-        .start_step("Validating environment")
-        .map_err(|e| DestroySubcommandError::ProgressReportingFailed { source: e })?;
+    progress.start_step("Validating environment")?;
     let env_name = EnvironmentName::new(environment_name.to_string()).map_err(|source| {
         DestroySubcommandError::InvalidEnvironmentName {
             name: environment_name.to_string(),
             source,
         }
     })?;
-    progress
-        .complete_step(Some(&format!(
-            "Environment name validated: {environment_name}"
-        )))
-        .map_err(|e| DestroySubcommandError::ProgressReportingFailed { source: e })?;
+    progress.complete_step(Some(&format!(
+        "Environment name validated: {environment_name}"
+    )))?;
 
     // Step 2: Initialize dependencies
-    progress
-        .start_step("Initializing dependencies")
-        .map_err(|e| DestroySubcommandError::ProgressReportingFailed { source: e })?;
+    progress.start_step("Initializing dependencies")?;
     let command_handler = factory.create_destroy_handler(&ctx);
-    progress
-        .complete_step(None)
-        .map_err(|e| DestroySubcommandError::ProgressReportingFailed { source: e })?;
+    progress.complete_step(None)?;
 
     // Step 3: Execute destroy command (tear down infrastructure)
-    progress
-        .start_step("Tearing down infrastructure")
-        .map_err(|e| DestroySubcommandError::ProgressReportingFailed { source: e })?;
+    progress.start_step("Tearing down infrastructure")?;
     let _destroyed_env = command_handler.execute(&env_name).map_err(|source| {
         DestroySubcommandError::DestroyOperationFailed {
             name: environment_name.to_string(),
             source,
         }
     })?;
-    progress
-        .complete_step(Some("Infrastructure torn down"))
-        .map_err(|e| DestroySubcommandError::ProgressReportingFailed { source: e })?;
+    progress.complete_step(Some("Infrastructure torn down"))?;
 
     // Complete with summary
-    progress
-        .complete(&format!(
-            "Environment '{environment_name}' destroyed successfully"
-        ))
-        .map_err(|e| DestroySubcommandError::ProgressReportingFailed { source: e })?;
+    progress.complete(&format!(
+        "Environment '{environment_name}' destroyed successfully"
+    ))?;
 
     Ok(())
 }