refactor: [#227] rename test helper methods in ssh_server testing

Renamed credential methods from test_username/test_password to username/password
and test_ssh_connection to verify_ssh_connection. Updated all call sites.

Tests: All tests pass

Author: josecelano

src/testing/e2e/containers/actions/ssh_wait.rs

@@ -143,7 +143,7 @@ impl SshWaitAction {
                 "Attempting SSH connection"
             );
 
-            match Self::test_ssh_connection(socket_addr) {
+            match Self::verify_ssh_connection(socket_addr) {
                 Ok(()) => {
                     info!(
                         socket_addr = %socket_addr,
@@ -187,7 +187,7 @@ impl SshWaitAction {
     ///
     /// This approach minimizes error noise by doing the lightweight port check first,
     /// then only checking SSH protocol when the port is already open.
-    fn test_ssh_connection(socket_addr: SocketAddr) -> Result<()> {
+    fn verify_ssh_connection(socket_addr: SocketAddr) -> Result<()> {
         // Stage 1: Check if port is open (lightweight, no SSH errors)
         Self::check_port_availability(socket_addr)?;
 

src/testing/integration/ssh_server/mock_container.rs

@@ -100,13 +100,13 @@ impl MockSshServerContainer {
 
     /// Get the test username configured in the container
     #[must_use]
-    pub fn test_username(&self) -> &str {
+    pub fn username(&self) -> &str {
         &self.config.username
     }
 
     /// Get the test password configured in the container
     #[must_use]
-    pub fn test_password(&self) -> &str {
+    pub fn password(&self) -> &str {
         &self.config.password
     }
 }
@@ -120,11 +120,11 @@ impl super::SshServerContainer for MockSshServerContainer {
         self.host_ip
     }
 
-    fn test_username(&self) -> &str {
+    fn username(&self) -> &str {
         &self.config.username
     }
 
-    fn test_password(&self) -> &str {
+    fn password(&self) -> &str {
         &self.config.password
     }
 }

src/testing/integration/ssh_server/mod.rs

@@ -55,10 +55,10 @@ pub trait SshServerContainer {
     fn host_ip(&self) -> IpAddr;
 
     /// Get the test username configured in the container
-    fn test_username(&self) -> &str;
+    fn username(&self) -> &str;
 
     /// Get the test password configured in the container
-    fn test_password(&self) -> &str;
+    fn password(&self) -> &str;
 }
 
 #[cfg(test)]
@@ -79,8 +79,8 @@ mod tests {
                 let host_ip = ssh_container.host_ip();
                 assert_eq!(host_ip, IpAddr::V4(Ipv4Addr::LOCALHOST));
 
-                assert_eq!(ssh_container.test_username(), "testuser");
-                assert_eq!(ssh_container.test_password(), "testpass");
+                assert_eq!(ssh_container.username(), "testuser");
+                assert_eq!(ssh_container.password(), "testpass");
             }
             Err(e) => {
                 panic!("Mock container should always start successfully: {e}");
@@ -101,8 +101,8 @@ mod tests {
                 let host_ip = ssh_container.host_ip();
                 assert_eq!(host_ip, IpAddr::V4(Ipv4Addr::LOCALHOST));
 
-                assert_eq!(ssh_container.test_username(), "testuser");
-                assert_eq!(ssh_container.test_password(), "testpass");
+                assert_eq!(ssh_container.username(), "testuser");
+                assert_eq!(ssh_container.password(), "testpass");
             }
             Err(e) => {
                 // Real container start might fail in CI environments without Docker
@@ -122,16 +122,16 @@ mod tests {
         let container: &dyn SshServerContainer = &mock;
         assert!(container.ssh_port() > 0);
         assert_eq!(container.host_ip(), IpAddr::V4(Ipv4Addr::LOCALHOST));
-        assert_eq!(container.test_username(), "testuser");
-        assert_eq!(container.test_password(), "testpass");
+        assert_eq!(container.username(), "testuser");
+        assert_eq!(container.password(), "testpass");
     }
 
     #[tokio::test]
     async fn it_should_enable_generic_code() {
         // Helper function that works with any SshServerContainer
         fn verify_container<C: SshServerContainer>(container: &C) {
             assert!(container.ssh_port() > 0);
-            assert_eq!(container.test_username(), "testuser");
+            assert_eq!(container.username(), "testuser");
         }
 
         let mock = MockSshServerContainer::start()

src/testing/integration/ssh_server/real_container.rs

@@ -143,13 +143,13 @@ impl RealSshServerContainer {
 
     /// Get the test username configured in the container
     #[must_use]
-    pub fn test_username(&self) -> &str {
+    pub fn username(&self) -> &str {
         &self.config.username
     }
 
     /// Get the test password configured in the container
     #[must_use]
-    pub fn test_password(&self) -> &str {
+    pub fn password(&self) -> &str {
         &self.config.password
     }
 }
@@ -163,11 +163,11 @@ impl super::SshServerContainer for RealSshServerContainer {
         self.host_ip
     }
 
-    fn test_username(&self) -> &str {
+    fn username(&self) -> &str {
         &self.config.username
     }
 
-    fn test_password(&self) -> &str {
+    fn password(&self) -> &str {
         &self.config.password
     }
 }

tests/ssh_client/command_execution_tests.rs

@@ -86,7 +86,7 @@ async fn it_should_execute_remote_command_on_real_ssh_server() {
             let username = output.trim();
             assert_eq!(
                 username,
-                ssh_container.test_username(),
+                ssh_container.username(),
                 "whoami should return the test username"
             );
         }

tests/ssh_client/mod.rs

@@ -76,7 +76,7 @@ impl SshTestBuilder {
     pub fn with_mock_container(mut self, container: &MockSshServerContainer) -> Self {
         self.host_ip = Some(container.host_ip());
         self.port = Some(container.ssh_port());
-        self.username = Some(container.test_username().to_string());
+        self.username = Some(container.username().to_string());
         self.private_key_path = Some(PathBuf::from(REAL_SSH_PRIVATE_KEY));
         self.public_key_path = Some(PathBuf::from(REAL_SSH_PUBLIC_KEY));
         self
@@ -86,7 +86,7 @@ impl SshTestBuilder {
     pub fn with_real_container(mut self, container: &RealSshServerContainer) -> Self {
         self.host_ip = Some(container.host_ip());
         self.port = Some(container.ssh_port());
-        self.username = Some(container.test_username().to_string());
+        self.username = Some(container.username().to_string());
         self.private_key_path = Some(PathBuf::from(REAL_SSH_PRIVATE_KEY));
         self.public_key_path = Some(PathBuf::from(REAL_SSH_PUBLIC_KEY));
         self