step: [#220] implement TrackerSection DTO

Author: josecelano

docs/implementation-plans/issue-220-test-command-architecture.md

@@ -45,7 +45,7 @@ Phase 0: Architecture Fix
   [x] Step 0.3: Implement HttpTrackerSection DTO
   [x] Step 0.4: Implement HttpApiSection DTO
   [x] Step 0.5: Implement TrackerCoreSection DTO
-  [ ] Step 0.6: Implement TrackerSection DTO
+  [x] Step 0.6: Implement TrackerSection DTO
   [ ] Step 0.7: Update domain types to use SocketAddr
   [ ] Step 0.8: Update EnvironmentCreationConfig
   [ ] Step 0.9: Update all application imports

src/application/command_handlers/create/config/tracker/mod.rs

@@ -7,9 +7,11 @@
 mod http_api_section;
 mod http_tracker_section;
 mod tracker_core_section;
+mod tracker_section;
 mod udp_tracker_section;
 
 pub use http_api_section::HttpApiSection;
 pub use http_tracker_section::HttpTrackerSection;
 pub use tracker_core_section::{DatabaseSection, TrackerCoreSection};
+pub use tracker_section::TrackerSection;
 pub use udp_tracker_section::UdpTrackerSection;

src/application/command_handlers/create/config/tracker/tracker_section.rs

@@ -0,0 +1,248 @@
+//! Tracker configuration section (application DTO)
+//!
+//! This module provides the aggregated DTO for complete tracker configuration,
+//! used for JSON deserialization and validation before converting to domain types.
+
+use serde::{Deserialize, Serialize};
+
+use super::{HttpApiSection, HttpTrackerSection, TrackerCoreSection, UdpTrackerSection};
+use crate::application::command_handlers::create::config::errors::CreateConfigError;
+use crate::domain::tracker::{HttpApiConfig, HttpTrackerConfig, TrackerConfig, UdpTrackerConfig};
+
+/// Tracker configuration section (application DTO)
+///
+/// Aggregates all tracker configuration sections: core, UDP trackers,
+/// HTTP trackers, and HTTP API.
+///
+/// # Examples
+///
+/// ```json
+/// {
+///   "core": {
+///     "database": {
+///       "driver": "sqlite3",
+///       "database_name": "tracker.db"
+///     },
+///     "private": false
+///   },
+///   "udp_trackers": [
+///     { "bind_address": "0.0.0.0:6969" }
+///   ],
+///   "http_trackers": [
+///     { "bind_address": "0.0.0.0:7070" }
+///   ],
+///   "http_api": {
+///     "bind_address": "0.0.0.0:1212",
+///     "admin_token": "MyAccessToken"
+///   }
+/// }
+/// ```
+#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
+pub struct TrackerSection {
+    /// Core tracker configuration (database, privacy mode)
+    pub core: TrackerCoreSection,
+    /// UDP tracker instances
+    pub udp_trackers: Vec<UdpTrackerSection>,
+    /// HTTP tracker instances
+    pub http_trackers: Vec<HttpTrackerSection>,
+    /// HTTP API configuration
+    pub http_api: HttpApiSection,
+}
+
+impl TrackerSection {
+    /// Converts this DTO to the domain `TrackerConfig` type.
+    ///
+    /// # Errors
+    ///
+    /// Returns error if any of the nested sections fail validation:
+    /// - Invalid bind address formats
+    /// - Invalid database configuration
+    pub fn to_tracker_config(&self) -> Result<TrackerConfig, CreateConfigError> {
+        let core = self.core.to_tracker_core_config()?;
+
+        let udp_trackers: Result<Vec<UdpTrackerConfig>, CreateConfigError> = self
+            .udp_trackers
+            .iter()
+            .map(UdpTrackerSection::to_udp_tracker_config)
+            .collect();
+
+        let http_trackers: Result<Vec<HttpTrackerConfig>, CreateConfigError> = self
+            .http_trackers
+            .iter()
+            .map(HttpTrackerSection::to_http_tracker_config)
+            .collect();
+
+        let http_api: HttpApiConfig = self.http_api.to_http_api_config()?;
+
+        Ok(TrackerConfig {
+            core,
+            udp_trackers: udp_trackers?,
+            http_trackers: http_trackers?,
+            http_api,
+        })
+    }
+}
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use crate::application::command_handlers::create::config::tracker::tracker_core_section::DatabaseSection;
+    use crate::domain::tracker::DatabaseConfig;
+
+    #[test]
+    fn test_tracker_section_converts_to_domain_config() {
+        let section = TrackerSection {
+            core: TrackerCoreSection {
+                database: DatabaseSection::Sqlite {
+                    database_name: "tracker.db".to_string(),
+                },
+                private: false,
+            },
+            udp_trackers: vec![UdpTrackerSection {
+                bind_address: "0.0.0.0:6969".to_string(),
+            }],
+            http_trackers: vec![HttpTrackerSection {
+                bind_address: "0.0.0.0:7070".to_string(),
+            }],
+            http_api: HttpApiSection {
+                bind_address: "0.0.0.0:1212".to_string(),
+                admin_token: "MyAccessToken".to_string(),
+            },
+        };
+
+        let config = section.to_tracker_config().unwrap();
+
+        assert_eq!(
+            config.core.database,
+            DatabaseConfig::Sqlite {
+                database_name: "tracker.db".to_string()
+            }
+        );
+        assert!(!config.core.private);
+        assert_eq!(config.udp_trackers.len(), 1);
+        assert_eq!(config.http_trackers.len(), 1);
+        assert_eq!(config.http_api.bind_address, "0.0.0.0:1212");
+    }
+
+    #[test]
+    fn test_tracker_section_handles_multiple_trackers() {
+        let section = TrackerSection {
+            core: TrackerCoreSection {
+                database: DatabaseSection::Sqlite {
+                    database_name: "tracker.db".to_string(),
+                },
+                private: false,
+            },
+            udp_trackers: vec![
+                UdpTrackerSection {
+                    bind_address: "0.0.0.0:6969".to_string(),
+                },
+                UdpTrackerSection {
+                    bind_address: "0.0.0.0:6970".to_string(),
+                },
+            ],
+            http_trackers: vec![
+                HttpTrackerSection {
+                    bind_address: "0.0.0.0:7070".to_string(),
+                },
+                HttpTrackerSection {
+                    bind_address: "0.0.0.0:7071".to_string(),
+                },
+            ],
+            http_api: HttpApiSection {
+                bind_address: "0.0.0.0:1212".to_string(),
+                admin_token: "MyAccessToken".to_string(),
+            },
+        };
+
+        let config = section.to_tracker_config().unwrap();
+
+        assert_eq!(config.udp_trackers.len(), 2);
+        assert_eq!(config.http_trackers.len(), 2);
+    }
+
+    #[test]
+    fn test_tracker_section_fails_for_invalid_bind_address() {
+        let section = TrackerSection {
+            core: TrackerCoreSection {
+                database: DatabaseSection::Sqlite {
+                    database_name: "tracker.db".to_string(),
+                },
+                private: false,
+            },
+            udp_trackers: vec![UdpTrackerSection {
+                bind_address: "invalid".to_string(),
+            }],
+            http_trackers: vec![],
+            http_api: HttpApiSection {
+                bind_address: "0.0.0.0:1212".to_string(),
+                admin_token: "MyAccessToken".to_string(),
+            },
+        };
+
+        let result = section.to_tracker_config();
+
+        assert!(result.is_err());
+        assert!(matches!(
+            result.unwrap_err(),
+            CreateConfigError::InvalidBindAddress { .. }
+        ));
+    }
+
+    #[test]
+    fn test_tracker_section_serialization() {
+        let section = TrackerSection {
+            core: TrackerCoreSection {
+                database: DatabaseSection::Sqlite {
+                    database_name: "tracker.db".to_string(),
+                },
+                private: false,
+            },
+            udp_trackers: vec![UdpTrackerSection {
+                bind_address: "0.0.0.0:6969".to_string(),
+            }],
+            http_trackers: vec![HttpTrackerSection {
+                bind_address: "0.0.0.0:7070".to_string(),
+            }],
+            http_api: HttpApiSection {
+                bind_address: "0.0.0.0:1212".to_string(),
+                admin_token: "MyAccessToken".to_string(),
+            },
+        };
+
+        let json = serde_json::to_string(&section).unwrap();
+        assert!(json.contains("\"driver\":\"sqlite3\""));
+        assert!(json.contains("\"udp_trackers\""));
+        assert!(json.contains("\"http_trackers\""));
+        assert!(json.contains("\"http_api\""));
+    }
+
+    #[test]
+    fn test_tracker_section_deserialization() {
+        let json = r#"{
+            "core": {
+                "database": {
+                    "driver": "sqlite3",
+                    "database_name": "tracker.db"
+                },
+                "private": true
+            },
+            "udp_trackers": [
+                { "bind_address": "0.0.0.0:6969" }
+            ],
+            "http_trackers": [
+                { "bind_address": "0.0.0.0:7070" }
+            ],
+            "http_api": {
+                "bind_address": "0.0.0.0:1212",
+                "admin_token": "MyAccessToken"
+            }
+        }"#;
+
+        let section: TrackerSection = serde_json::from_str(json).unwrap();
+
+        assert!(section.core.private);
+        assert_eq!(section.udp_trackers.len(), 1);
+        assert_eq!(section.http_trackers.len(), 1);
+    }
+}