Skip to content

Commit dbe2876

Browse files
committed
refactor: [#220] move running_services validator to external_validators
1 parent d6a5c3b commit dbe2876

File tree

1 file changed

+20
-4
lines changed

1 file changed

+20
-4
lines changed

src/infrastructure/remote_actions/validators/running_services.rs renamed to src/infrastructure/external_validators/running_services.rs

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,24 @@
1-
//! Running services validation remote action
1+
//! Running services external validation
22
//!
3-
//! This module provides the `RunningServicesValidator` which checks that Docker Compose
4-
//! services are running and healthy on remote instances after the `run` command has
5-
//! executed the deployment.
3+
//! This module provides the `RunningServicesValidator` which performs **end-to-end validation
4+
//! from OUTSIDE the VM** to verify that Docker Compose services are running and accessible
5+
//! after the `run` command has executed the deployment.
6+
//!
7+
//! ## Execution Context: External Validation
8+
//!
9+
//! **Why this validator is in `external_validators/` instead of `remote_actions/`**:
10+
//!
11+
//! This validator runs from the **test runner or deployment machine** and makes HTTP requests
12+
//! to services **from outside the VM**, unlike validators in `remote_actions/` which execute
13+
//! commands **inside the VM via SSH**.
14+
//!
15+
//! **Comparison**:
16+
//! - `remote_actions/validators/docker.rs` - Executes `docker --version` inside VM via SSH
17+
//! - `external_validators/running_services.rs` - Makes HTTP GET to `http://<vm-ip>:1212/health` from outside
18+
//!
19+
//! This distinction is crucial for understanding the validation scope:
20+
//! - **Remote actions**: Validate internal VM state and configuration
21+
//! - **External validators**: Validate end-to-end accessibility including network and firewall
622
//!
723
//! ## Current Scope (Torrust Tracker)
824
//!

0 commit comments

Comments
 (0)