refactor: improve function dependencies and method naming in e2e config tests

- Refactor e2e config test functions to inject SocketAddr directly instead of RunningProvisionedContainer
- Functions now receive only the ssh_service_socket_addr parameter they actually need
- Apply Dependency Inversion Principle and Interface Segregation Principle for cleaner API
- Rename RunningProvisionedContainer::ssh_details() to ssh_socket_addr() for clarity
- Better type-descriptive naming that immediately indicates return type and purpose
- Update documentation examples to reflect new method name

This reduces coupling between components and makes functions more focused on their
specific requirements, following the Principle of Least Knowledge.

Author: josecelano

src/bin/e2e_config_tests.rs

@@ -191,7 +191,7 @@ async fn configure_ssh_connectivity(
     container: &RunningProvisionedContainer,
     test_env: &TestEnvironment,
 ) -> Result<()> {
-    let socket_addr = container.ssh_details();
+    let socket_addr = container.ssh_socket_addr();
     let timeouts = ContainerTimeouts::default();
     let ssh_wait_action = SshWaitAction::new(timeouts.ssh_ready, 10);
     ssh_wait_action
@@ -231,15 +231,15 @@ async fn run_configuration_tests(templates_dir: String, instance_name: InstanceN
 
     // Step 2.5: Run provision simulation to render Ansible templates
     info!("Running provision simulation to prepare container configuration");
-    run_provision_simulation(&running_container, &test_env).await?;
+    run_provision_simulation(running_container.ssh_socket_addr(), &test_env).await?;
 
     // Step 3: Run configuration tasks (Ansible playbooks)
     info!("Running Ansible configuration tasks");
-    run_ansible_configuration(&running_container, &test_env)?;
+    run_ansible_configuration(running_container.ssh_socket_addr(), &test_env)?;
 
     // Step 4: Validate deployment
     info!("Validating service deployment");
-    run_deployment_validation(&running_container, &test_env).await?;
+    run_deployment_validation(running_container.ssh_socket_addr(), &test_env).await?;
 
     // Step 5: Cleanup - transition back to stopped state
     cleanup_container(running_container);
@@ -258,13 +258,11 @@ fn cleanup_container(running_container: RunningProvisionedContainer) {
 
 /// Run provision simulation to prepare templates for container configuration
 async fn run_provision_simulation(
-    running_container: &RunningProvisionedContainer,
+    ssh_service_socket_addr: SocketAddr,
     test_env: &TestEnvironment,
 ) -> Result<()> {
-    let socket_addr = running_container.ssh_details();
-
     info!(
-        socket_addr = %socket_addr,
+        socket_addr = %ssh_service_socket_addr,
         "Running provision simulation for container"
     );
 
@@ -282,7 +280,7 @@ async fn run_provision_simulation(
     provision_docker_infrastructure(
         Arc::clone(&services.ansible_template_renderer),
         ssh_credentials,
-        socket_addr,
+        ssh_service_socket_addr,
     )
     .await
     .context("Failed to complete Docker infrastructure provision simulation")?;
@@ -297,13 +295,11 @@ async fn run_provision_simulation(
 
 /// Run Ansible configuration tasks on the container
 fn run_ansible_configuration(
-    running_container: &RunningProvisionedContainer,
+    ssh_service_socket_addr: SocketAddr,
     test_env: &TestEnvironment,
 ) -> Result<()> {
-    let socket_addr = running_container.ssh_details();
-
     info!(
-        socket_addr = %socket_addr,
+        socket_addr = %ssh_service_socket_addr,
         "Running Ansible configuration on container"
     );
 
@@ -358,13 +354,11 @@ fn run_ansible_configuration(
 
 /// Run deployment validation tests on the container  
 async fn run_deployment_validation(
-    running_container: &RunningProvisionedContainer,
+    ssh_service_socket_addr: SocketAddr,
     test_env: &TestEnvironment,
 ) -> Result<()> {
-    let socket_addr = running_container.ssh_details();
-
     info!(
-        socket_addr = %socket_addr,
+        socket_addr = %ssh_service_socket_addr,
         "Running deployment validation on container"
     );
 
@@ -374,7 +368,7 @@ async fn run_deployment_validation(
             .context("Failed to create container SSH credentials")?;
 
     // Create SSH connection with the container's dynamic port
-    validate_container_deployment_with_port(&ssh_credentials, socket_addr)
+    validate_container_deployment_with_port(&ssh_credentials, ssh_service_socket_addr)
         .await
         .context("Container deployment validation failed")?;
 

src/e2e/containers/provisioned.rs

@@ -36,7 +36,7 @@
 //!     let running = stopped.start().await?;
 //!     
 //!     // Get connection details
-//!     let socket_addr = running.ssh_details();
+//!     let socket_addr = running.ssh_socket_addr();
 //!     
 //!     // Wait for SSH server using action directly
 //!     let ssh_wait_action = SshWaitAction::new(Duration::from_secs(30), 10);
@@ -258,9 +258,9 @@ impl RunningProvisionedContainer {
         }
     }
 
-    /// Get the SSH connection details for Ansible
+    /// Get the SSH connection details
     #[must_use]
-    pub fn ssh_details(&self) -> SocketAddr {
+    pub fn ssh_socket_addr(&self) -> SocketAddr {
         SocketAddr::new(IpAddr::V4(Ipv4Addr::LOCALHOST), self.ssh_port)
     }