Skip to content

Commit fd53b7f

Browse files
committed
refactor: [#217] Rename run_configuration_tests to run_configure_release_run_tests
The function now tests the complete configure → release → run workflow, not just configuration. Renamed to accurately reflect what is being tested: - run_configuration_tests → run_configure_release_run_tests - Updated doc comments to describe the full workflow - Updated log messages to match This binary (e2e_config_and_release_tests) tests: create → register → configure → release → run While e2e_provision_and_destroy_tests tests: create → provision → destroy The split exists because GitHub Actions runners have LXD networking limitations that prevent running commands inside provisioned VMs.
1 parent 3ede934 commit fd53b7f

File tree

1 file changed

+16
-7
lines changed

1 file changed

+16
-7
lines changed

src/bin/e2e_config_and_release_tests.rs

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ pub async fn main() -> Result<()> {
156156
// Cleanup any artifacts from previous test runs (including Docker containers)
157157
run_container_preflight_cleanup(ENVIRONMENT_NAME)?;
158158

159-
let test_result = run_configuration_tests().await;
159+
let test_result = run_configure_release_run_tests().await;
160160

161161
let test_duration = test_start.elapsed();
162162

@@ -189,9 +189,18 @@ pub async fn main() -> Result<()> {
189189
}
190190
}
191191

192-
/// Run the complete configuration tests using black-box CLI commands
193-
async fn run_configuration_tests() -> Result<()> {
194-
info!("Starting configuration tests with Docker container (black-box approach)");
192+
/// Run the complete configure → release → run workflow tests using black-box CLI commands
193+
///
194+
/// This function orchestrates the full software deployment workflow:
195+
/// 1. Create environment from config file
196+
/// 2. Register the container's IP as an existing instance
197+
/// 3. Configure services via Ansible (install Docker, etc.)
198+
/// 4. Release software (deploy Docker Compose files)
199+
/// 5. Run services (start Docker Compose)
200+
///
201+
/// Each step is followed by validation to ensure correctness.
202+
async fn run_configure_release_run_tests() -> Result<()> {
203+
info!("Starting configure → release → run tests with Docker container (black-box approach)");
195204

196205
// Build SSH credentials (same as used in e2e_config_tests)
197206
let project_root = std::env::current_dir().expect("Failed to get current directory");
@@ -221,8 +230,8 @@ async fn run_configuration_tests() -> Result<()> {
221230

222231
/// Run the deployer workflow using CLI commands (black-box approach)
223232
///
224-
/// This executes the create → register → configure workflow via CLI commands,
225-
/// followed by validation.
233+
/// This executes the create → register → configure → release → run workflow
234+
/// via CLI commands, with validation after each major step.
226235
async fn run_deployer_workflow(
227236
socket_addr: SocketAddr,
228237
ssh_credentials: &SshCredentials,
@@ -270,7 +279,7 @@ async fn run_deployer_workflow(
270279
.await
271280
.map_err(|e| anyhow::anyhow!("{e}"))?;
272281

273-
info!("Configuration tests completed successfully");
282+
info!("Configure → release → run workflow tests completed successfully");
274283

275284
Ok(())
276285
}

0 commit comments

Comments
 (0)