Skip to content

Commit 30684b5

Browse files
josecelanojosecelano
committed
Merge #1443: Overhaul stats: refactor metrics in Prometheus format
5f57f78 feat: [#1438] merge UDP tracker server metrics (Jose Celano) 44c700d feat: [#1438] merge UDP tracker core metrics (Jose Celano) 15a34c7 feat: [#1438] merge UDP tracker core metrics (Jose Celano) Pull request description: Some fixes for the UDP metrics. The new version is: ```output http_tracker_core_requests_received_total{request_kind="announce",server_binding_ip="0.0.0.0",server_binding_port="7070",server_binding_protocol="http"} 1 http_tracker_core_requests_received_total{request_kind="scrape",server_binding_ip="0.0.0.0",server_binding_port="7070",server_binding_protocol="http"} 1 udp_tracker_core_requests_received_total{request_kind="announce",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 1 udp_tracker_core_requests_received_total{request_kind="connect",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 2 udp_tracker_core_requests_received_total{request_kind="scrape",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 1 udp_tracker_server_performance_avg_processing_time_ns{request_kind="announce",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 53430 udp_tracker_server_performance_avg_processing_time_ns{request_kind="connect",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 43320.5 udp_tracker_server_performance_avg_processing_time_ns{request_kind="scrape",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 45595 udp_tracker_server_requests_accepted_total{kind="announce",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 1 udp_tracker_server_requests_accepted_total{kind="connect",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 2 udp_tracker_server_requests_accepted_total{kind="scrape",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 1 udp_tracker_server_requests_received_total{server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 4 udp_tracker_server_responses_sent_total{request_kind="announce",result="ok",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 1 udp_tracker_server_responses_sent_total{request_kind="connect",result="ok",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 2 udp_tracker_server_responses_sent_total{request_kind="scrape",result="ok",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 1 ``` You get those metrics running the tracker and the following command: ```console cargo run -p torrust-tracker-client --bin http_tracker_client announce http://127.0.0.1:7070 443c7602b4fde83d1154d6d9da48808418b181b6 | jq cargo run -p torrust-tracker-client --bin http_tracker_client scrape http://127.0.0.1:7070 443c7602b4fde83d1154d6d9da48808418b181b6 | jq cargo run -p torrust-tracker-client --bin udp_tracker_client announce udp://127.0.0.1:6969 443c7602b4fde83d1154d6d9da48808418b181b6 | jq cargo run -p torrust-tracker-client --bin udp_tracker_client scrape udp://127.0.0.1:6969 443c7602b4fde83d1154d6d9da48808418b181b6 | jq curl "http://127.0.0.1:1212/api/v1/metrics?token=MyAccessToken&format=prometheus" | sort ``` Metrics explained: ``` # each tracker client request makes also a connect requests so there are 4 requests in total # http tracker core http_tracker_core_requests_received_total{request_kind="announce",server_binding_ip="0.0.0.0",server_binding_port="7070",server_binding_protocol="http"} 1 http_tracker_core_requests_received_total{request_kind="scrape",server_binding_ip="0.0.0.0",server_binding_port="7070",server_binding_protocol="http"} 1 # udp tracker core (4 received) udp_tracker_core_requests_received_total{request_kind="connect",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 2 udp_tracker_core_requests_received_total{request_kind="announce",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 1 udp_tracker_core_requests_received_total{request_kind="scrape",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 1 # udp tracker server # request received (passed the ban filter) udp_tracker_server_requests_received_total{server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 4 # request accepted udp_tracker_server_requests_accepted_total{kind="connect",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 2 udp_tracker_server_requests_accepted_total{kind="announce",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 1 udp_tracker_server_requests_accepted_total{kind="scrape",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 1 udp_tracker_server_responses_sent_total{request_kind="connect",result="ok",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 2 udp_tracker_server_responses_sent_total{request_kind="announce",result="ok",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 1 udp_tracker_server_responses_sent_total{request_kind="scrape",result="ok",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 1 udp_tracker_server_performance_avg_processing_time_ns{request_kind="connect",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 43320.5 udp_tracker_server_performance_avg_processing_time_ns{request_kind="announce",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 53430 udp_tracker_server_performance_avg_processing_time_ns{request_kind="scrape",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 45595 ``` ACKs for top commit: josecelano: ACK 5f57f78 Tree-SHA512: d9736a1194e8ee727eb9620a4d1ee234f781b27d2d6a5870bbf624bf4d551879f6120c5b44119409d66004babe6d72c13f15a03b783155cbeaac8ad69cb6d2d8
2 parents 8a36e45 + 5f57f78 commit 30684b5

File tree

6 files changed

+83
-92
lines changed

6 files changed

+83
-92
lines changed

‎packages/http-tracker-core/src/statistics/event/handler.rs‎

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
use std::net::IpAddr;
22

3-
use torrust_tracker_metrics::label::LabelSet;
3+
use torrust_tracker_metrics::label::{LabelName, LabelSet, LabelValue};
44
use torrust_tracker_metrics::metric::MetricName;
55
use torrust_tracker_primitives::DurationSinceUnixEpoch;
66

77
use crate::event::Event;
88
use crate::statistics::repository::Repository;
9+
use crate::statistics::HTTP_TRACKER_CORE_REQUESTS_RECEIVED_TOTAL;
910

1011
/// # Panics
1112
///
@@ -27,12 +28,11 @@ pub async fn handle_event(event: Event, stats_repository: &Repository, now: Dura
2728

2829
// Extendable metrics
2930

31+
let mut label_set = LabelSet::from(connection);
32+
label_set.upsert(LabelName::new("request_kind"), LabelValue::new("announce"));
33+
3034
stats_repository
31-
.increase_counter(
32-
&MetricName::new("http_tracker_core_announce_requests_received_total"),
33-
&LabelSet::from(connection),
34-
now,
35-
)
35+
.increase_counter(&MetricName::new(HTTP_TRACKER_CORE_REQUESTS_RECEIVED_TOTAL), &label_set, now)
3636
.await;
3737
}
3838
Event::TcpScrape { connection } => {
@@ -49,12 +49,11 @@ pub async fn handle_event(event: Event, stats_repository: &Repository, now: Dura
4949

5050
// Extendable metrics
5151

52+
let mut label_set = LabelSet::from(connection);
53+
label_set.upsert(LabelName::new("request_kind"), LabelValue::new("scrape"));
54+
5255
stats_repository
53-
.increase_counter(
54-
&MetricName::new("http_tracker_core_scrape_requests_received_total"),
55-
&LabelSet::from(connection),
56-
now,
57-
)
56+
.increase_counter(&MetricName::new(HTTP_TRACKER_CORE_REQUESTS_RECEIVED_TOTAL), &label_set, now)
5857
.await;
5958
}
6059
}

‎packages/http-tracker-core/src/statistics/mod.rs‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,20 +10,16 @@ use torrust_tracker_metrics::metric::description::MetricDescription;
1010
use torrust_tracker_metrics::metric::MetricName;
1111
use torrust_tracker_metrics::unit::Unit;
1212

13+
const HTTP_TRACKER_CORE_REQUESTS_RECEIVED_TOTAL: &str = "http_tracker_core_requests_received_total";
14+
1315
#[must_use]
1416
pub fn describe_metrics() -> Metrics {
1517
let mut metrics = Metrics::default();
1618

1719
metrics.metric_collection.describe_counter(
18-
&MetricName::new("http_tracker_core_announce_requests_received_total"),
19-
Some(Unit::Count),
20-
Some(MetricDescription::new("Total number of HTTP announce requests received")),
21-
);
22-
23-
metrics.metric_collection.describe_counter(
24-
&MetricName::new("http_tracker_core_scrape_requests_received_total"),
20+
&MetricName::new(HTTP_TRACKER_CORE_REQUESTS_RECEIVED_TOTAL),
2521
Some(Unit::Count),
26-
Some(MetricDescription::new("Total number of HTTP scrape requests received")),
22+
Some(MetricDescription::new("Total number of HTTP requests received")),
2723
);
2824

2925
metrics

‎packages/udp-tracker-core/src/statistics/event/handler.rs‎

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
1-
use torrust_tracker_metrics::label::LabelSet;
1+
use torrust_tracker_metrics::label::{LabelName, LabelSet, LabelValue};
22
use torrust_tracker_metrics::metric::MetricName;
33
use torrust_tracker_primitives::DurationSinceUnixEpoch;
44

55
use crate::event::Event;
66
use crate::statistics::repository::Repository;
7+
use crate::statistics::UDP_TRACKER_CORE_REQUESTS_RECEIVED_TOTAL;
78

89
/// # Panics
910
///
@@ -24,12 +25,11 @@ pub async fn handle_event(event: Event, stats_repository: &Repository, now: Dura
2425

2526
// Extendable metrics
2627

28+
let mut label_set = LabelSet::from(context);
29+
label_set.upsert(LabelName::new("request_kind"), LabelValue::new("connect"));
30+
2731
stats_repository
28-
.increase_counter(
29-
&MetricName::new("udp_tracker_core_connect_requests_received_total"),
30-
&LabelSet::from(context),
31-
now,
32-
)
32+
.increase_counter(&MetricName::new(UDP_TRACKER_CORE_REQUESTS_RECEIVED_TOTAL), &label_set, now)
3333
.await;
3434
}
3535
Event::UdpAnnounce { context } => {
@@ -46,12 +46,11 @@ pub async fn handle_event(event: Event, stats_repository: &Repository, now: Dura
4646

4747
// Extendable metrics
4848

49+
let mut label_set = LabelSet::from(context);
50+
label_set.upsert(LabelName::new("request_kind"), LabelValue::new("announce"));
51+
4952
stats_repository
50-
.increase_counter(
51-
&MetricName::new("udp_tracker_core_announce_requests_received_total"),
52-
&LabelSet::from(context),
53-
now,
54-
)
53+
.increase_counter(&MetricName::new(UDP_TRACKER_CORE_REQUESTS_RECEIVED_TOTAL), &label_set, now)
5554
.await;
5655
}
5756
Event::UdpScrape { context } => {
@@ -68,12 +67,11 @@ pub async fn handle_event(event: Event, stats_repository: &Repository, now: Dura
6867

6968
// Extendable metrics
7069

70+
let mut label_set = LabelSet::from(context);
71+
label_set.upsert(LabelName::new("request_kind"), LabelValue::new("scrape"));
72+
7173
stats_repository
72-
.increase_counter(
73-
&MetricName::new("udp_tracker_core_scrape_requests_received_total"),
74-
&LabelSet::from(context),
75-
now,
76-
)
74+
.increase_counter(&MetricName::new(UDP_TRACKER_CORE_REQUESTS_RECEIVED_TOTAL), &label_set, now)
7775
.await;
7876
}
7977
}

‎packages/udp-tracker-core/src/statistics/mod.rs‎

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -10,26 +10,16 @@ use torrust_tracker_metrics::metric::description::MetricDescription;
1010
use torrust_tracker_metrics::metric::MetricName;
1111
use torrust_tracker_metrics::unit::Unit;
1212

13+
const UDP_TRACKER_CORE_REQUESTS_RECEIVED_TOTAL: &str = "udp_tracker_core_requests_received_total";
14+
1315
#[must_use]
1416
pub fn describe_metrics() -> Metrics {
1517
let mut metrics = Metrics::default();
1618

1719
metrics.metric_collection.describe_counter(
18-
&MetricName::new("udp_tracker_core_connect_requests_received_total"),
19-
Some(Unit::Count),
20-
Some(MetricDescription::new("Total number of UDP connect requests received")),
21-
);
22-
23-
metrics.metric_collection.describe_counter(
24-
&MetricName::new("udp_tracker_core_announce_requests_received_total"),
25-
Some(Unit::Count),
26-
Some(MetricDescription::new("Total number of UDP announce requests received")),
27-
);
28-
29-
metrics.metric_collection.describe_counter(
30-
&MetricName::new("udp_tracker_core_scrape_requests_received_total"),
20+
&MetricName::new(UDP_TRACKER_CORE_REQUESTS_RECEIVED_TOTAL),
3121
Some(Unit::Count),
32-
Some(MetricDescription::new("Total number of UDP scrape requests received")),
22+
Some(MetricDescription::new("Total number of UDP requests received")),
3323
);
3424

3525
metrics

‎packages/udp-tracker-server/src/statistics/event/handler.rs‎

Lines changed: 36 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ use torrust_tracker_primitives::DurationSinceUnixEpoch;
44

55
use crate::event::{Event, UdpRequestKind, UdpResponseKind};
66
use crate::statistics::repository::Repository;
7+
use crate::statistics::{
8+
UDP_TRACKER_SERVER_ERRORS_TOTAL, UDP_TRACKER_SERVER_PERFORMANCE_AVG_PROCESSING_TIME_NS,
9+
UDP_TRACKER_SERVER_REQUESTS_ABORTED_TOTAL, UDP_TRACKER_SERVER_REQUESTS_ACCEPTED_TOTAL,
10+
UDP_TRACKER_SERVER_REQUESTS_BANNED_TOTAL, UDP_TRACKER_SERVER_REQUESTS_RECEIVED_TOTAL,
11+
UDP_TRACKER_SERVER_RESPONSES_SENT_TOTAL,
12+
};
713

814
/// # Panics
915
///
@@ -19,7 +25,7 @@ pub async fn handle_event(event: Event, stats_repository: &Repository, now: Dura
1925
// Extendable metrics
2026
stats_repository
2127
.increase_counter(
22-
&MetricName::new("udp_tracker_server_requests_aborted_total"),
28+
&MetricName::new(UDP_TRACKER_SERVER_REQUESTS_ABORTED_TOTAL),
2329
&LabelSet::from(context),
2430
now,
2531
)
@@ -32,7 +38,7 @@ pub async fn handle_event(event: Event, stats_repository: &Repository, now: Dura
3238
// Extendable metrics
3339
stats_repository
3440
.increase_counter(
35-
&MetricName::new("udp_tracker_server_requests_banned_total"),
41+
&MetricName::new(UDP_TRACKER_SERVER_REQUESTS_BANNED_TOTAL),
3642
&LabelSet::from(context),
3743
now,
3844
)
@@ -52,7 +58,7 @@ pub async fn handle_event(event: Event, stats_repository: &Repository, now: Dura
5258
// Extendable metrics
5359
stats_repository
5460
.increase_counter(
55-
&MetricName::new("udp_tracker_server_requests_received_total"),
61+
&MetricName::new(UDP_TRACKER_SERVER_REQUESTS_RECEIVED_TOTAL),
5662
&LabelSet::from(context),
5763
now,
5864
)
@@ -94,11 +100,7 @@ pub async fn handle_event(event: Event, stats_repository: &Repository, now: Dura
94100
label_set.upsert(LabelName::new("kind"), LabelValue::new(&kind.to_string()));
95101

96102
stats_repository
97-
.increase_counter(
98-
&MetricName::new("udp_tracker_server_requests_accepted_total"),
99-
&label_set,
100-
now,
101-
)
103+
.increase_counter(&MetricName::new(UDP_TRACKER_SERVER_REQUESTS_ACCEPTED_TOTAL), &label_set, now)
102104
.await;
103105
}
104106
Event::UdpResponseSent {
@@ -124,10 +126,14 @@ pub async fn handle_event(event: Event, stats_repository: &Repository, now: Dura
124126
.await;
125127

126128
// Extendable metrics
129+
130+
let mut label_set = LabelSet::from(context.clone());
131+
label_set.upsert(LabelName::new("request_kind"), LabelValue::new(&req_kind.to_string()));
132+
127133
stats_repository
128134
.set_gauge(
129-
&MetricName::new("udp_tracker_server_performance_avg_connect_processing_time_ns"),
130-
&LabelSet::from(context.clone()),
135+
&MetricName::new(UDP_TRACKER_SERVER_PERFORMANCE_AVG_PROCESSING_TIME_NS),
136+
&label_set,
131137
new_avg,
132138
now,
133139
)
@@ -141,47 +147,57 @@ pub async fn handle_event(event: Event, stats_repository: &Repository, now: Dura
141147
.await;
142148

143149
// Extendable metrics
150+
151+
let mut label_set = LabelSet::from(context.clone());
152+
label_set.upsert(LabelName::new("request_kind"), LabelValue::new(&req_kind.to_string()));
153+
144154
stats_repository
145155
.set_gauge(
146-
&MetricName::new("udp_tracker_server_performance_avg_announce_processing_time_ns"),
147-
&LabelSet::from(context.clone()),
156+
&MetricName::new(UDP_TRACKER_SERVER_PERFORMANCE_AVG_PROCESSING_TIME_NS),
157+
&label_set,
148158
new_avg,
149159
now,
150160
)
151161
.await;
152162

153-
(LabelValue::new("ok"), LabelValue::new(&UdpRequestKind::Connect.to_string()))
163+
(LabelValue::new("ok"), LabelValue::new(&UdpRequestKind::Announce.to_string()))
154164
}
155165
UdpRequestKind::Scrape => {
156166
let new_avg = stats_repository
157167
.recalculate_udp_avg_scrape_processing_time_ns(req_processing_time)
158168
.await;
159169

160170
// Extendable metrics
171+
172+
let mut label_set = LabelSet::from(context.clone());
173+
label_set.upsert(LabelName::new("request_kind"), LabelValue::new(&req_kind.to_string()));
174+
161175
stats_repository
162176
.set_gauge(
163-
&MetricName::new("udp_tracker_server_performance_avg_scrape_processing_time_ns"),
164-
&LabelSet::from(context.clone()),
177+
&MetricName::new(UDP_TRACKER_SERVER_PERFORMANCE_AVG_PROCESSING_TIME_NS),
178+
&label_set,
165179
new_avg,
166180
now,
167181
)
168182
.await;
169183

170-
(LabelValue::new("ok"), LabelValue::new(&UdpRequestKind::Connect.to_string()))
184+
(LabelValue::new("ok"), LabelValue::new(&UdpRequestKind::Scrape.to_string()))
171185
}
172186
},
173-
UdpResponseKind::Error { opt_req_kind: _ } => (LabelValue::new("ok"), LabelValue::ignore()),
187+
UdpResponseKind::Error { opt_req_kind: _ } => (LabelValue::new("error"), LabelValue::ignore()),
174188
};
175189

176190
// Extendable metrics
177191

178192
let mut label_set = LabelSet::from(context);
179193

194+
if result_label_value == LabelValue::new("ok") {
195+
label_set.upsert(LabelName::new("request_kind"), kind_label_value);
196+
}
180197
label_set.upsert(LabelName::new("result"), result_label_value);
181-
label_set.upsert(LabelName::new("kind"), kind_label_value);
182198

183199
stats_repository
184-
.increase_counter(&MetricName::new("udp_tracker_server_responses_sent_total"), &label_set, now)
200+
.increase_counter(&MetricName::new(UDP_TRACKER_SERVER_RESPONSES_SENT_TOTAL), &label_set, now)
185201
.await;
186202
}
187203
Event::UdpError { context } => {
@@ -198,7 +214,7 @@ pub async fn handle_event(event: Event, stats_repository: &Repository, now: Dura
198214
// Extendable metrics
199215
stats_repository
200216
.increase_counter(
201-
&MetricName::new("udp_tracker_server_errors_total"),
217+
&MetricName::new(UDP_TRACKER_SERVER_ERRORS_TOTAL),
202218
&LabelSet::from(context),
203219
now,
204220
)

‎packages/udp-tracker-server/src/statistics/mod.rs‎

Lines changed: 15 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -10,69 +10,61 @@ use torrust_tracker_metrics::metric::description::MetricDescription;
1010
use torrust_tracker_metrics::metric::MetricName;
1111
use torrust_tracker_metrics::unit::Unit;
1212

13+
const UDP_TRACKER_SERVER_REQUESTS_ABORTED_TOTAL: &str = "udp_tracker_server_requests_aborted_total";
14+
const UDP_TRACKER_SERVER_REQUESTS_BANNED_TOTAL: &str = "udp_tracker_server_requests_banned_total";
15+
const UDP_TRACKER_SERVER_REQUESTS_RECEIVED_TOTAL: &str = "udp_tracker_server_requests_received_total";
16+
const UDP_TRACKER_SERVER_REQUESTS_ACCEPTED_TOTAL: &str = "udp_tracker_server_requests_accepted_total";
17+
const UDP_TRACKER_SERVER_RESPONSES_SENT_TOTAL: &str = "udp_tracker_server_responses_sent_total";
18+
const UDP_TRACKER_SERVER_ERRORS_TOTAL: &str = "udp_tracker_server_errors_total";
19+
const UDP_TRACKER_SERVER_PERFORMANCE_AVG_PROCESSING_TIME_NS: &str = "udp_tracker_server_performance_avg_processing_time_ns";
20+
1321
#[must_use]
1422
pub fn describe_metrics() -> Metrics {
1523
let mut metrics = Metrics::default();
1624

1725
metrics.metric_collection.describe_counter(
18-
&MetricName::new("udp_tracker_server_requests_aborted_total"),
26+
&MetricName::new(UDP_TRACKER_SERVER_REQUESTS_ABORTED_TOTAL),
1927
Some(Unit::Count),
2028
Some(MetricDescription::new("Total number of UDP requests aborted")),
2129
);
2230

2331
metrics.metric_collection.describe_counter(
24-
&MetricName::new("udp_tracker_server_requests_banned_total"),
32+
&MetricName::new(UDP_TRACKER_SERVER_REQUESTS_BANNED_TOTAL),
2533
Some(Unit::Count),
2634
Some(MetricDescription::new("Total number of UDP requests banned")),
2735
);
2836

2937
metrics.metric_collection.describe_counter(
30-
&MetricName::new("udp_tracker_server_requests_received_total"),
38+
&MetricName::new(UDP_TRACKER_SERVER_REQUESTS_RECEIVED_TOTAL),
3139
Some(Unit::Count),
3240
Some(MetricDescription::new("Total number of UDP requests received")),
3341
);
3442

3543
metrics.metric_collection.describe_counter(
36-
&MetricName::new("udp_tracker_server_requests_accepted_total"),
44+
&MetricName::new(UDP_TRACKER_SERVER_REQUESTS_ACCEPTED_TOTAL),
3745
Some(Unit::Count),
3846
Some(MetricDescription::new("Total number of UDP requests accepted")),
3947
);
4048

4149
metrics.metric_collection.describe_counter(
42-
&MetricName::new("udp_tracker_server_responses_sent_total"),
50+
&MetricName::new(UDP_TRACKER_SERVER_RESPONSES_SENT_TOTAL),
4351
Some(Unit::Count),
4452
Some(MetricDescription::new("Total number of UDP responses sent")),
4553
);
4654

4755
metrics.metric_collection.describe_counter(
48-
&MetricName::new("udp_tracker_server_errors_total"),
56+
&MetricName::new(UDP_TRACKER_SERVER_ERRORS_TOTAL),
4957
Some(Unit::Count),
5058
Some(MetricDescription::new("Total number of errors processing UDP requests")),
5159
);
5260

5361
metrics.metric_collection.describe_gauge(
54-
&MetricName::new("udp_tracker_server_performance_avg_connect_processing_time_ns"),
62+
&MetricName::new(UDP_TRACKER_SERVER_PERFORMANCE_AVG_PROCESSING_TIME_NS),
5563
Some(Unit::Nanoseconds),
5664
Some(MetricDescription::new(
5765
"Average time to process a UDP connect request in nanoseconds",
5866
)),
5967
);
6068

61-
metrics.metric_collection.describe_gauge(
62-
&MetricName::new("udp_tracker_server_performance_avg_announce_processing_time_ns"),
63-
Some(Unit::Nanoseconds),
64-
Some(MetricDescription::new(
65-
"Average time to process a UDP announce request in nanoseconds",
66-
)),
67-
);
68-
69-
metrics.metric_collection.describe_gauge(
70-
&MetricName::new("udp_tracker_server_performance_avg_scrape_processing_time_ns"),
71-
Some(Unit::Nanoseconds),
72-
Some(MetricDescription::new(
73-
"Average time to process a UDP scrape request in nanoseconds",
74-
)),
75-
);
76-
7769
metrics
7870
}

0 commit comments

Comments
 (0)