Merge #1509: Fix wrong number of downloads when the tracker starts

632185b refactor: tracing spwams to use structure formats (Jose Celano)
ced2788 fix: [#1502] import torrents' download counters from DB (Jose Celano)
46c7eae dev: enable persistence for downdloads in dev config (Jose Celano)

Pull request description:

  Relates to: #1502

  As described [here](#1502 (comment)), when you start the tracker and stats persistence is enabled, you should see the last value for the number of downloads. Instead, you see something like this:

  ![image](https://github.com/user-attachments/assets/9fffeb7f-5666-41f0-ac64-7049a6225a17)

  This PR fixes that problem.

  It fixes the bug described in #1502. However, it does not fix other problems described in the issue (problem 3). I will open a new PR to fix problem 3.

ACKs for top commit:
  josecelano:
    ACK 632185b

Tree-SHA512: 5234afb19f35368c3fa678ab064aaa4f011c743b353ec5ffc4282c6bafffca3689068d9f85f5b26f9115a412952bd844862ca497c8c1c5040c01d396acf82d39

Author: josecelano

packages/torrent-repository/src/swarms.rs

@@ -231,7 +231,7 @@ impl Swarms {
             inactive_peers_removed += removed;
         }
 
-        tracing::info!("Inactive peers removed: {inactive_peers_removed}");
+        tracing::info!(inactive_peers_removed = inactive_peers_removed);
 
         Ok(inactive_peers_removed)
     }
@@ -262,7 +262,7 @@ impl Swarms {
             peerless_torrents_removed += 1;
         }
 
-        tracing::info!("Peerless torrents removed: {peerless_torrents_removed}");
+        tracing::info!(peerless_torrents_removed = peerless_torrents_removed);
 
         Ok(peerless_torrents_removed)
     }
@@ -291,7 +291,7 @@ impl Swarms {
             torrents_imported += 1;
         }
 
-        tracing::info!("Imported torrents: {torrents_imported}");
+        tracing::info!(imported_torrents = torrents_imported);
 
         torrents_imported
     }

packages/tracker-core/src/torrent/manager.rs

@@ -60,7 +60,7 @@ impl TorrentsManager {
         }
     }
 
-    /// Loads torrents from the persistent database into the in-memory repository.
+    /// Loads torrents from the database into the in-memory repository.
     ///
     /// This function retrieves the list of persistent torrent entries (which
     /// include only the aggregate metrics, not the detailed peer lists) from
@@ -70,8 +70,7 @@ impl TorrentsManager {
     ///
     /// Returns a `databases::error::Error` if unable to load the persistent
     /// torrent data.
-    #[allow(dead_code)]
-    pub(crate) fn load_torrents_from_database(&self) -> Result<(), databases::error::Error> {
+    pub fn load_torrents_from_database(&self) -> Result<(), databases::error::Error> {
         let persistent_torrents = self.db_torrent_repository.load_all()?;
 
         self.in_memory_torrent_repository.import_persistent(&persistent_torrents);

share/default/config/tracker.development.sqlite3.toml

@@ -11,9 +11,9 @@ threshold = "info"
 listed = false
 private = false
 
-#[core.tracker_policy]
+[core.tracker_policy]
 #max_peer_timeout = 30
-#persistent_torrent_completed_stat = true
+persistent_torrent_completed_stat = true
 #remove_peerless_torrents = true
 
 [[udp_trackers]]

src/app.rs

@@ -61,6 +61,7 @@ pub async fn start(config: &Configuration, app_container: &Arc<AppContainer>) ->
 async fn load_data_from_database(config: &Configuration, app_container: &Arc<AppContainer>) {
     load_peer_keys(config, app_container).await;
     load_whitelisted_torrents(config, app_container).await;
+    load_torrents_from_database(config, app_container);
 }
 
 async fn start_jobs(config: &Configuration, app_container: &Arc<AppContainer>) -> JobManager {
@@ -109,6 +110,16 @@ async fn load_whitelisted_torrents(config: &Configuration, app_container: &Arc<A
     }
 }
 
+fn load_torrents_from_database(config: &Configuration, app_container: &Arc<AppContainer>) {
+    if config.core.tracker_policy.persistent_torrent_completed_stat {
+        app_container
+            .tracker_core_container
+            .torrents_manager
+            .load_torrents_from_database()
+            .expect("Could not load torrents from database.");
+    }
+}
+
 fn start_http_core_event_listener(config: &Configuration, app_container: &Arc<AppContainer>, job_manager: &mut JobManager) {
     let opt_handle = jobs::http_tracker_core::start_event_listener(config, app_container);