Commit 6735018
committed
Merge #1520: Remove integration tests from torrent-repository package
1472c8e refactor: [#1504] remove unneded trait implementationis for Swarm (Jose Celano)
c2dabb2 chore: [#1504] remove uneeded fn attribute (Jose Celano)
8d3b948 tests: [#1504] remove integration tests from torrent-repository pacakge (Jose Celano)
Pull request description:
All features are now covered by unit tests.
I have also removed unused trait implementations for the `Swarm` type. If we need them in the future, we should extract a private type to use derived implementations:
From:
```rust
#[derive(Clone)]
pub struct Swarm {
info_hash: InfoHash,
peers: BTreeMap<SocketAddr, Arc<PeerAnnouncement>>,
metadata: SwarmMetadata,
event_sender: Sender,
}
```
To:
```rust
#[derive(Clone)]
pub struct Swarm {
data: SwarmData,
event_sender: Sender,
}
#[derive(Clone, Debug, Display, Hash, PartialEq, Eq)]
pub struct SwarmData {
info_hash: InfoHash,
peers: BTreeMap<SocketAddr, Arc<PeerAnnouncement>>,
metadata: SwarmMetadata,
}
```
ACKs for top commit:
josecelano:
ACK 1472c8e
Tree-SHA512: f350957ed47f234e41762e523bef66e337176e91011c3fbed4219a10bae44cca11a29e7736392f759d1d67f298553ec0c4a2960bed6817f3035cea8acc0beccfFile tree
7 files changed
+0
-1088
lines changed- packages/torrent-repository
- src
- tests
- common
- swarms
- swarm
7 files changed
+0
-1088
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
6 | 4 | | |
7 | 5 | | |
8 | 6 | | |
| |||
24 | 22 | | |
25 | 23 | | |
26 | 24 | | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | 25 | | |
53 | 26 | | |
54 | 27 | | |
| |||
329 | 302 | | |
330 | 303 | | |
331 | 304 | | |
332 | | - | |
333 | | - | |
334 | | - | |
335 | | - | |
336 | | - | |
337 | | - | |
338 | | - | |
339 | | - | |
340 | | - | |
341 | | - | |
342 | 305 | | |
343 | 306 | | |
344 | 307 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
53 | 52 | | |
54 | 53 | | |
55 | 54 | | |
| |||
This file was deleted.
Lines changed: 0 additions & 106 deletions
This file was deleted.
This file was deleted.
0 commit comments