fix: clippy errors

Author: josecelano

packages/axum-http-tracker-server/src/server.rs

@@ -47,7 +47,7 @@ impl Launcher {
     #[instrument(skip(self, http_tracker_container, tx_start, rx_halt))]
     fn start(
         &self,
-        http_tracker_container: Arc<HttpTrackerCoreContainer>,
+        http_tracker_container: &Arc<HttpTrackerCoreContainer>,
         tx_start: Sender<Started>,
         rx_halt: Receiver<Halted>,
     ) -> BoxFuture<'static, ()> {
@@ -69,7 +69,7 @@ impl Launcher {
 
         tracing::info!(target: HTTP_TRACKER_LOG_TARGET, "Starting on: {protocol}://{address}");
 
-        let app = router(http_tracker_container, service_binding.clone());
+        let app = router(http_tracker_container, &service_binding);
 
         let running = Box::pin(async {
             match tls {
@@ -176,7 +176,7 @@ impl HttpServer<Stopped> {
         let launcher = self.state.launcher;
 
         let task = tokio::spawn(async move {
-            let server = launcher.start(http_tracker_container, tx_start, rx_halt);
+            let server = launcher.start(&http_tracker_container, tx_start, rx_halt);
 
             server.await;
 

packages/axum-http-tracker-server/src/v1/routes.rs

@@ -31,7 +31,7 @@ use crate::HTTP_TRACKER_LOG_TARGET;
 /// > **NOTICE**: it's added a layer to get the client IP from the connection
 /// > info. The tracker could use the connection info to get the client IP.
 #[instrument(skip(http_tracker_container, server_service_binding))]
-pub fn router(http_tracker_container: Arc<HttpTrackerCoreContainer>, server_service_binding: ServiceBinding) -> Router {
+pub fn router(http_tracker_container: &Arc<HttpTrackerCoreContainer>, server_service_binding: &ServiceBinding) -> Router {
     let server_socket_addr = server_service_binding.bind_address();
 
     Router::new()

packages/axum-rest-tracker-api-server/src/routes.rs

@@ -36,15 +36,15 @@ use crate::API_LOG_TARGET;
 /// Add all API routes to the router.
 #[instrument(skip(http_api_container, access_tokens))]
 pub fn router(
-    http_api_container: Arc<TrackerHttpApiCoreContainer>,
+    http_api_container: &Arc<TrackerHttpApiCoreContainer>,
     access_tokens: Arc<AccessTokens>,
     server_socket_addr: SocketAddr,
 ) -> Router {
     let router = Router::new();
 
     let api_url_prefix = "/api";
 
-    let router = v1::routes::add(api_url_prefix, router, &http_api_container);
+    let router = v1::routes::add(api_url_prefix, router, http_api_container);
 
     let state = State { access_tokens };
 

packages/axum-rest-tracker-api-server/src/server.rs

@@ -140,7 +140,7 @@ impl ApiServer<Stopped> {
         let task = tokio::spawn(async move {
             tracing::debug!(target: API_LOG_TARGET, "Starting with launcher in spawned task ...");
 
-            let _task = launcher.start(http_api_container, access_tokens, tx_start, rx_halt).await;
+            let _task = launcher.start(&http_api_container, access_tokens, tx_start, rx_halt).await;
 
             tracing::debug!(target: API_LOG_TARGET, "Started with launcher in spawned task");
 
@@ -241,7 +241,7 @@ impl Launcher {
     #[instrument(skip(self, http_api_container, access_tokens, tx_start, rx_halt))]
     pub fn start(
         &self,
-        http_api_container: Arc<TrackerHttpApiCoreContainer>,
+        http_api_container: &Arc<TrackerHttpApiCoreContainer>,
         access_tokens: Arc<AccessTokens>,
         tx_start: Sender<Started>,
         rx_halt: Receiver<Halted>,

packages/torrent-repository-benchmarking/tests/repository/mod.rs

@@ -450,7 +450,9 @@ async fn it_should_import_persistent_torrents(
     make(&repo, &entries).await;
 
     let mut downloaded = repo.get_metrics().await.total_downloaded;
-    persistent_torrents.iter().for_each(|(_, d)| downloaded += u64::from(*d));
+    for d in persistent_torrents.values() {
+        downloaded += u64::from(*d);
+    }
 
     repo.import_persistent(&persistent_torrents).await;
 

packages/udp-tracker-server/src/handlers/mod.rs

@@ -28,7 +28,7 @@ use crate::event::UdpRequestKind;
 use crate::CurrentClock;
 
 #[derive(Debug, Clone, PartialEq)]
-pub(super) struct CookieTimeValues {
+pub struct CookieTimeValues {
     pub(super) issue_time: f64,
     pub(super) valid_range: Range<f64>,
 }