test: remove logs assertions

The assertions were not using any specific scope. There is no way to
match a logs line qith a test. I tried using:

```rust
async fn should_blab_bla() {

    let span = tracing::info_span!("unique scope");
    let _guard = span.enter();

    // test

    assert!(logs_contains_a_line_with(
        "unique scope",
        &["ERROR", "tower_http", "response failed"]
    ));
}
```

But span in not clone into the spwaned tasks, so log lines do not
contain the scope. In the end, it's what happening in this bug:

https://github.com/josecelano/tracing-test-bug

Author: josecelano

tests/common/logging.rs

@@ -41,31 +41,33 @@ fn tracing_init(level_filter: LevelFilter, style: &TraceStyle) {
     tracing::info!("Logging initialized");
 }
 
-/// It returns true is there is a log line containing all the words passed.
+/// It returns true is there is a log line containing all the texts passed.
 ///
 /// # Panics
 ///
 /// Will panic if it can't get the lock for the global buffer or convert it into
 /// a vec.
 #[must_use]
-pub fn logs_contains_a_line_with(words: &[&str]) -> bool {
+#[allow(dead_code)]
+pub fn logs_contains_a_line_with(texts: &[&str]) -> bool {
     // code-review: we can search directly in the buffer instead of converting
     // the buffer into a string but that would slow down the tests because
     // cloning should be faster that locking the buffer for searching.
     // Because the buffer is not big.
     let logs = String::from_utf8(captured_logs_buffer().lock().unwrap().as_vec()).unwrap();
 
     for line in logs.split('\n') {
-        if contains_words_in_any_order(line, words) {
+        if contains(line, texts) {
             return true;
         }
     }
 
     false
 }
 
-fn contains_words_in_any_order(text: &str, words: &[&str]) -> bool {
-    words.iter().all(|&word| text.contains(word))
+#[allow(dead_code)]
+fn contains(text: &str, texts: &[&str]) -> bool {
+    texts.iter().all(|&word| text.contains(word))
 }
 
 /// A tracing writer which captures the latests logs lines into a buffer.

tests/servers/api/v1/contract/authentication.rs

@@ -2,7 +2,7 @@ use torrust_tracker_test_helpers::configuration;
 use tracing::level_filters::LevelFilter;
 
 use crate::common::http::{Query, QueryParam};
-use crate::common::logging::{self, logs_contains_a_line_with};
+use crate::common::logging::{self};
 use crate::servers::api::v1::asserts::{assert_token_not_valid, assert_unauthorized};
 use crate::servers::api::v1::client::Client;
 use crate::servers::api::Started;
@@ -35,8 +35,6 @@ async fn should_not_authenticate_requests_when_the_token_is_missing() {
     assert_unauthorized(response).await;
 
     env.stop().await;
-
-    assert!(logs_contains_a_line_with(&["ERROR", "tower_http", "response failed"]));
 }
 
 #[tokio::test]
@@ -52,8 +50,6 @@ async fn should_not_authenticate_requests_when_the_token_is_empty() {
     assert_token_not_valid(response).await;
 
     env.stop().await;
-
-    assert!(logs_contains_a_line_with(&["ERROR", "tower_http", "response failed"]));
 }
 
 #[tokio::test]
@@ -69,8 +65,6 @@ async fn should_not_authenticate_requests_when_the_token_is_invalid() {
     assert_token_not_valid(response).await;
 
     env.stop().await;
-
-    assert!(logs_contains_a_line_with(&["ERROR", "tower_http", "response failed"]));
 }
 
 #[tokio::test]

tests/servers/api/v1/contract/context/auth_key.rs

@@ -5,7 +5,7 @@ use torrust_tracker::core::auth::Key;
 use torrust_tracker_test_helpers::configuration;
 use tracing::level_filters::LevelFilter;
 
-use crate::common::logging::{self, logs_contains_a_line_with};
+use crate::common::logging::{self};
 use crate::servers::api::connection_info::{connection_with_invalid_token, connection_with_no_token};
 use crate::servers::api::v1::asserts::{
     assert_auth_key_utf8, assert_failed_to_delete_key, assert_failed_to_generate_key, assert_failed_to_reload_keys,
@@ -84,8 +84,6 @@ async fn should_not_allow_generating_a_new_auth_key_for_unauthenticated_users()
     assert_unauthorized(response).await;
 
     env.stop().await;
-
-    assert!(logs_contains_a_line_with(&["ERROR", "tower_http", "response failed"]));
 }
 
 #[tokio::test]
@@ -106,8 +104,6 @@ async fn should_fail_when_the_auth_key_cannot_be_generated() {
     assert_failed_to_generate_key(response).await;
 
     env.stop().await;
-
-    assert!(logs_contains_a_line_with(&["ERROR", "tower_http", "response failed"]));
 }
 
 #[tokio::test]
@@ -246,8 +242,6 @@ async fn should_fail_when_the_auth_key_cannot_be_deleted() {
     assert_failed_to_delete_key(response).await;
 
     env.stop().await;
-
-    assert!(logs_contains_a_line_with(&["ERROR", "tower_http", "response failed"]));
 }
 
 #[tokio::test]
@@ -285,8 +279,6 @@ async fn should_not_allow_deleting_an_auth_key_for_unauthenticated_users() {
     assert_unauthorized(response).await;
 
     env.stop().await;
-
-    assert!(logs_contains_a_line_with(&["ERROR", "tower_http", "response failed"]));
 }
 
 #[tokio::test]
@@ -325,8 +317,6 @@ async fn should_fail_when_keys_cannot_be_reloaded() {
     assert_failed_to_reload_keys(response).await;
 
     env.stop().await;
-
-    assert!(logs_contains_a_line_with(&["ERROR", "tower_http", "response failed"]));
 }
 
 #[tokio::test]
@@ -354,8 +344,6 @@ async fn should_not_allow_reloading_keys_for_unauthenticated_users() {
     assert_unauthorized(response).await;
 
     env.stop().await;
-
-    assert!(logs_contains_a_line_with(&["ERROR", "tower_http", "response failed"]));
 }
 
 mod deprecated_generate_key_endpoint {
@@ -364,7 +352,7 @@ mod deprecated_generate_key_endpoint {
     use torrust_tracker_test_helpers::configuration;
     use tracing::level_filters::LevelFilter;
 
-    use crate::common::logging::{self, logs_contains_a_line_with};
+    use crate::common::logging::{self};
     use crate::servers::api::connection_info::{connection_with_invalid_token, connection_with_no_token};
     use crate::servers::api::v1::asserts::{
         assert_auth_key_utf8, assert_failed_to_generate_key, assert_invalid_key_duration_param, assert_token_not_valid,
@@ -413,8 +401,6 @@ mod deprecated_generate_key_endpoint {
         assert_unauthorized(response).await;
 
         env.stop().await;
-
-        assert!(logs_contains_a_line_with(&["ERROR", "tower_http", "response failed"]));
     }
 
     #[tokio::test]
@@ -452,7 +438,5 @@ mod deprecated_generate_key_endpoint {
         assert_failed_to_generate_key(response).await;
 
         env.stop().await;
-
-        assert!(logs_contains_a_line_with(&["ERROR", "tower_http", "response failed"]));
     }
 }

tests/servers/api/v1/contract/context/stats.rs

@@ -6,7 +6,7 @@ use torrust_tracker_primitives::peer::fixture::PeerBuilder;
 use torrust_tracker_test_helpers::configuration;
 use tracing::level_filters::LevelFilter;
 
-use crate::common::logging::{self, logs_contains_a_line_with};
+use crate::common::logging::{self};
 use crate::servers::api::connection_info::{connection_with_invalid_token, connection_with_no_token};
 use crate::servers::api::v1::asserts::{assert_stats, assert_token_not_valid, assert_unauthorized};
 use crate::servers::api::v1::client::Client;
@@ -77,6 +77,4 @@ async fn should_not_allow_getting_tracker_statistics_for_unauthenticated_users()
     assert_unauthorized(response).await;
 
     env.stop().await;
-
-    assert!(logs_contains_a_line_with(&["ERROR", "tower_http", "response failed"]));
 }

tests/servers/api/v1/contract/context/torrent.rs

@@ -8,7 +8,7 @@ use torrust_tracker_test_helpers::configuration;
 use tracing::level_filters::LevelFilter;
 
 use crate::common::http::{Query, QueryParam};
-use crate::common::logging::{self, logs_contains_a_line_with};
+use crate::common::logging::{self};
 use crate::servers::api::connection_info::{connection_with_invalid_token, connection_with_no_token};
 use crate::servers::api::v1::asserts::{
     assert_bad_request, assert_invalid_infohash_param, assert_not_found, assert_token_not_valid, assert_torrent_info,
@@ -218,8 +218,6 @@ async fn should_not_allow_getting_torrents_for_unauthenticated_users() {
     assert_unauthorized(response).await;
 
     env.stop().await;
-
-    assert!(logs_contains_a_line_with(&["ERROR", "tower_http", "response failed"]));
 }
 
 #[tokio::test]
@@ -308,6 +306,4 @@ async fn should_not_allow_getting_a_torrent_info_for_unauthenticated_users() {
     assert_unauthorized(response).await;
 
     env.stop().await;
-
-    assert!(logs_contains_a_line_with(&["ERROR", "tower_http", "response failed"]));
 }

tests/servers/api/v1/contract/context/whitelist.rs

@@ -4,7 +4,7 @@ use bittorrent_primitives::info_hash::InfoHash;
 use torrust_tracker_test_helpers::configuration;
 use tracing::level_filters::LevelFilter;
 
-use crate::common::logging::{self, logs_contains_a_line_with};
+use crate::common::logging::{self};
 use crate::servers::api::connection_info::{connection_with_invalid_token, connection_with_no_token};
 use crate::servers::api::v1::asserts::{
     assert_failed_to_reload_whitelist, assert_failed_to_remove_torrent_from_whitelist, assert_failed_to_whitelist_torrent,
@@ -72,8 +72,6 @@ async fn should_not_allow_whitelisting_a_torrent_for_unauthenticated_users() {
     assert_unauthorized(response).await;
 
     env.stop().await;
-
-    assert!(logs_contains_a_line_with(&["ERROR", "tower_http", "response failed"]));
 }
 
 #[tokio::test]
@@ -189,8 +187,6 @@ async fn should_fail_when_the_torrent_cannot_be_removed_from_the_whitelist() {
     assert_failed_to_remove_torrent_from_whitelist(response).await;
 
     env.stop().await;
-
-    assert!(logs_contains_a_line_with(&["ERROR", "tower_http", "response failed"]));
 }
 
 #[tokio::test]
@@ -217,8 +213,6 @@ async fn should_not_allow_removing_a_torrent_from_the_whitelist_for_unauthentica
     assert_unauthorized(response).await;
 
     env.stop().await;
-
-    assert!(logs_contains_a_line_with(&["ERROR", "tower_http", "response failed"]));
 }
 
 #[tokio::test]
@@ -263,6 +257,4 @@ async fn should_fail_when_the_whitelist_cannot_be_reloaded_from_the_database() {
     assert_failed_to_reload_whitelist(response).await;
 
     env.stop().await;
-
-    assert!(logs_contains_a_line_with(&["ERROR", "tower_http", "response failed"]));
 }

tests/servers/http/v1/contract.rs

@@ -1128,7 +1128,7 @@ mod configured_as_whitelisted {
         use torrust_tracker_test_helpers::configuration;
         use tracing::level_filters::LevelFilter;
 
-        use crate::common::logging::{self, logs_contains_a_line_with};
+        use crate::common::logging::{self};
         use crate::servers::http::asserts::{assert_is_announce_response, assert_torrent_not_in_whitelist_error_response};
         use crate::servers::http::client::Client;
         use crate::servers::http::requests::announce::QueryBuilder;
@@ -1149,8 +1149,6 @@ mod configured_as_whitelisted {
             assert_torrent_not_in_whitelist_error_response(response).await;
 
             env.stop().await;
-
-            assert!(logs_contains_a_line_with(&["ERROR", "tower_http", "response failed"]));
         }
 
         #[tokio::test]
@@ -1183,7 +1181,7 @@ mod configured_as_whitelisted {
         use torrust_tracker_test_helpers::configuration;
         use tracing::level_filters::LevelFilter;
 
-        use crate::common::logging::{self, logs_contains_a_line_with};
+        use crate::common::logging::{self};
         use crate::servers::http::asserts::assert_scrape_response;
         use crate::servers::http::client::Client;
         use crate::servers::http::responses::scrape::{File, ResponseBuilder};
@@ -1218,8 +1216,6 @@ mod configured_as_whitelisted {
             assert_scrape_response(response, &expected_scrape_response).await;
 
             env.stop().await;
-
-            assert!(logs_contains_a_line_with(&["ERROR", "tower_http", "response failed"]));
         }
 
         #[tokio::test]