Skip to content

Commit b38e4af

Browse files
josecelanojosecelano
committed
chore: add DevSkim ignore DS173237
to avoid IDE warnings for infohashe values in tests.
1 parent 66b2b56 commit b38e4af

File tree

11 files changed

+43
-43
lines changed

11 files changed

+43
-43
lines changed

‎console/tracker-client/src/console/clients/checker/checks/http.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ pub async fn run(http_trackers: Vec<Url>, timeout: Duration) -> Vec<Result<Check
6161
}
6262

6363
async fn check_http_announce(url: &Url, timeout: Duration) -> Result<Announce, Error> {
64-
let info_hash_str = "9c38422213e30bff212b30c360d26f9a02136422".to_string(); // # DevSkim: ignore DS173237
64+
let info_hash_str = "9c38422213e30bff212b30c360d26f9a02136422".to_string(); // DevSkim: ignore DS173237
6565
let info_hash = InfoHash::from_str(&info_hash_str).expect("a valid info-hash is required");
6666

6767
let client = Client::new(url.clone(), timeout).map_err(|err| Error::HttpClientError { err })?;
@@ -86,7 +86,7 @@ async fn check_http_announce(url: &Url, timeout: Duration) -> Result<Announce, E
8686
}
8787

8888
async fn check_http_scrape(url: &Url, timeout: Duration) -> Result<scrape::Response, Error> {
89-
let info_hashes: Vec<String> = vec!["9c38422213e30bff212b30c360d26f9a02136422".to_string()]; // # DevSkim: ignore DS173237
89+
let info_hashes: Vec<String> = vec!["9c38422213e30bff212b30c360d26f9a02136422".to_string()]; // DevSkim: ignore DS173237
9090
let query = requests::scrape::Query::try_from(info_hashes).expect("a valid array of info-hashes is required");
9191

9292
let client = Client::new(url.clone(), timeout).map_err(|err| Error::HttpClientError { err })?;

‎console/tracker-client/src/console/clients/checker/checks/udp.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ pub async fn run(udp_trackers: Vec<Url>, timeout: Duration) -> Vec<Result<Checks
2929

3030
tracing::debug!("UDP trackers ...");
3131

32-
let info_hash = aquatic_udp_protocol::InfoHash(hex!("9c38422213e30bff212b30c360d26f9a02136422")); // # DevSkim: ignore DS173237
32+
let info_hash = aquatic_udp_protocol::InfoHash(hex!("9c38422213e30bff212b30c360d26f9a02136422")); // DevSkim: ignore DS173237
3333

3434
for remote_url in udp_trackers {
3535
let remote_addr = resolve_socket_addr(&remote_url);

‎packages/tracker-client/src/http/client/requests/announce.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ impl QueryBuilder {
9595
#[must_use]
9696
pub fn with_default_values() -> QueryBuilder {
9797
let default_announce_query = Query {
98-
info_hash: InfoHash::from_str("9c38422213e30bff212b30c360d26f9a02136422").unwrap().0, // # DevSkim: ignore DS173237
98+
info_hash: InfoHash::from_str("9c38422213e30bff212b30c360d26f9a02136422").unwrap().0, // DevSkim: ignore DS173237
9999
peer_addr: IpAddr::V4(Ipv4Addr::new(192, 168, 1, 88)),
100100
downloaded: 0,
101101
uploaded: 0,

‎packages/tracker-client/src/http/client/requests/scrape.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ pub struct QueryBuilder {
9090
impl Default for QueryBuilder {
9191
fn default() -> Self {
9292
let default_scrape_query = Query {
93-
info_hash: [InfoHash::from_str("9c38422213e30bff212b30c360d26f9a02136422").unwrap().0].to_vec(), // # DevSkim: ignore DS173237
93+
info_hash: [InfoHash::from_str("9c38422213e30bff212b30c360d26f9a02136422").unwrap().0].to_vec(), // DevSkim: ignore DS173237
9494
};
9595
Self {
9696
scrape_query: default_scrape_query,

‎src/core/mod.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ mod tests {
498498
async fn it_should_return_the_swarm_metadata_for_the_requested_file_if_the_tracker_has_that_torrent() {
499499
let (announce_handler, scrape_handler) = initialize_handlers_for_public_tracker();
500500

501-
let info_hash = "3b245504cf5f11bbdbe1201cea6a6bf45aee1bc0".parse::<InfoHash>().unwrap(); // # DevSkim: ignore DS173237
501+
let info_hash = "3b245504cf5f11bbdbe1201cea6a6bf45aee1bc0".parse::<InfoHash>().unwrap(); // DevSkim: ignore DS173237
502502

503503
// Announce a "complete" peer for the torrent
504504
let mut complete_peer = complete_peer();
@@ -553,7 +553,7 @@ mod tests {
553553
async fn it_should_return_the_zeroed_swarm_metadata_for_the_requested_file_if_it_is_not_whitelisted() {
554554
let (announce_handler, scrape_handler) = initialize_handlers_for_listed_tracker();
555555

556-
let info_hash = "3b245504cf5f11bbdbe1201cea6a6bf45aee1bc0".parse::<InfoHash>().unwrap(); // # DevSkim: ignore DS173237
556+
let info_hash = "3b245504cf5f11bbdbe1201cea6a6bf45aee1bc0".parse::<InfoHash>().unwrap(); // DevSkim: ignore DS173237
557557

558558
let mut peer = incomplete_peer();
559559
announce_handler.announce(&info_hash, &mut peer, &peer_ip(), &PeersWanted::All);

‎src/core/scrape_handler.rs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ mod tests {
7575
async fn it_should_return_a_zeroed_swarm_metadata_for_the_requested_file_if_the_tracker_does_not_have_that_torrent() {
7676
let scrape_handler = scrape_handler();
7777

78-
let info_hashes = vec!["3b245504cf5f11bbdbe1201cea6a6bf45aee1bc0".parse::<InfoHash>().unwrap()]; // # DevSkim: ignore DS173237
78+
let info_hashes = vec!["3b245504cf5f11bbdbe1201cea6a6bf45aee1bc0".parse::<InfoHash>().unwrap()]; // DevSkim: ignore DS173237
7979

8080
let scrape_data = scrape_handler.scrape(&info_hashes).await;
8181

@@ -91,8 +91,8 @@ mod tests {
9191
let scrape_handler = scrape_handler();
9292

9393
let info_hashes = vec![
94-
"3b245504cf5f11bbdbe1201cea6a6bf45aee1bc0".parse::<InfoHash>().unwrap(), // # DevSkim: ignore DS173237
95-
"99c82bb73505a3c0b453f9fa0e881d6e5a32a0c1".parse::<InfoHash>().unwrap(), // # DevSkim: ignore DS173237
94+
"3b245504cf5f11bbdbe1201cea6a6bf45aee1bc0".parse::<InfoHash>().unwrap(), // DevSkim: ignore DS173237
95+
"99c82bb73505a3c0b453f9fa0e881d6e5a32a0c1".parse::<InfoHash>().unwrap(), // DevSkim: ignore DS173237
9696
];
9797

9898
let scrape_data = scrape_handler.scrape(&info_hashes).await;

‎src/core/services/torrent.rs‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ mod tests {
145145

146146
let torrent_info = get_torrent_info(
147147
in_memory_torrent_repository.clone(),
148-
&InfoHash::from_str("0b3aea4adc213ce32295be85d3883a63bca25446").unwrap(),
148+
&InfoHash::from_str("0b3aea4adc213ce32295be85d3883a63bca25446").unwrap(), // DevSkim: ignore DS173237
149149
)
150150
.await;
151151

@@ -156,7 +156,7 @@ mod tests {
156156
async fn should_return_the_torrent_info_if_the_tracker_has_the_torrent() {
157157
let in_memory_torrent_repository = Arc::new(InMemoryTorrentRepository::default());
158158

159-
let hash = "9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d".to_owned();
159+
let hash = "9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d".to_owned(); // DevSkim: ignore DS173237
160160
let info_hash = InfoHash::from_str(&hash).unwrap();
161161
let () = in_memory_torrent_repository.upsert_peer(&info_hash, &sample_peer());
162162

@@ -201,7 +201,7 @@ mod tests {
201201
async fn should_return_a_summarized_info_for_all_torrents() {
202202
let in_memory_torrent_repository = Arc::new(InMemoryTorrentRepository::default());
203203

204-
let hash = "9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d".to_owned();
204+
let hash = "9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d".to_owned(); // DevSkim: ignore DS173237
205205
let info_hash = InfoHash::from_str(&hash).unwrap();
206206

207207
let () = in_memory_torrent_repository.upsert_peer(&info_hash, &sample_peer());
@@ -223,7 +223,7 @@ mod tests {
223223
async fn should_allow_limiting_the_number_of_torrents_in_the_result() {
224224
let in_memory_torrent_repository = Arc::new(InMemoryTorrentRepository::default());
225225

226-
let hash1 = "9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d".to_owned();
226+
let hash1 = "9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d".to_owned(); // DevSkim: ignore DS173237
227227
let info_hash1 = InfoHash::from_str(&hash1).unwrap();
228228

229229
let hash2 = "03840548643af2a7b63a9f5cbca348bc7150ca3a".to_owned();
@@ -244,7 +244,7 @@ mod tests {
244244
async fn should_allow_using_pagination_in_the_result() {
245245
let in_memory_torrent_repository = Arc::new(InMemoryTorrentRepository::default());
246246

247-
let hash1 = "9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d".to_owned();
247+
let hash1 = "9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d".to_owned(); // DevSkim: ignore DS173237
248248
let info_hash1 = InfoHash::from_str(&hash1).unwrap();
249249

250250
let hash2 = "03840548643af2a7b63a9f5cbca348bc7150ca3a".to_owned();
@@ -274,7 +274,7 @@ mod tests {
274274
async fn should_return_torrents_ordered_by_info_hash() {
275275
let in_memory_torrent_repository = Arc::new(InMemoryTorrentRepository::default());
276276

277-
let hash1 = "9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d".to_owned();
277+
let hash1 = "9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d".to_owned(); // DevSkim: ignore DS173237
278278
let info_hash1 = InfoHash::from_str(&hash1).unwrap();
279279
let () = in_memory_torrent_repository.upsert_peer(&info_hash1, &sample_peer());
280280

‎src/servers/apis/v1/context/torrent/resources/torrent.rs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,14 +122,14 @@ mod tests {
122122
fn torrent_resource_should_be_converted_from_torrent_info() {
123123
assert_eq!(
124124
Torrent::from(Info {
125-
info_hash: InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap(),
125+
info_hash: InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap(), // DevSkim: ignore DS173237
126126
seeders: 1,
127127
completed: 2,
128128
leechers: 3,
129129
peers: Some(vec![sample_peer()]),
130130
}),
131131
Torrent {
132-
info_hash: "9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d".to_string(),
132+
info_hash: "9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d".to_string(), // DevSkim: ignore DS173237
133133
seeders: 1,
134134
completed: 2,
135135
leechers: 3,
@@ -142,13 +142,13 @@ mod tests {
142142
fn torrent_resource_list_item_should_be_converted_from_the_basic_torrent_info() {
143143
assert_eq!(
144144
ListItem::from(BasicInfo {
145-
info_hash: InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap(),
145+
info_hash: InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap(), // DevSkim: ignore DS173237
146146
seeders: 1,
147147
completed: 2,
148148
leechers: 3,
149149
}),
150150
ListItem {
151-
info_hash: "9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d".to_string(),
151+
info_hash: "9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d".to_string(), // DevSkim: ignore DS173237
152152
seeders: 1,
153153
completed: 2,
154154
leechers: 3,

‎tests/servers/api/v1/contract/context/stats.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ async fn should_allow_getting_tracker_statistics() {
1919
let env = Started::new(&configuration::ephemeral().into()).await;
2020

2121
env.add_torrent_peer(
22-
&InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap(),
22+
&InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap(), // DevSkim: ignore DS173237
2323
&PeerBuilder::default().into(),
2424
);
2525

‎tests/servers/api/v1/contract/context/torrent.rs‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ async fn should_allow_getting_all_torrents() {
2626

2727
let env = Started::new(&configuration::ephemeral().into()).await;
2828

29-
let info_hash = InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap();
29+
let info_hash = InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap(); // DevSkim: ignore DS173237
3030

3131
env.add_torrent_peer(&info_hash, &PeerBuilder::default().into());
3232

@@ -39,7 +39,7 @@ async fn should_allow_getting_all_torrents() {
3939
assert_torrent_list(
4040
response,
4141
vec![torrent::ListItem {
42-
info_hash: "9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d".to_string(),
42+
info_hash: "9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d".to_string(), // DevSkim: ignore DS173237
4343
seeders: 1,
4444
completed: 0,
4545
leechers: 0,
@@ -57,8 +57,8 @@ async fn should_allow_limiting_the_torrents_in_the_result() {
5757
let env = Started::new(&configuration::ephemeral().into()).await;
5858

5959
// torrents are ordered alphabetically by infohashes
60-
let info_hash_1 = InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap();
61-
let info_hash_2 = InfoHash::from_str("0b3aea4adc213ce32295be85d3883a63bca25446").unwrap();
60+
let info_hash_1 = InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap(); // DevSkim: ignore DS173237
61+
let info_hash_2 = InfoHash::from_str("0b3aea4adc213ce32295be85d3883a63bca25446").unwrap(); // DevSkim: ignore DS173237
6262

6363
env.add_torrent_peer(&info_hash_1, &PeerBuilder::default().into());
6464
env.add_torrent_peer(&info_hash_2, &PeerBuilder::default().into());
@@ -75,7 +75,7 @@ async fn should_allow_limiting_the_torrents_in_the_result() {
7575
assert_torrent_list(
7676
response,
7777
vec![torrent::ListItem {
78-
info_hash: "0b3aea4adc213ce32295be85d3883a63bca25446".to_string(),
78+
info_hash: "0b3aea4adc213ce32295be85d3883a63bca25446".to_string(), // DevSkim: ignore DS173237
7979
seeders: 1,
8080
completed: 0,
8181
leechers: 0,
@@ -93,8 +93,8 @@ async fn should_allow_the_torrents_result_pagination() {
9393
let env = Started::new(&configuration::ephemeral().into()).await;
9494

9595
// torrents are ordered alphabetically by infohashes
96-
let info_hash_1 = InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap();
97-
let info_hash_2 = InfoHash::from_str("0b3aea4adc213ce32295be85d3883a63bca25446").unwrap();
96+
let info_hash_1 = InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap(); // DevSkim: ignore DS173237
97+
let info_hash_2 = InfoHash::from_str("0b3aea4adc213ce32295be85d3883a63bca25446").unwrap(); // DevSkim: ignore DS173237
9898

9999
env.add_torrent_peer(&info_hash_1, &PeerBuilder::default().into());
100100
env.add_torrent_peer(&info_hash_2, &PeerBuilder::default().into());
@@ -111,7 +111,7 @@ async fn should_allow_the_torrents_result_pagination() {
111111
assert_torrent_list(
112112
response,
113113
vec![torrent::ListItem {
114-
info_hash: "9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d".to_string(),
114+
info_hash: "9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d".to_string(), // DevSkim: ignore DS173237
115115
seeders: 1,
116116
completed: 0,
117117
leechers: 0,
@@ -296,7 +296,7 @@ async fn should_allow_getting_a_torrent_info() {
296296

297297
let env = Started::new(&configuration::ephemeral().into()).await;
298298

299-
let info_hash = InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap();
299+
let info_hash = InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap(); // DevSkim: ignore DS173237
300300

301301
let peer = PeerBuilder::default().into();
302302

@@ -311,7 +311,7 @@ async fn should_allow_getting_a_torrent_info() {
311311
assert_torrent_info(
312312
response,
313313
Torrent {
314-
info_hash: "9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d".to_string(),
314+
info_hash: "9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d".to_string(), // DevSkim: ignore DS173237
315315
seeders: 1,
316316
completed: 0,
317317
leechers: 0,
@@ -330,7 +330,7 @@ async fn should_fail_while_getting_a_torrent_info_when_the_torrent_does_not_exis
330330
let env = Started::new(&configuration::ephemeral().into()).await;
331331

332332
let request_id = Uuid::new_v4();
333-
let info_hash = InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap();
333+
let info_hash = InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap(); // DevSkim: ignore DS173237
334334

335335
let response = Client::new(env.get_connection_info())
336336
.get_torrent(&info_hash.to_string(), Some(headers_with_request_id(request_id)))
@@ -376,7 +376,7 @@ async fn should_not_allow_getting_a_torrent_info_for_unauthenticated_users() {
376376

377377
let env = Started::new(&configuration::ephemeral().into()).await;
378378

379-
let info_hash = InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap();
379+
let info_hash = InfoHash::from_str("9e0217d0fa71c87332cd8bf9dbeabcb2c2cf3c4d").unwrap(); // DevSkim: ignore DS173237
380380

381381
env.add_torrent_peer(&info_hash, &PeerBuilder::default().into());
382382

0 commit comments

Comments
 (0)