Commit ea2d73d
committed
Merge #1255: Overhaul core Tracker: add tests for
2cd1c65 test: [#1251] add tests for database driver error converters (Jose Celano)
adb9614 tests: [#1251] add test for loading keys in DB drivers (Jose Celano)
700482d test: [#1251] reset database before running db driver tests (Jose Celano)
b9188c7 test: [#1251] add tests for whitelist is DB drivers (Jose Celano)
613efb2 fix: [#1257] bug 3. Expiring auth keys ignore fractions of seconds (Jose Celano)
b94179d fix: [#1257] bug 2. Auth keys can't be removed in MySQL (Jose Celano)
595397b fix: [#1257] bug 1. permanent keys can't be created in MySQL (Jose Celano)
7ddacdc test: [#1251] unify test runner for sqlite and mysql drivers (Jose Celano)
46949a6 test: [#1251] add tests for core database driver mysql (Jose Celano)
568d6d3 test: [#1251] add tests for core database driver sqlite (Jose Celano)
Pull request description:
Overhaul core Tracker: add tests for `databases` mod.
Regarding the database drivers these are the methods in the Database trait grouped by context:
Schema:
- create_database_tables
- drop_database_tables (this is only used for testing)
Persistent torrents (stats):
- [x] load_persistent_torrents
- [x] save_persistent_torrent
Authentication keys (for private trackers):
- [x] load_keys
- [x] get_key_from_keys
- [x] add_key_to_keys
- [x] remove_key_from_keys
Whitelist (for listed trackers):
- [x] load_whitelist
- [x] get_info_hash_from_whitelist
- [x] add_info_hash_to_whitelist
- [x] remove_info_hash_from_whitelist
### Sub-tasks
- [x] `driver`
- [x] `mod.rs` (no direct tests added)
- [x] `mysql.rs`
- [x] `sqlite.rs`
- [x] `error.rs`
- [x] `mod.rs` (no direct tests added)
- [x] `setup.rs` (no direct tests added)
ACKs for top commit:
josecelano:
ACK 2cd1c65
Tree-SHA512: 07e92b5458053ae27b424bbd0d9bd35cf44b0a8a1ac2c16eb4c64016295b6770a5b426a132002d091c0fab7e754d198f2906498f733119f386831bdcac50aa1edatabases modFile tree
12 files changed
+864
-41
lines changed- .github/workflows
- packages/tracker-core
- src
- authentication/key
- databases
- driver
12 files changed
+864
-41
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
146 | 146 | | |
147 | 147 | | |
148 | 148 | | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
149 | 153 | | |
150 | 154 | | |
151 | 155 | | |
| |||
0 commit comments