Merge #1531: Overhaul stats: Simplify how the AnnounceHandler persist number of downloads in tracker-core package

67d177b refactor: [#1524] command/query separation (Jose Celano)
8c31549 refactor: [#1524] rename methods (Jose Celano)
28603fe refactor: [#1524] extract TestEnv for integration tests in tracker-core (Jose Celano)
ab2f52d fix: [#1524] test (move to integration test) (Jose Celano)
b05bccd refactor: [#1524] integration tests in tracker-core (Jose Celano)
f3d3495 refactor: [#1524] remove duplciate code for tracker core container (Jose Celano)
e90585a refactor: [#1524] move total downloads udpate from announce command to event handler (Jose Celano)
8968757 refactor: extract method JobManger::push_opt (Jose Celano)
7e933f9 feat: [#1524] listens to torrent-repository events in the tracker-core pkg (Jose Celano)
3a23a38 fix: tracing message (Jose Celano)

Pull request description:

  Simplify how the `AnnounceHandler` persist number of downloads in `tracker-core` package.

  It's now done asynchronously instead of synchronously.

  **NOTICE:** That `bittorrent_tracker_core::announce_handler::AnnounceHandler::announce` will not return a database error anymore, meaning the peer will receive the announce response even if the tracker can't update the downloads counter.

  ### Subtasks

  Main change:

  - [x] Scaffolding for listening to torrent-repository events in the `tracker-core` package.
  - [x] Move the SQL update from the `AnnounceHandler` to the event handler (`handle_event`).

  Cleanup:

  - [x] Fix test. https://github.com/torrust/torrust-tracker/actions/runs/15168471742/job/42652507081?pr=1531#step:7:250
    - It's not the service's responsibility to increment the counter anymore. Add:
      - A unit test in the event handler to check that the counter is increased when the event is received.
      - An integration test to simulate a peer completing downloading.
      - Maybe we should also add a main app E2E test (to make sure the listener is initialised), but we are not testing it for other jobs directly. We have to review the strategy for E2E tests in the main app.
  - [x] Refactor: rename `upsert_peer` to `handle_announcement`.
  - [x] Refactor: rename `AnnounceHandler::announce` to `AnnounceHandler::handle_announcement`
  - [x] Refactor: Don't return the boolean `number of downloads increased` in `upsert_peer`. `upsert_peer` should only be a command decoupled from other secondary tasks. Side effects should be captured from events.

  NOTE: I cannot remove the `db_torrent_repository` dependency from the `AnnounceHandler` yet until we implement the new persistent metric for the number of downloads, because it's still used in:

  ```rust
  let opt_persistent_torrent = if self.config.tracker_policy.persistent_torrent_completed_stat {
      self.db_torrent_repository.load(info_hash)?
  } else {
      None
  };
  ```

ACKs for top commit:
  josecelano:
    ACK 67d177b

Tree-SHA512: 5d33fc5e383d280dda68879c165f736729c0659a1f69136ef2fbc48ed35e7a87e4cbf4ba30e5654f2192a3dbeabe4d474f8f5c54ae310320a2888b234ecf9614

Author: josecelano

Cargo.lock

@@ -25,12 +25,12 @@ pub struct Environment<S> {
 
 impl<S> Environment<S> {
     /// Add a torrent to the tracker
-    pub async fn add_torrent_peer(&self, info_hash: &InfoHash, peer: &peer::Peer) -> bool {
+    pub async fn add_torrent_peer(&self, info_hash: &InfoHash, peer: &peer::Peer) {
         self.container
             .tracker_core_container
             .in_memory_torrent_repository
-            .upsert_peer(info_hash, peer, None)
-            .await
+            .handle_announcement(info_hash, peer, None)
+            .await;
     }
 }
 

packages/axum-http-tracker-server/src/environment.rs

@@ -33,12 +33,12 @@ where
     S: std::fmt::Debug + std::fmt::Display,
 {
     /// Add a torrent to the tracker
-    pub async fn add_torrent_peer(&self, info_hash: &InfoHash, peer: &peer::Peer) -> bool {
+    pub async fn add_torrent_peer(&self, info_hash: &InfoHash, peer: &peer::Peer) {
         self.container
             .tracker_core_container
             .in_memory_torrent_repository
-            .upsert_peer(info_hash, peer, None)
-            .await
+            .handle_announcement(info_hash, peer, None)
+            .await;
     }
 }
 

packages/axum-rest-tracker-api-server/src/environment.rs

@@ -87,7 +87,7 @@ impl AnnounceService {
 
         let announce_data = self
             .announce_handler
-            .announce(
+            .handle_announcement(
                 &announce_request.info_hash,
                 &mut peer,
                 &remote_client_addr.ip(),

packages/http-tracker-core/src/services/announce.rs

@@ -78,7 +78,7 @@ impl ScrapeService {
         let scrape_data = if self.authentication_is_required() && !self.is_authenticated(maybe_key).await {
             ScrapeData::zeroed(&scrape_request.info_hashes)
         } else {
-            self.scrape_handler.scrape(&scrape_request.info_hashes).await?
+            self.scrape_handler.handle_scrape(&scrape_request.info_hashes).await?
         };
 
         let remote_client_addr = resolve_remote_client_addr(&self.core_config.net.on_reverse_proxy.into(), client_ip_sources)?;
@@ -291,7 +291,7 @@ mod tests {
             let original_peer_ip = peer.ip();
             container
                 .announce_handler
-                .announce(&info_hash, &mut peer, &original_peer_ip, &PeersWanted::AsManyAsPossible)
+                .handle_announcement(&info_hash, &mut peer, &original_peer_ip, &PeersWanted::AsManyAsPossible)
                 .await
                 .unwrap();
 
@@ -482,7 +482,7 @@ mod tests {
             let original_peer_ip = peer.ip();
             container
                 .announce_handler
-                .announce(&info_hash, &mut peer, &original_peer_ip, &PeersWanted::AsManyAsPossible)
+                .handle_announcement(&info_hash, &mut peer, &original_peer_ip, &PeersWanted::AsManyAsPossible)
                 .await
                 .unwrap();