UDP tracker performance has decreased ~30%

[josecelano]

I like to check performance from time to time (we should do it before merging all PRs).

I think the last time I run it was for this PR: #1091 (review)

Best case was:

Requests out: 492705.64/second
Responses in: 415447.68/second
  - Connect responses:  205609.94
  - Announce responses: 205718.08
  - Scrape responses:   4119.67
  - Error responses:    0.00
Peers per announce response: 0.00
Announce responses per info hash:
  - p10: 1
  - p25: 1
  - p50: 1
  - p75: 1
  - p90: 2
  - p95: 3
  - p99: 105
  - p99.9: 331
  - p100: 429

I have just run it (same machine):

Requests out: 349650.52/second
Responses in: 341184.34/second
  - Connect responses:  168932.36
  - Announce responses: 168850.59
  - Scrape responses:   3401.39
  - Error responses:    0.00
Peers per announce response: 0.00
Announce responses per info hash:
  - p10: 1
  - p25: 1
  - p50: 1
  - p75: 1
  - p90: 2
  - p95: 3
  - p99: 105
  - p99.9: 277
  - p100: 345

That's a −29,034601674% decrease.

cc @da2ce7

[josecelano]

Hi @da2ce7 I have executed the performance test with different commits (from more recent commits to oldest commits, after big changes):

• Requests out: 334304.04/second: bf883da Beofre torrents repository refactor
• Requests out: 352560.71/second: d918e47 Before announce and scrpae refactors
• Requests out: 336818.76/second: 809b85b Before extracting announce and scrape services
• Requests out: 338695.38/second: 4447c6a
• Requests out: 344287.78/second: b403382 Before core tracker overhaul
• Requests out: 328592.07/second: b403382 Merge Refactor: Move logic to http-protocol and primitives packages #1180: Refactor: Move logic to http-protocol and primitives packages
• Requests out: 319594.69/second: c9638f3 Merge Udpate dependencies #1175: Udpate dependencies

The last one:

• Requests out: 319594.69/second: c9638f3 Merge Udpate dependencies #1175: Udpate dependencies

is the closest commit (I can compile with the current Rust version) to the commit that gave me the results above in the issue description:

Requests out: 492705.64/second

It does not give me the same result.

The machine is the same but other things have changed:

• Rust version
• My OS version: from ubuntu 22 to 24
• Dependencies

My plan is:

• Add benchmark to the extracted packages at different levels.
• Do profiling again for each separate package.
• Add a workflow to run a basic benchmark for the UDP tracker #909

I'm closing this issue and I will open a new EPIC to review the performance. I think it makes sense to do it after finishing the stats overhaul.