Enable tests for asyncmy (#1833)

* Enable tests for asyncmy

* Set read_timeout just for asyncmy

* reuse test_mysql

Author: henadzit

Makefile

@@ -25,6 +25,9 @@ up:
 deps:
 	@poetry install -E asyncpg -E aiomysql -E accel -E psycopg -E asyncodbc
 
+deps_with_asyncmy:
+	@poetry install -E asyncpg -E asyncmy -E accel -E psycopg -E asyncodbc
+
 check: deps build _check
 _check:
 ifneq ($(shell which black),)
@@ -67,13 +70,20 @@ test_mysql_myisam:
 test_mysql:
 	$(py_warn) TORTOISE_TEST_DB="mysql://root:$(TORTOISE_MYSQL_PASS)@127.0.0.1:3306/test_\{\}" pytest $(pytest_opts) --cov-append --cov-report=
 
+test_mysql_asyncmy:
+	$(MAKE) deps_with_asyncmy
+	$(MAKE) test_mysql
+	# Restore dependencies to the default
+	$(MAKE) deps
+
 test_mssql:
 	$(py_warn) TORTOISE_TEST_DB="mssql://sa:$(TORTOISE_MSSQL_PASS)@127.0.0.1:1433/test_\{\}?driver=$(TORTOISE_MSSQL_DRIVER)&TrustServerCertificate=YES" pytest $(pytest_opts) --cov-append --cov-report=
 
 test_oracle:
 	$(py_warn) TORTOISE_TEST_DB="oracle://SYSTEM:$(TORTOISE_ORACLE_PASS)@127.0.0.1:1521/test_\{\}?driver=$(TORTOISE_ORACLE_DRIVER)" pytest $(pytest_opts) --cov-append --cov-report=
 
-_testall: test_sqlite test_postgres_asyncpg test_postgres_psycopg test_mysql_myisam test_mysql test_mssql
+_testall: test_sqlite test_postgres_asyncpg test_postgres_psycopg test_mysql_myisam test_mysql test_mysql_asyncmy test_mssql
+
 	coverage report
 
 testall: deps _testall

README.rst

@@ -152,7 +152,7 @@ Tortoise ORM currently supports the following databases:
 
 * `SQLite` (requires ``aiosqlite``)
 * `PostgreSQL` (requires ``asyncpg``)
-* `MySQL` (requires ``asyncmy``)
+* `MySQL` (requires ``asyncmy`` or ``aiomysql``)
 * `Microsoft SQL Server`/`Oracle` (requires ``asyncodbc``)
 
 ``generate_schema`` generates the schema on an empty database. Tortoise generates schemas in safe mode by default which

tests/backends/test_mysql.py

@@ -29,11 +29,15 @@ async def test_bad_charset(self):
     async def test_ssl_true(self):
         self.db_config["connections"]["models"]["credentials"]["ssl"] = True
         try:
-            await Tortoise.init(self.db_config, _create_db=True)
-        except (ConnectionError, ssl.SSLError):
+            import asyncmy  # noqa pylint: disable=unused-import
+
+            # setting read_timeout for asyncmy. Otherwise, it will hang forever.
+            self.db_config["connections"]["models"]["credentials"]["read_timeout"] = 1
+        except ImportError:
             pass
-        else:
-            self.assertFalse(True, "Expected ConnectionError or SSLError")
+
+        with self.assertRaises(ConnectionError):
+            await Tortoise.init(self.db_config, _create_db=True)
 
     async def test_ssl_custom(self):
         # Expect connectionerror or pass