Skip to content

Commit 7340e6e

Browse files
authored
refactor: reduce duplicated code in tests (#1846)
* refactor: reduce duplicated code in tests * fix codacy issues
1 parent e34c2c0 commit 7340e6e

File tree

1 file changed

+11
-16
lines changed

1 file changed

+11
-16
lines changed

tests/test_two_databases.py

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -26,35 +26,30 @@ async def asyncTearDown(self) -> None:
2626
await Tortoise._drop_databases()
2727
await super().asyncTearDown()
2828

29+
def build_select_sql(self) -> str:
30+
if isinstance(self.db, OracleClient):
31+
return 'SELECT * FROM "eventtwo"'
32+
return "SELECT * FROM eventtwo"
33+
2934
async def test_two_databases(self):
3035
tournament = await Tournament.create(name="Tournament")
3136
await EventTwo.create(name="Event", tournament_id=tournament.id)
3237

38+
select_sql = self.build_select_sql()
3339
with self.assertRaises(OperationalError):
34-
if isinstance(self.db, OracleClient):
35-
await self.db.execute_query('SELECT * FROM "eventtwo"')
36-
else:
37-
await self.db.execute_query("SELECT * FROM eventtwo")
38-
if isinstance(self.db, OracleClient):
39-
_, results = await self.second_db.execute_query('SELECT * FROM "eventtwo"')
40-
else:
41-
_, results = await self.second_db.execute_query("SELECT * FROM eventtwo")
40+
await self.db.execute_query(select_sql)
41+
_, results = await self.second_db.execute_query(select_sql)
4242
self.assertEqual(dict(results[0]), {"id": 1, "name": "Event", "tournament_id": 1})
4343

4444
async def test_two_databases_relation(self):
4545
tournament = await Tournament.create(name="Tournament")
4646
event = await EventTwo.create(name="Event", tournament_id=tournament.id)
4747

48+
select_sql = self.build_select_sql()
4849
with self.assertRaises(OperationalError):
49-
if isinstance(self.db, OracleClient):
50-
await self.db.execute_query('SELECT * FROM "eventtwo"')
51-
else:
52-
await self.db.execute_query("SELECT * FROM eventtwo")
50+
await self.db.execute_query(select_sql)
5351

54-
if isinstance(self.db, OracleClient):
55-
_, results = await self.second_db.execute_query('SELECT * FROM "eventtwo"')
56-
else:
57-
_, results = await self.second_db.execute_query("SELECT * FROM eventtwo")
52+
_, results = await self.second_db.execute_query(select_sql)
5853
self.assertEqual(dict(results[0]), {"id": 1, "name": "Event", "tournament_id": 1})
5954

6055
teams = []

0 commit comments

Comments
 (0)