fix values_list fields order (#1492)

Abdeldjalil-H · long2ice · web-flow · commit 76cfc14232fc · 2023-10-13T09:32:04.000+08:00
* fix values_list fields order

ValuesListQuery return wrong order list when the number of fields is greater than 10.

* update changelog

---------

Co-authored-by: long2ice &lt;long2ice@gmail.com&gt;
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -18,6 +18,7 @@ Added
 
 Fixed
 ^^^^^
+- Fix order of fields in `ValuesListQuery` when it has more than 10 fields. (#1492)
 - Fix pydantic v2 pydantic_model_creator nullable field not optional. (#1454)
 
 0.20.0
diff --git a/tortoise/queryset.py b/tortoise/queryset.py
@@ -1507,7 +1507,7 @@ async def _execute(self) -> Union[List[Any], Tuple]:
         _, result = await self._db.execute_query(str(self.query))
         columns = [
             (key, self.resolve_to_python_value(self.model, name))
-            for key, name in sorted(self.fields.items())
+            for key, name in self.fields.items()
         ]
         if self.flat:
             func = columns[0][1]

Original file line number	Diff line number	Diff line change
`@@ -1507,7 +1507,7 @@ async def _execute(self) -> Union[List[Any], Tuple]:`
`1507`	`1507`	`_, result = await self._db.execute_query(str(self.query))`
`1508`	`1508`	`columns = [`
`1509`	`1509`	`(key, self.resolve_to_python_value(self.model, name))`
`1510`		`- for key, name in sorted(self.fields.items())`
	`1510`	`+ for key, name in self.fields.items()`
`1511`	`1511`	`]`
`1512`	`1512`	`if self.flat:`
`1513`	`1513`	`func = columns[0][1]`