standardize document name selection

Author: madoleary

app/models/document.rb

@@ -16,6 +16,43 @@ class Document < ApplicationRecord
 
   validate :custom_uniqueness_check
 
+  VALID_NAMES = [
+    "Terms of Service",
+    "Privacy Policy",
+    "Imprint",
+    "Trackers Policy",
+    "Developer Terms",
+    "Community Guidelines",
+    "Deceased Users",
+    "Acceptable Use Policy",
+    "Restricted Use Policy",
+    "Commercial Terms",
+    "Copyright Claims Policy",
+    "Law Enforcement Guidelines",
+    "Human Rights Policy",
+    "In-App Purchases Policy",
+    "Review Guidelines",
+    "Brand Guidelines",
+    "Quality Guidelines",
+    "Data Controller Agreement",
+    "Data Processor Agreement",
+    "User Consent Policy",
+    "Closed Captioning Policy",
+    "Seller Warranty",
+    "Single Sign-On Policy",
+    "Vulnerability Disclosure Policy",
+    "Live Policy",
+    "Complaints Policy",
+    "General Conditions of Sale",
+    "Marketplace Buyers Conditions",
+    "Marketplace Sellers Conditions",
+    "Ranking Parameters Description",
+    "Premium Partner Conditions",
+    "Platform to Business Notice",
+    "Business Mediation Policy",
+    "Business Privacy Policy"
+  ]
+
   def self.search_by_document_name(query)
     Document.joins(:service).where('services.name ILIKE ? or documents.name ILIKE ? or documents.url ILIKE?', "%#{query}%", "%#{query}%", "%#{query}%")
   end

app/views/documents/_form.html.erb

@@ -1,6 +1,6 @@
 <%= simple_form_for [@document] do |f| %>
   <%= f.association :service, collection: Service.order('name ASC'), hint: "If your service isn't on the list, please contact the team" %>
-  <%= f.input :name, hint: "Name of this document", placeholder: "e.g. \"Privacy Policy\"" %>
+  <%= f.input :name, collection: Document::VALID_NAMES, hint: 'Name of the document', selected: 'Privacy Policy'%>
   <%= f.input :url, hint: "Where we should fetch this document", placeholder: "e.g. \"https://www.facebook.com/about/privacy\"" %>
   <%= f.input :xpath, input_html: { value: (f.object.xpath.present?) ? f.object.xpath : '//body' }, placeholder: "e.g. \"//*[@id='content']//div[@class='_5tkp _3m9']\"", hint: "The location of the terms on the page (Using <a href=\"https://en.wikipedia.org/wiki/XPath\" title=\"Wikipedia explanation of XPath\" target=\"_blank\">XPath</a>.)".html_safe %>
   <%= f.input :crawler_server, collection: (Rails.env.development?) ? DocumentsController::DEV_CRAWLERS : DocumentsController::PROD_CRAWLERS, label_method: :second, value_method: :first, hint: "<a href=\"https://to.tosdr.org/U98u1\">Select from which country the crawler should be used, or a specific crawler. Useful if blocked by EU. (Optional)</a>".html_safe, selected: @document.crawler_server || "eu.crawler.api.tosdr.org" %>