Improved tests for 30

Author: mattpocock

src/06-challenges/30-form-validator.problem.ts

@@ -1,4 +1,5 @@
 import { expect, it } from "vitest";
+import { Equal, Expect } from "../helpers/type-utils";
 
 const makeFormValidatorFactory = (validators: unknown) => (config: unknown) => {
   return (values: unknown) => {
@@ -53,6 +54,17 @@ it("Should properly validate a user", () => {
     username: "Minimum length is 5",
     email: "Invalid email",
   });
+
+  type test = Expect<
+    Equal<
+      typeof errors,
+      {
+        id: string | undefined;
+        username: string | undefined;
+        email: string | undefined;
+      }
+    >
+  >;
 });
 
 it("Should not allow you to specify a validator that does not exist", () => {
@@ -61,3 +73,14 @@ it("Should not allow you to specify a validator that does not exist", () => {
     id: ["i-do-not-exist"],
   });
 });
+
+it("Should not allow you to validate an object property that does not exist", () => {
+  const validator = createFormValidator({
+    id: ["required"],
+  });
+
+  validator({
+    // @ts-expect-error
+    name: "123",
+  });
+});

src/06-challenges/30-form-validator.solution.ts

@@ -1,4 +1,5 @@
 import { expect, it } from "vitest";
+import { Equal, Expect } from "../helpers/type-utils";
 
 type ValidatorsBase = Record<string, (value: string) => string | void>;
 
@@ -8,7 +9,7 @@ const makeFormValidatorFactory =
   <TValidators extends ValidatorsBase>(validators: TValidators) =>
   <TInput extends ValidatorConfig<keyof TValidators>>(config: TInput) => {
     return (
-      values: Record<keyof TInput, string>,
+      values: Record<keyof TInput, string>
     ): Record<keyof TInput, string | undefined> => {
       const errors = {} as any;
 
@@ -61,6 +62,17 @@ it("Should properly validate a user", () => {
     username: "Minimum length is 5",
     email: "Invalid email",
   });
+
+  type test = Expect<
+    Equal<
+      typeof errors,
+      {
+        id: string | undefined;
+        username: string | undefined;
+        email: string | undefined;
+      }
+    >
+  >;
 });
 
 it("Should not allow you to specify a validator that does not exist", () => {
@@ -69,3 +81,14 @@ it("Should not allow you to specify a validator that does not exist", () => {
     id: ["i-do-not-exist"],
   });
 });
+
+it("Should not allow you to validate an object property that does not exist", () => {
+  const validator = createFormValidator({
+    id: ["required"],
+  });
+
+  validator({
+    // @ts-expect-error
+    name: "123",
+  });
+});