feat: add validation for duplicate active tickets and shift assignments in ShiftManagement and ShiftTicketCenter components

xukki241 · xukki241 · commit 38c7973a99e8 · 2026-03-18T02:03:38.000+07:00
diff --git a/backend/src/main/java/com/smalltrend/repository/TicketRepository.java b/backend/src/main/java/com/smalltrend/repository/TicketRepository.java
@@ -21,5 +21,10 @@ public interface TicketRepository extends JpaRepository<Ticket, Long> {
 
     List<Ticket> findByTicketCode(String ticketCode);
 
+    List<Ticket> findByTicketTypeAndCreatedByIdAndStatusIn(
+            TicketType ticketType,
+            Integer createdByUserId,
+            List<TicketStatus> statuses);
+
     long countByTicketType(TicketType ticketType);
 }
diff --git a/backend/src/main/java/com/smalltrend/service/CRM/TicketService.java b/backend/src/main/java/com/smalltrend/service/CRM/TicketService.java
@@ -26,11 +26,14 @@
 import lombok.RequiredArgsConstructor;
 
 import java.time.LocalDate;
+import java.util.Set;
 
 @Service
 @RequiredArgsConstructor
 public class TicketService {
 
+    private static final Set<TicketStatus> ACTIVE_TICKET_STATUSES = Set.of(TicketStatus.OPEN, TicketStatus.IN_PROGRESS);
+
     private final TicketRepository ticketRepository;
     private final UserRepository userRepository;
     private final InventoryStockRepository inventoryStockRepository;
@@ -103,6 +106,10 @@ public TicketResponse createTicket(CreateTicketRequest request) {
             }
         }
 
+        if (ticketType == TicketType.SHIFT_CHANGE) {
+            validateNoDuplicateActiveShiftTicket(request, requesterAssignment);
+        }
+
         Ticket ticket = Ticket.builder()
                 .ticketCode(generateTicketCode(ticketType))
                 .ticketType(ticketType)
@@ -143,6 +150,85 @@ public TicketResponse createTicket(CreateTicketRequest request) {
         return mapToResponse(saved);
     }
 
+    private void validateNoDuplicateActiveShiftTicket(CreateTicketRequest request, WorkShiftAssignment requesterAssignment) {
+        Integer requesterId = request.getRequesterUserId() != null ? request.getRequesterUserId() : request.getCreatedById();
+        if (requesterId == null) {
+            return;
+        }
+
+        List<Ticket> activeTickets = ticketRepository.findByTicketTypeAndCreatedByIdAndStatusIn(
+                TicketType.SHIFT_CHANGE,
+                requesterId,
+                List.copyOf(ACTIVE_TICKET_STATUSES));
+
+        String incomingAction = resolveTicketAction(request.getTitle(), request.getRelatedEntityType());
+        Long incomingRelatedEntityId = resolveRelatedEntityId(request, requesterAssignment);
+        Integer incomingRequesterAssignmentId = request.getSwapRequesterAssignmentId() != null
+                ? request.getSwapRequesterAssignmentId()
+                : requesterAssignment != null ? requesterAssignment.getId() : null;
+        Integer incomingTargetUserId = request.getSwapTargetUserId() != null
+                ? request.getSwapTargetUserId()
+                : request.getAssignedToUserId();
+
+        for (Ticket active : activeTickets) {
+            String existingAction = resolveTicketAction(active.getTitle(), active.getRelatedEntityType());
+            if (!incomingAction.equals(existingAction)) {
+                continue;
+            }
+
+            if ("SHIFT_SWAP".equals(incomingAction)) {
+                Integer existingRequesterAssignmentId = parseMetaInt(active.getDescription(), "SWAP_REQUESTER_ASSIGNMENT_ID");
+                Integer existingTargetUserId = parseMetaInt(active.getDescription(), "SWAP_TARGET_USER_ID");
+
+                if (incomingRequesterAssignmentId != null
+                        && incomingRequesterAssignmentId.equals(existingRequesterAssignmentId)
+                        && incomingTargetUserId != null
+                        && incomingTargetUserId.equals(existingTargetUserId)) {
+                    throw new RuntimeException("Đã có ticket đổi ca đang chờ xử lý cho ca này");
+                }
+                continue;
+            }
+
+            if (incomingRelatedEntityId != null && incomingRelatedEntityId.equals(active.getRelatedEntityId())) {
+                throw new RuntimeException("Đã có ticket cùng loại đang chờ xử lý cho ca đã chọn");
+            }
+        }
+    }
+
+    private String resolveTicketAction(String title, String relatedEntityType) {
+        String normalizedTitle = title == null ? "" : title.trim().toLowerCase();
+        String normalizedEntityType = relatedEntityType == null ? "" : relatedEntityType.trim().toUpperCase();
+
+        if ("SHIFT_SWAP".equals(normalizedEntityType)
+                || normalizedTitle.contains("đổi ca")
+                || normalizedTitle.contains("nhờ nhận ca")) {
+            return "SHIFT_SWAP";
+        }
+        if (normalizedTitle.contains("nghỉ ca")) {
+            return "SHIFT_CANCEL";
+        }
+        if (normalizedTitle.contains("cập nhật ca")) {
+            return "SHIFT_UPDATE";
+        }
+        return normalizedEntityType;
+    }
+
+    private Integer parseMetaInt(String description, String key) {
+        if (description == null || description.isBlank()) {
+            return null;
+        }
+        java.util.regex.Pattern pattern = java.util.regex.Pattern.compile("\\[" + key + "=(\\d+)\\]");
+        java.util.regex.Matcher matcher = pattern.matcher(description);
+        if (!matcher.find()) {
+            return null;
+        }
+        try {
+            return Integer.parseInt(matcher.group(1));
+        } catch (NumberFormatException ex) {
+            return null;
+        }
+    }
+
     private WorkShiftAssignment validateShiftSwapTicketRequest(CreateTicketRequest request) {
         if (request.getRequesterUserId() == null) {
             throw new RuntimeException("Thiếu requesterUserId cho ticket đổi ca");
diff --git a/frontend/src/pages/HR/ShiftManagement.jsx b/frontend/src/pages/HR/ShiftManagement.jsx
@@ -281,6 +281,22 @@ const ShiftManagement = () => {
             return;
         }
         try {
+            const shiftCode = String(shiftForm.shiftCode || '').trim();
+            if (shiftCode) {
+                const matchedShifts = await shiftService.getShifts({ query: shiftCode, includeExpired: true });
+                const duplicateShift = (Array.isArray(matchedShifts) ? matchedShifts : []).find(
+                    (item) =>
+                        String(item.shiftCode || '').trim().toLowerCase() === shiftCode.toLowerCase()
+                        && String(item.id) !== String(editingShift?.id || ''),
+                );
+
+                if (duplicateShift) {
+                    setShiftFormErrors({ shiftCode: 'Mã ca đã tồn tại.' });
+                    setError('Mã ca đã tồn tại. Vui lòng chọn mã khác.');
+                    return;
+                }
+            }
+
             const payload = buildShiftPayload(shiftForm);
             if (editingShift) {
                 await shiftService.updateShift(editingShift.id, payload);
@@ -314,6 +330,31 @@ const ShiftManagement = () => {
             return;
         }
         try {
+            const userId = Number(assignmentForm.userId);
+            const workShiftId = Number(assignmentForm.workShiftId);
+            const shiftDate = assignmentForm.shiftDate;
+
+            const rowsOnDate = await shiftService.getAssignments({
+                userId,
+                startDate: shiftDate,
+                endDate: shiftDate,
+            });
+
+            const duplicateAssignment = (Array.isArray(rowsOnDate) ? rowsOnDate : []).find(
+                (item) =>
+                    Number(item?.user?.id) === userId
+                    && Number(item?.shift?.id) === workShiftId
+                    && String(item?.shiftDate || '') === String(shiftDate)
+                    && String(item?.id) !== String(editingAssignment?.id || ''),
+            );
+
+            if (duplicateAssignment) {
+                const duplicateErrors = { workShiftId: 'Phân công này đã tồn tại cho nhân viên trong ngày đã chọn.' };
+                setAssignmentFormErrors(duplicateErrors);
+                setError(duplicateErrors.workShiftId);
+                return;
+            }
+
             const payload = buildAssignmentPayload(assignmentForm);
             if (editingAssignment) {
                 await shiftService.updateAssignment(editingAssignment.id, payload);
diff --git a/frontend/src/pages/HR/ShiftTicketCenter.jsx b/frontend/src/pages/HR/ShiftTicketCenter.jsx
@@ -414,6 +414,45 @@ const ShiftTicketCenter = () => {
             return;
         }
 
+        const activeStatuses = new Set(['OPEN', 'IN_PROGRESS']);
+        const incomingMode = String(createForm.ticketMode || '').toUpperCase();
+        const incomingAssignmentId = Number(createForm.assignmentId);
+        const incomingTargetUserId = Number(createForm.targetUserId || 0);
+
+        const duplicateActiveTicket = tickets.find((ticket) => {
+            if (!activeStatuses.has(String(ticket?.status || '').toUpperCase())) {
+                return false;
+            }
+
+            if (Number(ticket?.createdByUserId || 0) !== Number(currentUserId || 0)) {
+                return false;
+            }
+
+            const title = String(ticket?.title || '').toLowerCase();
+            const relatedEntityType = String(ticket?.relatedEntityType || '').toUpperCase();
+            const relatedEntityId = Number(ticket?.relatedEntityId || 0);
+
+            if (incomingMode === 'SWAP') {
+                const existingRequesterAssignmentId = extractSwapId(ticket?.description, 'SWAP_REQUESTER_ASSIGNMENT_ID');
+                const existingTargetUserId = extractSwapId(ticket?.description, 'SWAP_TARGET_USER_ID')
+                    || Number(ticket?.assignedToUserId || 0);
+                return relatedEntityType === 'SHIFT_SWAP'
+                    && Number(existingRequesterAssignmentId || relatedEntityId) === incomingAssignmentId
+                    && Number(existingTargetUserId || 0) === incomingTargetUserId;
+            }
+
+            if (incomingMode === 'CANCEL') {
+                return title.includes('nghỉ ca') && relatedEntityId === incomingAssignmentId;
+            }
+
+            return title.includes('cập nhật ca') && relatedEntityId === incomingAssignmentId;
+        });
+
+        if (duplicateActiveTicket) {
+            setError('Đã có ticket cùng loại đang chờ xử lý cho ca này. Vui lòng chờ duyệt hoặc cập nhật ticket cũ.');
+            return;
+        }
+
         try {
             setSubmitting(true);
             if (createForm.ticketMode === 'SWAP') {

Original file line number	Diff line number	Diff line change
`@@ -21,5 +21,10 @@ public interface TicketRepository extends JpaRepository<Ticket, Long> {`
`21`	`21`
`22`	`22`	`List<Ticket> findByTicketCode(String ticketCode);`
`23`	`23`
	`24`	`+ List<Ticket> findByTicketTypeAndCreatedByIdAndStatusIn(`
	`25`	`+ TicketType ticketType,`
	`26`	`+ Integer createdByUserId,`
	`27`	`+ List<TicketStatus> statuses);`
	`28`	`+`
`24`	`29`	`long countByTicketType(TicketType ticketType);`
`25`	`30`	`}`