homework API: removed stale question.text field in favour of raw question.markdown_text (#2746)

Author: f213

src/apps/homework/api/serializers/question.py

@@ -4,26 +4,22 @@
 
 from apps.homework.api.serializers.stats import HomeworkStatsSerializer
 from apps.homework.models import Question
-from core.serializers import MarkdownField
 
 
 class QuestionSerializer(serializers.ModelSerializer):
-    text = MarkdownField()
     markdown_text = serializers.CharField(source="text")
 
     class Meta:
         model = Question
         fields = [
             "slug",
             "name",
-            "text",
             "markdown_text",
             "deadline",
         ]
 
 
 class QuestionDetailSerializer(serializers.ModelSerializer):
-    text = MarkdownField()
     markdown_text = serializers.CharField(source="text")
     breadcrumbs = serializers.SerializerMethodField()
     homework = HomeworkStatsSerializer(source="*")
@@ -35,7 +31,6 @@ class Meta:
             "breadcrumbs",
             "slug",
             "name",
-            "text",
             "markdown_text",
             "deadline",
             "homework",

src/apps/homework/api/serializers/stats.py

@@ -1,7 +1,6 @@
 from rest_framework import serializers
 
 from apps.homework.models import Question
-from core.serializers import MarkdownField
 
 
 class CrossCheckStatsSerializer(serializers.Serializer):
@@ -25,14 +24,11 @@ def to_representation(self, instance: Question) -> dict:
 
 
 class TemporarySoonToBeDepricatedQuestionSerializer(serializers.ModelSerializer):
-    text = MarkdownField()
-
     class Meta:
         model = Question
         fields = [
             "slug",
             "name",
-            "text",
             "deadline",
         ]
 

src/apps/homework/tests/homework/api/crosschecks/tests_crosschecks_api.py

@@ -40,7 +40,7 @@ def test_base_response(api, question, crosscheck):
 
     assert got["answer"]["question"]["slug"] == str(question.slug)
     assert got["answer"]["question"]["name"] == question.name
-    assert "text" in got["answer"]["question"]
+    assert "markdown_text" in got["answer"]["question"]
 
 
 @pytest.mark.parametrize(("checked", "is_checked"), [(None, False), (datetime(2032, 1, 1, tzinfo=timezone.utc), True)])

src/apps/homework/tests/homework/api/questions/tests_question_retrieve.py

@@ -35,12 +35,9 @@ def test_markdown(api, question, course):
 
     got = api.get(f"/api/v2/homework/questions/{question.slug}/")
 
-    assert "<em>should be rendered" in got["text"]
-    assert "*" not in got["text"]
-    assert "<em>should be rendered" in got["course"]["homework_check_recommendations"]
-
     assert "*" in got["markdown_text"], "The field is not rendered"
     assert "<em>" not in got["markdown_text"], "The field is not rendered"
+    assert "<em>should be rendered" in got["course"]["homework_check_recommendations"]
 
 
 def test_breadcrumbs(api, question, factory, another_course):

src/apps/lms/tests/api/homework_status_in_lesson_list/test_generic_homework_data.py

@@ -17,16 +17,14 @@ def test_question_to_deprecate(api, module, question):
     got = api.get(f"/api/v2/lms/lessons/?module={module.pk}")["results"][0]["homework"]["question"]
 
     assert got["name"] == question.name
-    assert "<em>" in got["text"], "text is rendered"
 
 
 def test_question(api, module, question):
     got = api.get(f"/api/v2/lms/lessons/?module={module.pk}")["results"][0]["question"]
 
     assert got["name"] == question.name
-    assert "<em>" in got["text"], "text is rendered"
-    assert "<em>" not in got["markdown_text"], "text is not rendered"
     assert "*" in got["markdown_text"], "text is not rendered"
+    assert "<em>" not in got["markdown_text"], "text is not rendered"
 
 
 @pytest.mark.xfail(reason="Moved N+1 out of scope, cuz too few real-world users will encounter it")

src/apps/lms/tests/api/test_lesson_retrieve.py

@@ -72,4 +72,3 @@ def test_question(api, lesson, question):
     got = api.get(f"/api/v2/lms/lessons/{lesson.pk}/")
 
     assert got["homework"]["question"]["name"] == question.name
-    assert "<em>" in got["homework"]["question"]["text"], "Make sure text is rendered"