fix model: Cannot read properties of undefined (reading '_id')

Author: toviszsolt

src/lib/model.js

@@ -241,19 +241,19 @@ const model = (collectionName = '', schema = {}) => {
   };
 
   const deleteItems = async (items) => {
-    if (items.length > 0) {
+    if (items && items.length > 0) {
       await executeMiddleware('pre', collectionName, 'delete', items);
 
       for (const el of items) {
-        data[collectionName].delete(el._id);
+        if (el && el._id) data[collectionName].delete(el._id);
       }
 
       storageController.onDelete(collectionName, items);
 
       await executeMiddleware('post', collectionName, 'delete', items);
-    }
 
-    return items;
+      return items;
+    }
   };
 
   const insertOne = async (item) => {
@@ -317,21 +317,24 @@ const model = (collectionName = '', schema = {}) => {
   };
 
   const findByIdAndDelete = async (id) => {
-    const items = await findById(id);
-    const results = await deleteItems([items]);
+    const item = (await findById(id)) || null;
+    const results = await deleteItems([item]);
     return resolveRefs(results[0]);
   };
 
   const deleteOne = async (query) => {
-    const items = await findOne(query);
-    const results = await deleteItems([items]);
+    const item = (await findOne(query)) || null;
+    const results = await deleteItems([item]);
     return resolveRefs(results[0]);
   };
 
   const deleteMany = async (query) => {
     const items = await findItems(query);
-    const results = await deleteItems(items);
-    return resolveRefs(results);
+    if (items && items.length > 0) {
+      const results = await deleteItems(items);
+      return resolveRefs(results);
+    }
+    return [];
   };
 
   // Helper to wrap public read API with pre/post read middleware

test/lib/model.test.js

@@ -364,7 +364,7 @@ describe('model.post', () => {
 });
 
 describe('model.pre (read)', () => {
-  it('pre read middleware csak publikus API-n fusson le', async () => {
+  it('pre read middleware should run only on public API', async () => {
     const preRead = jest.fn();
     testModel.pre('read', preRead);
     await testModel.find({ name: 'John' });
@@ -595,3 +595,41 @@ describe('model coverage tests', () => {
     await expect(m.replaceOne({ _id: a._id }, { name: 'B' })).rejects.toThrow();
   });
 });
+
+describe('model.deleteOne edge cases', () => {
+  const userSchema = Schema({
+    email: { type: 'string', unique: true },
+    name: { type: 'string' },
+  });
+  const userModel = model('useremails', userSchema);
+
+  beforeEach(async () => {
+    await userModel.deleteMany({});
+    await userModel.insertMany([
+      { email: 'a@a.com', name: 'A' },
+      { email: 'b@b.com', name: 'B' },
+    ]);
+  });
+
+  it('deleteOne with non-existing email returns null, does not throw', async () => {
+    const deleted = await userModel.deleteOne({ email: 'notfound@a.com' });
+    expect(deleted).toBeNull();
+    const all = await userModel.find({});
+    expect(all.length).toBe(2);
+  });
+
+  it('deleteMany with non-existing email returns empty array, does not throw', async () => {
+    const deleted = await userModel.deleteMany({ email: 'notfound@a.com' });
+    expect(Array.isArray(deleted)).toBe(true);
+    expect(deleted.length).toBe(0);
+    const all = await userModel.find({});
+    expect(all.length).toBe(2);
+  });
+
+  it('findByIdAndDelete with non-existing id returns null, does not throw', async () => {
+    const deleted = await userModel.findByIdAndDelete('notfoundid');
+    expect(deleted).toBeNull();
+    const all = await userModel.find({});
+    expect(all.length).toBe(2);
+  });
+});