Fix spelling and remove ignored flake8 checks

Signed-off-by: Bernát Gábor <[email protected]>

Author: gaborbernat

src/filelock/_api.py

@@ -17,7 +17,7 @@ def __init__(self, lock):
     def __enter__(self):
         return self.lock
 
-    def __exit__(self, exc_type, exc_value, traceback):
+    def __exit__(self, exc_type, exc_value, traceback):  # noqa: U100
         self.lock.release()
 
 
@@ -181,7 +181,7 @@ def __enter__(self):
         self.acquire()
         return self
 
-    def __exit__(self, exc_type, exc_value, traceback):
+    def __exit__(self, exc_type, exc_value, traceback):  # noqa: U100
         self.release()
 
     def __del__(self):

src/filelock/_unix.py

@@ -19,7 +19,7 @@ def _acquire(self):
         fd = os.open(self._lock_file, open_mode)
         try:
             fcntl.flock(fd, fcntl.LOCK_EX | fcntl.LOCK_NB)
-        except (OSError, IOError):
+        except (OSError, IOError):  # noqa: B014 # IOError is not OSError on python 2
             os.close(fd)
         else:
             self._lock_file_fd = fd

src/filelock/_windows.py

@@ -20,7 +20,7 @@ def _acquire(self):
         else:
             try:
                 msvcrt.locking(fd, msvcrt.LK_NBLCK, 1)
-            except (OSError, IOError):
+            except (OSError, IOError):  # noqa: B014 # IOError is not OSError on python 2
                 os.close(fd)
             else:
                 self._lock_file_fd = fd

tests/test_filelock.py

@@ -94,7 +94,7 @@ def run(self):
             self.ex = sys.exc_info()
 
     def join(self, timeout=None):
-        super(ExThread, self).join()
+        super(ExThread, self).join(timeout=timeout)
         if self.ex is not None:
             if sys.version_info[0] == 2:
                 wrapper_ex = self.ex[1]
@@ -114,7 +114,7 @@ def thread_work():
             with lock:
                 assert lock.is_locked
 
-    threads = [ExThread(target=thread_work) for i in range(100)]
+    threads = [ExThread(target=thread_work) for _ in range(100)]
     for thread in threads:
         thread.start()
     for thread in threads:
@@ -129,13 +129,13 @@ def test_threaded_lock_different_lock_obj(lock_type, tmp_path):
     # acquired the lock, thread group 2 must not hold their lock.
 
     def thread_work_one():
-        for i in range(1000):
+        for _ in range(1000):
             with lock_1:
                 assert lock_1.is_locked
                 assert not lock_2.is_locked
 
     def thread_work_two():
-        for i in range(1000):
+        for _ in range(1000):
             with lock_2:
                 assert not lock_1.is_locked
                 assert lock_2.is_locked

tox.ini

@@ -110,16 +110,6 @@ commands =
 [flake8]
 max-complexity = 22
 max-line-length = 120
-ignore =
-    N801 # CapWord convention
-    N806 # variable should be in lowercase
-    U100 # unused arguments
-    PT009 # use regular assert
-    E722 # bare except
-    B001 # bare except
-    B007 # loop variable not used within body
-    B014 # redundant exception
-    E741 # ambiguous variable
 
 [pep8]
 max-line-length = 120