Skip to content

Commit 3337263

Browse files
authored
fix (#1243)
1 parent 513bc00 commit 3337263

File tree

3 files changed

+25
-0
lines changed

3 files changed

+25
-0
lines changed

docs/changelog/1239.bugfix.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
the isolated build env now ignores :conf:`sitepackages`, :conf:`deps` and :conf:`description` as these do not make
2+
sense - by :user:`gaborbernat`

src/tox/config/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1135,6 +1135,8 @@ def parse_build_isolation(self, config, reader):
11351135
section_name = "testenv:{}".format(name)
11361136
if section_name not in self._cfg.sections:
11371137
self._cfg.sections[section_name] = {}
1138+
self._cfg.sections[section_name]["deps"] = ""
1139+
self._cfg.sections[section_name]["sitepackages"] = "False"
11381140
self._cfg.sections[section_name]["description"] = "isolated packaging environment"
11391141
config.envconfigs[name] = self.make_envconfig(
11401142
name, "{}{}".format(testenvprefix, name), reader._subs, config

tests/unit/config/test_config.py

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2946,6 +2946,27 @@ def test_isolated_build_overrides(newconfig, capsys):
29462946
assert deps == []
29472947

29482948

2949+
@pytest.mark.parametrize(
2950+
"key, set_value, default", [("deps", "crazy", []), ("sitepackages", "True", False)]
2951+
)
2952+
def test_isolated_build_ignores(newconfig, capsys, key, set_value, default):
2953+
config = newconfig(
2954+
[],
2955+
"""
2956+
[tox]
2957+
isolated_build = True
2958+
2959+
[testenv]
2960+
{} = {}
2961+
""".format(
2962+
key, set_value
2963+
),
2964+
)
2965+
package_env = config.envconfigs.get(".package")
2966+
value = getattr(package_env, key)
2967+
assert value == default
2968+
2969+
29492970
def test_config_via_pyproject_legacy(initproj):
29502971
initproj(
29512972
"config_via_pyproject_legacy-0.5",

0 commit comments

Comments
 (0)