Fix #1236 typos in isolated.py build method (#1235)

* Reproduce build error when pyproject defines requirements for package

* Fix typos

* Add changelog

* Skip test for win32 and py2

Author: unmade

docs/changelog/1236.bugfix.rst

@@ -0,0 +1 @@
+fix typos in isolated.py that made it impossible to install package with requirements in pyproject.toml - by :user:`unmade`

src/tox/package/builder/isolated.py

@@ -38,9 +38,9 @@ def build(config, session):
         if pkg_resources.Requirement(r).key not in base_build_deps
     ]
     if build_requires_dep:
-        with package_venv.newaction("build_requires", package_venv.envconfig.envdir) as action:
+        with package_venv.new_action("build_requires", package_venv.envconfig.envdir) as action:
             package_venv.run_install_command(packages=build_requires_dep, action=action)
-        package_venv.finishvenv(package_venv)
+        package_venv.finishvenv()
     return perform_isolated_build(build_info, package_venv, config.distdir, config.setupdir)
 
 

tests/integration/test_package_int.py

@@ -53,6 +53,9 @@ def test_package_flit(initproj, cmd):
                     author = "Happy Harry"
                     author-email = "[email protected]"
                     home-page = "https://github.com/happy-harry/is"
+                    requires = [
+                        "tox",
+                    ]
                     """,
             ".gitignore": ".tox",
         },

tests/integration/test_provision_int.py

@@ -9,6 +9,10 @@
 from tox.util.main import MAIN_FILE
 
 
+@pytest.mark.skipif(
+    "sys.platform == 'win32' and sys.version_info < (3,)",
+    reason="does not run on windows with py2",
+)
 def test_provision_missing(initproj, cmd):
     initproj(
         "pkg123-0.7",