Allow ConfigSet.add_config to receive parameterized generics for of_type. (#3288)

* Allow use of list[str] inside plugins

Fixes: #3287

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: ssbarnea

docs/changelog/3288.bugfix.rst

@@ -0,0 +1 @@
+Allow ``ConfigSet.add_config`` to receive parameterized generics for ``of_type``.

src/tox/config/loader/convert.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import typing
 from abc import ABC, abstractmethod
 from collections import OrderedDict
 from pathlib import Path
@@ -39,6 +40,10 @@ def to(self, raw: T, of_type: type[V], factory: Factory[V]) -> V:  # noqa: PLR09
             return self.to_env_list(raw)  # type: ignore[return-value]
         if issubclass(of_type, str):
             return self.to_str(raw)  # type: ignore[return-value]
+        # python does not allow use of parametrized generics with isinstance,
+        # so we need to check for them.
+        if hasattr(typing, "GenericAlias") and isinstance(of_type, typing.GenericAlias):
+            return list(self.to_list(raw, of_type=of_type))  # type: ignore[return-value]
         if isinstance(raw, of_type):  # already target type no need to transform it
             # do it this late to allow normalization - e.g. string strip
             return raw

tests/config/loader/test_str_convert.py

@@ -57,6 +57,21 @@ def test_str_convert_ok(raw: str, value: Any, of_type: type[Any]) -> None:
     assert result == value
 
 
+# Tests that can work only with py39 or newer due to type not being subscriptible before
+if sys.version_info >= (3, 9):
+
+    @pytest.mark.parametrize(
+        ("raw", "value", "of_type"),
+        [
+            ("", None, Optional[list[str]]),
+            ("1,2", ["1", "2"], Optional[list[str]]),
+        ],
+    )
+    def test_str_convert_ok_py39(raw: str, value: Any, of_type: type[Any]) -> None:
+        result = StrConvert().to(raw, of_type, None)
+        assert result == value
+
+
 @pytest.mark.parametrize(
     ("raw", "of_type", "exc_type", "msg"),
     [