Skip to content

Commit 8d69dfb

Browse files
authored
Do not pull in Python 2 as dependency (#2589)
1 parent 20ab8a0 commit 8d69dfb

File tree

2 files changed

+1
-22
lines changed

2 files changed

+1
-22
lines changed

.github/workflows/check.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
- "3.8"
2424
- "3.7"
2525
os:
26-
- ubuntu-20.04
26+
- ubuntu-22.04
2727
- windows-2022
2828
- macos-12
2929
steps:
@@ -36,10 +36,6 @@ jobs:
3636
fetch-depth: 0
3737
- name: Install self-tox
3838
run: python -m pip install .
39-
- name: Setup python2.7 as test dependency
40-
uses: actions/setup-python@v4
41-
with:
42-
python-version: 2.7
4339
- name: Setup python for test ${{ matrix.py }}
4440
uses: actions/setup-python@v4
4541
with:

tests/tox_env/python/virtual_env/test_virtualenv_api.py

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import os
44
import sys
5-
from pathlib import Path
65

76
import pytest
87
from pytest_mock import MockerFixture
@@ -169,19 +168,3 @@ def test_list_dependencies_command(tox_project: ToxProjectCreator) -> None:
169168
result.assert_success()
170169
request: ExecuteRequest = execute_calls.call_args[0][3]
171170
assert request.cmd == ["python", "-m", "pip", "freeze"]
172-
173-
174-
def test_can_build_and_run_python_2(tox_project: ToxProjectCreator, demo_pkg_inline: Path) -> None:
175-
try:
176-
session_via_cli(["-p", "2.7", "venv"])
177-
except RuntimeError: # pragma: no cover
178-
pytest.skip("no python 2.7 interpreter") # pragma: no cover
179-
proj = tox_project({"tox.ini": "[testenv]\npackage=wheel"})
180-
execute_calls = proj.patch_execute(lambda r: 0 if "install" in r.run_id else None)
181-
result = proj.run("r", "-e", "py27", "--root", str(demo_pkg_inline))
182-
result.assert_success()
183-
184-
install_cmd = next(
185-
i[0][3].cmd for i in execute_calls.call_args_list if "install" in i[0][3].run_id
186-
) # pragma: no cover
187-
assert install_cmd[:-1] == ["python", "-E", "-m", "pip", "install", "--force-reinstall", "--no-deps"]

0 commit comments

Comments
 (0)