Fix env variable substitutions with defaults containing colon (#2186)

* Fix handling of substitution defaults containing colon

* Join remaining parts of string instead of splitting on colon.
* Add test with substitution default that contains a colon (URL).

Fixes #2182

Signed-off-by: Marco Weber <[email protected]>

* Add changelog entry

Author: comabrewer

docs/changelog/2182.bugfix.rst

@@ -0,0 +1 @@
+Fix env variable substitutions with defaults containing colon (e.g. URL) -- by :user:`comabrewer`.

src/tox/config/loader/ini/replace.py

@@ -207,7 +207,7 @@ def replace_env(conf: "Config", env_name: Optional[str], args: List[str], chain:
     if key in os.environ:
         return os.environ[key]
 
-    return "" if len(args) == 1 else args[1]
+    return "" if len(args) == 1 else ":".join(args[1:])
 
 
 def replace_tty(args: List[str]) -> str:

tests/config/loader/ini/replace/test_replace_env_var.py

@@ -36,3 +36,10 @@ def test_replace_env_var_circular(replace_one: ReplaceOne, monkeypatch: MonkeyPa
     monkeypatch.setenv("MAGIC", "{env:MAGIC}")
     result = replace_one("{env:MAGIC}")
     assert result == "{env:MAGIC}"
+
+
+def test_replace_env_default_with_colon(replace_one: ReplaceOne, monkeypatch: MonkeyPatch) -> None:
+    """If we have a factor that is not specified within the core env-list then that's also an environment"""
+    monkeypatch.delenv("MAGIC", raising=False)
+    result = replace_one("{env:MAGIC:https://some.url.org}")
+    assert result == "https://some.url.org"