add warning that whitelisting is mandatory from tox 4 on (#1129)

obestwalter · gaborbernat · commit f67064e3e694 · 2019-01-08T19:41:36.000Z
* add warning that whitelisting is mandatory from tox 4 on

* add warning that whitelisting is mandatory from tox 4 on
diff --git a/docs/changelog/1129.deprecation.rst b/docs/changelog/1129.deprecation.rst
@@ -0,0 +1 @@
+Whitelisting of externals will be mandatory in tox 4: issue a deprecation warning as part of the already existing warning - by :user:`obestwalter`
diff --git a/src/tox/venv.py b/src/tox/venv.py
@@ -174,7 +174,8 @@ def _check_external_allowed_and_warn(self, path):
                 "  cmd: {}\n"
                 "  env: {}\n"
                 "Maybe you forgot to specify a dependency? "
-                "See also the whitelist_externals envconfig setting.".format(
+                "See also the whitelist_externals envconfig setting.\n\n"
+                "DEPRECATION WARNING: this will be an error in tox 4 and above!".format(
                     path, self.envconfig.envdir
                 )
             )

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Whitelisting of externals will be mandatory in tox 4: issue a deprecation warning as part of the already existing warning - by :user:`obestwalter`
Original file line number	Diff line number	Diff line change
`@@ -174,7 +174,8 @@ def _check_external_allowed_and_warn(self, path):`
`174`	`174`	`" cmd: {}\n"`
`175`	`175`	`" env: {}\n"`
`176`	`176`	`"Maybe you forgot to specify a dependency? "`
`177`		`- "See also the whitelist_externals envconfig setting.".format(`
	`177`	`+ "See also the whitelist_externals envconfig setting.\n\n"`
	`178`	`+ "DEPRECATION WARNING: this will be an error in tox 4 and above!".format(`
`178`	`179`	`path, self.envconfig.envdir`
`179`	`180`	`)`
`180`	`181`	`)`