refactor(clippy): fix warnings

Author: kurnevsky

src/main.rs

@@ -67,7 +67,7 @@ fn version() -> u32 {
     assert!(major < 1000, "Invalid major version");
     assert!(minor < 1000, "Invalid minor version");
     assert!(patch < 1000, "Invalid patch version");
-    3000000000 + major * 1000000 + minor * 1000 + patch
+    3_000_000_000 + major * 1_000_000 + minor * 1000 + patch
 }
 
 /// Bind a UDP listener to the socket address.
@@ -304,7 +304,7 @@ fn main() {
         LogType::None => { },
     }
 
-    for (key, _) in &config.unused {
+    for key in config.unused.keys() {
         warn!("Unused configuration key: {:?}", key);
     }
 

src/motd.rs

@@ -85,10 +85,10 @@ impl Motd {
     fn summary(source: u64) -> String {
         match source {
             0..=999 => format!("{}",source),
-            1000..=999999 => format!("{0:.1}K", source as f32 / 1000.0),
-            1000000..=999999999 => format!("{0:.1}M", source as f32 / 1000000.0),
-            1000000000..=999999999999 => format!("{0:.1}G", source as f32 / 1000000000.0),
-            1000000000000..=u64::MAX => format!("{0:.1}T", source as f32 / 1000000000000.0),
+            1_000..=999_999 => format!("{0:.1}K", source as f32 / 1_000.0),
+            1_000_000..=999_999_999 => format!("{0:.1}M", source as f32 / 1_000_000.0),
+            1_000_000_000..=999_999_999_999 => format!("{0:.1}G", source as f32 / 1_000_000_000.0),
+            1_000_000_000_000..=u64::MAX => format!("{0:.1}T", source as f32 / 1_000_000_000_000.0),
             _ => unreachable!("Packets counter has an impossible value")
         }
     }

src/node_config.rs

@@ -76,7 +76,7 @@ fn de_from_hex<'de, D>(deserializer: D) -> Result<PublicKey, D::Error> where D:
     let bootstrap_pk_bytes: [u8; 32] = FromHex::from_hex(s)
         .map_err(|e| de::Error::custom(format!("Can't make bytes from hex string {:?}", e)))?;
     PublicKey::from_slice(&bootstrap_pk_bytes)
-        .ok_or(de::Error::custom("Can't make PublicKey"))
+        .ok_or_else(|| de::Error::custom("Can't make PublicKey"))
 }
 
 // TODO: Remove this function. Use default String type after bug fix released.
@@ -259,18 +259,18 @@ pub fn cli_parse() -> NodeConfig {
 }
 
 /// Parse settings from a saved file.
-fn parse_config(config_path: String) -> NodeConfig {
+fn parse_config(config_path: &str) -> NodeConfig {
     let mut settings = Config::default();
 
     settings.set_default("log-type", "Stderr").expect("Can't set default value for `log-type`");
     settings.set_default("motd", "This is tox-rs").expect("Can't set default value for `motd`");
     settings.set_default("lan-discovery", "False").expect("Can't set default value for `lan-discovery`");
     settings.set_default("threads", "1").expect("Can't set default value for `threads`");
 
-    let config_file = if !Path::new(&config_path).exists() {
+    let config_file = if !Path::new(config_path).exists() {
         panic!("Can't find config file {}", config_path);
     } else {
-        CfgFile::with_name(&config_path)
+        CfgFile::with_name(config_path)
     };
 
     settings.merge(config_file).expect("Merging config file with default values failed");
@@ -287,7 +287,7 @@ fn parse_config(config_path: String) -> NodeConfig {
 fn run_config(matches: &ArgMatches) -> NodeConfig {
     let config_path = value_t!(matches.value_of("cfg-file"), String).unwrap_or_else(|e| e.exit());
 
-    parse_config(config_path)
+    parse_config(&config_path)
 }
 
 fn run_args(matches: &ArgMatches) -> NodeConfig {