fix: optimize some math operation

Author: toxicity188

api/src/main/java/kr/toxicity/model/api/bone/BoneTagRegistry.java

@@ -7,6 +7,7 @@
 package kr.toxicity.model.api.bone;
 
 import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
 
 import java.util.*;
 
@@ -35,12 +36,23 @@ public void addTag(@NotNull BoneTag tag) {
     }
 
     /**
-     * Gets bone tag by tag name
+     * Gets a bone tag by its name wrapped in an Optional.
      * @param tag tag name
-     * @return optional tag
+     * @return bone tag
+     * @since 1.15.2
      */
     public @NotNull Optional<BoneTag> byTagName(@NotNull String tag) {
-        return Optional.ofNullable(byName.get(tag));
+        return Optional.ofNullable(byTagNameOrNull(tag));
+    }
+
+    /**
+     * Gets a bone tag by its name.
+     * @param tag tag name
+     * @return bone tag or null
+     * @since 2.0.2
+     */
+    public @Nullable BoneTag byTagNameOrNull(@NotNull String tag) {
+        return byName.get(tag);
     }
 
     /**
@@ -50,16 +62,17 @@ public void addTag(@NotNull BoneTag tag) {
      */
     public @NotNull BoneName parse(@NotNull String rawName) {
         rawName = rawName.toLowerCase(Locale.ROOT);
-        var tagArray = List.of(rawName.split("_"));
-        if (tagArray.size() < 2) return new BoneName(Collections.emptySet(), rawName, rawName);
-        var maxSize = tagArray.size() - 1;
+        var tagArray = rawName.split("_");
+        if (tagArray.length < 2) return new BoneName(Collections.emptySet(), rawName, rawName);
+        var tagList = List.of(tagArray);
+        var maxSize = tagList.size() - 1;
         var set = new HashSet<BoneTag>(maxSize);
-        for (String s : tagArray) {
-            var tag = byTagName(s).orElse(null);
+        for (String s : tagList) {
+            var tag = byTagNameOrNull(s);
             if (tag != null && set.size() < maxSize) {
                 set.add(tag);
-            } else return new BoneName(Collections.unmodifiableSet(set), String.join("_", tagArray.subList(set.size(), tagArray.size())), rawName);
+            } else return new BoneName(Collections.unmodifiableSet(set), String.join("_", tagList.subList(set.size(), tagList.size())), rawName);
         }
-        return new BoneName(Collections.unmodifiableSet(set), String.join("_", tagArray.subList(set.size(), tagArray.size())), rawName);
+        return new BoneName(Collections.unmodifiableSet(set), String.join("_", tagList.subList(set.size(), tagList.size())), rawName);
     }
 }

api/src/main/java/kr/toxicity/model/api/platform/PlatformLocation.java

@@ -8,6 +8,8 @@
 
 import org.jetbrains.annotations.NotNull;
 
+import static java.lang.Math.*;
+
 /**
  * Represents a location in the underlying platform.
  * <p>
@@ -77,4 +79,29 @@ public interface PlatformLocation extends PlatformRegionHolder {
      * @since 2.0.0
      */
     @NotNull PlatformLocation add(double x, double y, double z);
+
+    /**
+     * Calculates the distance between this location and another location.
+     *
+     * @param other the other location
+     * @return the distance
+     * @since 2.0.2
+     */
+    default double distance(@NotNull PlatformLocation other) {
+        return sqrt(distanceSquared(other));
+    }
+
+    /**
+     * Calculates the squared distance between this location and another location.
+     *
+     * @param other the other location
+     * @return the squared distance
+     * @since 2.0.2
+     */
+    default double distanceSquared(@NotNull PlatformLocation other) {
+        var x = x() - other.x();
+        var y = y() - other.y();
+        var z = z() - other.z();
+        return fma(x, x, fma(y, y, z * z));
+    }
 }

api/src/main/java/kr/toxicity/model/api/util/EntityUtil.java

@@ -79,11 +79,11 @@ public static boolean canSee(@NotNull PlatformLocation player, @NotNull Platform
         if (!manager.sightTrace()) return true;
         else if (!player.world().equals(target.world())) return false;
 
-        var d = distance(player, target);
+        var d = player.distance(target);
         if (d > manager.maxSight()) return false;
         else if (d <= manager.minSight()) return true;
 
-        var t = PI - abs(atan(d)) * 2;
+        var t = fma(-abs(atan(d)), 2, PI);
         var ty = t + Y_RENDER_THRESHOLD;
         var tz = t + X_RENDER_THRESHOLD;
         return isInDegree(player, target, ty, tz);
@@ -99,14 +99,10 @@ public static boolean canSee(@NotNull PlatformLocation player, @NotNull Platform
      */
     public static boolean isCustomNameVisible(@NotNull PlatformLocation player, @NotNull PlatformLocation target) {
         if (!player.world().equals(target.world())) return false;
-        if (distance(player, target) > 5) return false;
+        if (player.distanceSquared(target) > 25) return false; // 5 ^ 2
         return isInPoint(player, target);
     }
 
-    private static double distance(@NotNull PlatformLocation a, @NotNull PlatformLocation b) {
-        return sqrt(pow(a.x() - b.x(), 2) + pow(a.z() - b.z(), 2));
-    }
-
     /**
      * Checks if a target entity is directly in the player's crosshair (point of view).
      *
@@ -129,6 +125,6 @@ private static boolean isInDegree(@NotNull PlatformLocation player, @NotNull Pla
 
         var ry = abs(atan2(dy, sqrt(MathUtil.fma(dz, dz, dx * dx))) - playerPitch);
         var rz = abs(atan2(-dx, dz) - playerYaw);
-        return (ry <= ty || ry >= PI * 2 - ty) && (rz <= tz || rz >= PI * 2 - tz);
+        return (ry <= ty || ry >= TAU - ty) && (rz <= tz || rz >= TAU - tz);
     }
 }