Skip to content

Commit 466d27e

Browse files
toyobayashitoyobayashi
committed
rename
1 parent d82a611 commit 466d27e

File tree

9 files changed

+27
-27
lines changed

9 files changed

+27
-27
lines changed

‎packages/emnapi/src/script.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export function napi_run_script (env: napi_env, script: napi_value, result: Poin
1818
if (typeof v8Script !== 'string') {
1919
return envObject.setLastError(napi_status.napi_string_expected)
2020
}
21-
const g = emnapiCtx.jsValueFromNapiValue<typeof globalThis>(GlobalHandle.GLOBAL)!
21+
const g = emnapiCtx.jsValueFromNapiValue<typeof globalThis>(Constant.GLOBAL)!
2222
const ret = g.eval(v8Script)
2323
from64('result')
2424

‎packages/emnapi/src/v8/internal.cc‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,12 @@ void VerifyHandleIsNonEmpty(bool is_empty) {
3737
}
3838

3939
Isolate::Isolate(): data_{} {
40-
*reinterpret_cast<internal::Address*>(data_ + internal::Internals::kIsolateRootsOffset + v8::internal::kApiSystemPointerSize * v8::internal::Internals::kUndefinedValueRootIndex) = static_cast<internal::Address>(v8impl::GlobalHandle::kUndefined);
41-
*reinterpret_cast<internal::Address*>(data_ + internal::Internals::kIsolateRootsOffset + v8::internal::kApiSystemPointerSize * v8::internal::Internals::kTheHoleValueRootIndex) = static_cast<internal::Address>(v8impl::GlobalHandle::kHole);
42-
*reinterpret_cast<internal::Address*>(data_ + internal::Internals::kIsolateRootsOffset + v8::internal::kApiSystemPointerSize * v8::internal::Internals::kNullValueRootIndex) = static_cast<internal::Address>(v8impl::GlobalHandle::kNull);
43-
*reinterpret_cast<internal::Address*>(data_ + internal::Internals::kIsolateRootsOffset + v8::internal::kApiSystemPointerSize * v8::internal::Internals::kFalseValueRootIndex) = static_cast<internal::Address>(v8impl::GlobalHandle::kFalse);
44-
*reinterpret_cast<internal::Address*>(data_ + internal::Internals::kIsolateRootsOffset + v8::internal::kApiSystemPointerSize * v8::internal::Internals::kTrueValueRootIndex) = static_cast<internal::Address>(v8impl::GlobalHandle::kTrue);
45-
*reinterpret_cast<internal::Address*>(data_ + internal::Internals::kIsolateRootsOffset + v8::internal::kApiSystemPointerSize * v8::internal::Internals::kEmptyStringRootIndex) = static_cast<internal::Address>(v8impl::GlobalHandle::kEmptyString);
40+
*reinterpret_cast<internal::Address*>(data_ + internal::Internals::kIsolateRootsOffset + v8::internal::kApiSystemPointerSize * v8::internal::Internals::kUndefinedValueRootIndex) = static_cast<internal::Address>(v8impl::Constant::kUndefined);
41+
*reinterpret_cast<internal::Address*>(data_ + internal::Internals::kIsolateRootsOffset + v8::internal::kApiSystemPointerSize * v8::internal::Internals::kTheHoleValueRootIndex) = static_cast<internal::Address>(v8impl::Constant::kHole);
42+
*reinterpret_cast<internal::Address*>(data_ + internal::Internals::kIsolateRootsOffset + v8::internal::kApiSystemPointerSize * v8::internal::Internals::kNullValueRootIndex) = static_cast<internal::Address>(v8impl::Constant::kNull);
43+
*reinterpret_cast<internal::Address*>(data_ + internal::Internals::kIsolateRootsOffset + v8::internal::kApiSystemPointerSize * v8::internal::Internals::kFalseValueRootIndex) = static_cast<internal::Address>(v8impl::Constant::kFalse);
44+
*reinterpret_cast<internal::Address*>(data_ + internal::Internals::kIsolateRootsOffset + v8::internal::kApiSystemPointerSize * v8::internal::Internals::kTrueValueRootIndex) = static_cast<internal::Address>(v8impl::Constant::kTrue);
45+
*reinterpret_cast<internal::Address*>(data_ + internal::Internals::kIsolateRootsOffset + v8::internal::kApiSystemPointerSize * v8::internal::Internals::kEmptyStringRootIndex) = static_cast<internal::Address>(v8impl::Constant::kEmptyString);
4646
}
4747

4848
}

‎packages/emnapi/src/v8/isolate.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* @__sig p
33
*/
44
export function _v8_isolate_get_current_context (): number {
5-
return GlobalHandle.GLOBAL
5+
return Constant.GLOBAL
66
}
77

88
/**

‎packages/emnapi/src/v8/v8_impl.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ namespace v8 {
1111

1212
namespace v8impl {
1313

14-
enum class GlobalHandle : v8::internal::Address {
14+
enum class Constant : v8::internal::Address {
1515
kHole,
1616
kEmpty,
1717
kUndefined,

‎packages/emnapi/src/value-operation.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export function napi_coerce_to_bool (env: napi_env, value: napi_value, result: P
5555
const jsValue = emnapiCtx.jsValueFromNapiValue(value)!
5656
from64('result')
5757

58-
v = jsValue ? GlobalHandle.TRUE : GlobalHandle.FALSE
58+
v = jsValue ? Constant.TRUE : Constant.FALSE
5959
makeSetValue('result', 0, 'v', '*')
6060
return $GET_RETURN_STATUS!(envObject)
6161
})

‎packages/emnapi/src/value/global.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export function napi_get_boolean (env: napi_env, value: bool, result: Pointer<na
88
$CHECK_ARG!(envObject, result)
99
from64('result')
1010

11-
const v = value === 0 ? GlobalHandle.FALSE : GlobalHandle.TRUE
11+
const v = value === 0 ? Constant.FALSE : Constant.TRUE
1212
makeSetValue('result', 0, 'v', '*')
1313
return envObject.clearLastError()
1414
}
@@ -19,7 +19,7 @@ export function napi_get_global (env: napi_env, result: Pointer<napi_value>): na
1919
$CHECK_ARG!(envObject, result)
2020
from64('result')
2121

22-
const value = GlobalHandle.GLOBAL
22+
const value = Constant.GLOBAL
2323
makeSetValue('result', 0, 'value', '*')
2424
return envObject.clearLastError()
2525
}
@@ -30,7 +30,7 @@ export function napi_get_null (env: napi_env, result: Pointer<napi_value>): napi
3030
$CHECK_ARG!(envObject, result)
3131
from64('result')
3232

33-
const value = GlobalHandle.NULL
33+
const value = Constant.NULL
3434
makeSetValue('result', 0, 'value', '*')
3535
return envObject.clearLastError()
3636
}
@@ -41,7 +41,7 @@ export function napi_get_undefined (env: napi_env, result: Pointer<napi_value>):
4141
$CHECK_ARG!(envObject, result)
4242
from64('result')
4343

44-
const value = GlobalHandle.UNDEFINED
44+
const value = Constant.UNDEFINED
4545
makeSetValue('result', 0, 'value', '*')
4646
return envObject.clearLastError()
4747
}

‎packages/runtime/src/Handle.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ export class HandleStore extends BaseArrayStore<any> {
1515
this._features = features
1616
this._allocator = new CountIdAllocator(HandleStore.MIN_ID)
1717

18-
this._values[GlobalHandle.UNDEFINED] = undefined
19-
this._values[GlobalHandle.NULL] = null
20-
this._values[GlobalHandle.FALSE] = false
21-
this._values[GlobalHandle.TRUE] = true
22-
this._values[GlobalHandle.GLOBAL] = features.getGlobalThis()
23-
this._values[GlobalHandle.EMPTY_STRING] = ''
18+
this._values[Constant.UNDEFINED] = undefined
19+
this._values[Constant.NULL] = null
20+
this._values[Constant.FALSE] = false
21+
this._values[Constant.TRUE] = true
22+
this._values[Constant.GLOBAL] = features.getGlobalThis()
23+
this._values[Constant.EMPTY_STRING] = ''
2424

2525
const _erase = (start: number, end: number): void => {
2626
for (let i = start; i < end; ++i) {

‎packages/runtime/src/Isolate.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,12 @@ export class Isolate {
3131
//#region Local handles
3232
public napiValueFromJsValue (value: unknown): number | bigint {
3333
switch (value) {
34-
case undefined: return GlobalHandle.UNDEFINED
35-
case null: return GlobalHandle.NULL
36-
case false: return GlobalHandle.FALSE
37-
case true: return GlobalHandle.TRUE
38-
case '': return GlobalHandle.EMPTY_STRING
39-
case this._globalThis: return GlobalHandle.GLOBAL
34+
case undefined: return Constant.UNDEFINED
35+
case null: return Constant.NULL
36+
case false: return Constant.FALSE
37+
case true: return Constant.TRUE
38+
case '': return Constant.EMPTY_STRING
39+
case this._globalThis: return Constant.GLOBAL
4040
default: return this._scopeStore.currentScope.add(value)
4141
}
4242
}

‎packages/runtime/src/typings/common.d.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ declare interface BufferCtor {
1313
isBuffer: (obj: unknown) => obj is IBuffer
1414
}
1515

16-
declare const enum GlobalHandle {
16+
declare const enum Constant {
1717
HOLE,
1818
EMPTY,
1919
UNDEFINED,

0 commit comments

Comments
 (0)