Improve TestNewGitServer

Thomas Peetz · Thomas Peetz · commit 9fe5f5447e91 · 2020-08-13T19:21:56.000+02:00
diff --git a/pkg/server/gitserver_test.go b/pkg/server/gitserver_test.go
@@ -20,9 +20,9 @@ var (
 	ghServer      = &github.Server{URL: "https://api.github.com"}
 	redmineConfig = map[string]interface{}{
 		"service": "redmine",
-		"limit":   120,
+		//"limit":   120,
 	}
-	rmServer      = &redmine.Server{URL: "https://redmine.example.com"}
+	rmServer      = &redmine.Server{URL: "https://redmine.example.com", Limit: 120}
 	unknownConfig = map[string]interface{}{
 		"service": "unknown",
 	}
@@ -41,6 +41,7 @@ func TestNewGitServer(t *testing.T) {
 		{"gitlab", args{gitlabConfig}, glServer, false},
 		{"github", args{githubConfig}, ghServer, false},
 		{"redmine", args{redmineConfig}, rmServer, false},
+		{"redmine-limit", args{map[string]interface{}{"service": "redmine", "limit": 99}}, &redmine.Server{URL: "https://redmine.example.com", Limit: 99}, false},
 		{"unknown", args{unknownConfig}, nil, true},
 	}
 	for _, tt := range tests {

Original file line number	Diff line number	Diff line change
`@@ -20,9 +20,9 @@ var (`
`20`	`20`	`ghServer = &github.Server{URL: "https://api.github.com"}`
`21`	`21`	`redmineConfig = map[string]interface{}{`
`22`	`22`	`"service": "redmine",`
`23`		`- "limit": 120,`
	`23`	`+ //"limit": 120,`
`24`	`24`	`}`
`25`		`- rmServer = &redmine.Server{URL: "https://redmine.example.com"}`
	`25`	`+ rmServer = &redmine.Server{URL: "https://redmine.example.com", Limit: 120}`
`26`	`26`	`unknownConfig = map[string]interface{}{`
`27`	`27`	`"service": "unknown",`
`28`	`28`	`}`
`@@ -41,6 +41,7 @@ func TestNewGitServer(t *testing.T) {`
`41`	`41`	`{"gitlab", args{gitlabConfig}, glServer, false},`
`42`	`42`	`{"github", args{githubConfig}, ghServer, false},`
`43`	`43`	`{"redmine", args{redmineConfig}, rmServer, false},`
	`44`	`+ {"redmine-limit", args{map[string]interface{}{"service": "redmine", "limit": 99}}, &redmine.Server{URL: "https://redmine.example.com", Limit: 99}, false},`
`44`	`45`	`{"unknown", args{unknownConfig}, nil, true},`
`45`	`46`	`}`
`46`	`47`	`for _, tt := range tests {`