fix: TriggerDefinition::when broke because of a new conflict with Laravel's Conditionable trait in v12.10.0

Author: tpetry

README.md

@@ -266,13 +266,13 @@ Schema::table('projects', function (Blueprint $table): void {
 
 The following table contains all of the available trigger modifiers:
 
-| Modifier                                                                          | Description                                                                                                                                                        |
-|-----------------------------------------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| `->forEachRow()`                                                                  | The trigger will be called for every row.                                                                                                                          |
-| `->forEachStatement()`                                                            | The trigger will be called once for each statement *(default)*.                                                                                                    |
-| `->transitionTables(`<br>`  old: 'oldrows',`<br>`  new: 'newrows',`<br>`)`        | The forEachStatement-trigger will provide the before/after state of the affected rows in special tables. You can omit either option if not valid for this trigger. |
-| `->when('NEW.type = 4')`<br>`->when(fn ($query) => $query->where('NEW.type', 4))` | The trigger should only be called when the condition matches *(only with forEachRow)*.                                                                             |
-| `->replace(true)`                                                                 | The trigger will replace an existing one defined with the same name.                                                                                               |
+| Modifier                                                                                            | Description                                                                                                                                                        |
+|-----------------------------------------------------------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| `->forEachRow()`                                                                                    | The trigger will be called for every row.                                                                                                                          |
+| `->forEachStatement()`                                                                              | The trigger will be called once for each statement *(default)*.                                                                                                    |
+| `->transitionTables(`<br>`  old: 'oldrows',`<br>`  new: 'newrows',`<br>`)`                          | The forEachStatement-trigger will provide the before/after state of the affected rows in special tables. You can omit either option if not valid for this trigger. |
+| `->whenCondition('NEW.type = 4')`<br>`->whenCondition(fn ($query) => $query->where('NEW.type', 4))` | The trigger should only be called when the condition matches *(only with forEachRow)*.                                                                             |
+| `->replace(true)`                                                                                   | The trigger will replace an existing one defined with the same name.                                                                                               |
 
 > [!NOTE] 
 > PostgreSQL always updates rows even if nothing changed, which may affect your performance. You can add the `suppress_redundant_updates_trigger()` trigger with a `BEFORE UPDATE` action to all tables.

src/Schema/Grammars/GrammarTrigger.php

@@ -47,8 +47,8 @@ public function compileTrigger(Blueprint $blueprint, Fluent $command): string
             default => null,
         };
 
-        if (filled($command['when'])) {
-            $condition = $command['when'];
+        if (filled($command['whenCondition'])) {
+            $condition = $command['whenCondition'];
             if ($condition instanceof Closure) {
                 $query = ($condition)(DB::query());
                 $condition = trim(str_replace('select * where', '', Query::toSql($query)));

src/Schema/TriggerDefinition.php

@@ -7,7 +7,7 @@
 use Illuminate\Support\Fluent;
 
 /**
- * @method $this when(string|callable $condition) Specify a condition when the trigger should be called.
+ * @method $this whenCondition(string|callable $condition) Specify a condition when the trigger should be called.
  * @method $this replace(bool $value = true) Specify whether the trigger should replace an existing one.
  */
 class TriggerDefinition extends Fluent

tests/Migration/TriggerTest.php

@@ -110,7 +110,7 @@ public function testCreateTriggerWhenBuilder(): void
             Schema::table('example', function (Blueprint $table): void {
                 $table->trigger('noop_274029', 'noop()', 'after insert')
                     ->forEachRow()
-                    ->when(fn (Builder $query) => $query->where('NEW.id', 42));
+                    ->whenCondition(fn (Builder $query) => $query->where('NEW.id', 42));
             });
         });
         $this->assertEquals(['create trigger "noop_274029" after insert on "example" for each row when (NEW."id" = 42) execute function noop()'], array_column($queries, 'query'));
@@ -122,7 +122,7 @@ public function testCreateTriggerWhenSql(): void
             Schema::table('example', function (Blueprint $table): void {
                 $table->trigger('noop_274029', 'noop()', 'after delete')
                     ->forEachRow()
-                    ->when('OLD.id = 0815');
+                    ->whenCondition('OLD.id = 0815');
             });
         });
         $this->assertEquals(['create trigger "noop_274029" after delete on "example" for each row when (OLD.id = 0815) execute function noop()'], array_column($queries, 'query'));