Merge pull request #565 from ziyao233/cmsisdap/avoid-memcpy-on-overlapping-buffer

trabucayre · web-flow · commit afb7bbeec248 · 2025-06-30T10:15:35.000+02:00
cmsisDAP: Avoid memcpy() on possibly overlapping buffer
diff --git a/src/cmsisDAP.cpp b/src/cmsisDAP.cpp
@@ -561,7 +561,7 @@ int CmsisDAP::xfer(int tx_len, uint8_t *rx_buff, int rx_len)
 		return ret;
 	}
 	if (rx_len)
-		memcpy(rx_buff, _ll_buffer, rx_len);
+		memmove(rx_buff, _ll_buffer, rx_len);
 
 
 	return ret;

Original file line number	Diff line number	Diff line change
`@@ -561,7 +561,7 @@ int CmsisDAP::xfer(int tx_len, uint8_t *rx_buff, int rx_len)`
`561`	`561`	`return ret;`
`562`	`562`	`}`
`563`	`563`	`if (rx_len)`
`564`		`- memcpy(rx_buff, _ll_buffer, rx_len);`
	`564`	`+ memmove(rx_buff, _ll_buffer, rx_len);`
`565`	`565`
`566`	`566`
`567`	`567`	`return ret;`