split task

Author: nina-kollman

sample-app/generate_joke_workflow_example.go

@@ -84,9 +84,14 @@ func translateJokeToPirate(ctx context.Context, traceloop *sdk.Traceloop, workfl
 		},
 	}
 
-	llmSpan, err := traceloop.LogAgent(ctx, sdk.AgentAttributes{
+	llmSpan, err := workflow.LogAgent(sdk.AgentAttributes{
 		Name: "joke_translation",
-	}, prompt, workflow.Attributes)
+	})
+	if err != nil {
+		return "", fmt.Errorf("LogPrompt error: %w", err)
+	}
+
+	llmSpan, err = workflow.LogPrompt(prompt)
 	if err != nil {
 		return "", fmt.Errorf("LogPrompt error: %w", err)
 	}
@@ -148,12 +153,17 @@ func historyJokesTool(ctx context.Context, traceloop *sdk.Traceloop, workflow *s
 		},
 	}
 
-	llmSpan, err := traceloop.LogToolCall(ctx, sdk.ToolCallAttributes{
-		Name: "history_jokes",
-	}, prompt, workflow.Attributes)
+	llmSpan, err := workflow.LogPrompt(prompt)
 	if err != nil {
 		return "", fmt.Errorf("LogPrompt error: %w", err)
 	}
+	
+	_, err = workflow.LogToolCall(sdk.ToolCallAttributes{
+		Name: "history_jokes",
+	})
+	if err != nil {
+		return "", fmt.Errorf("LogToolCall error: %w", err)
+	}
 
 	// Make API call
 	resp, err := client.CreateChatCompletion(ctx, openai.ChatCompletionRequest{
@@ -257,7 +267,6 @@ func runJokeWorkflow() {
 	}
 	defer func() { traceloop.Shutdown(ctx) }()
 
-	// Create OpenAI client
 	client := openai.NewClient(os.Getenv("OPENAI_API_KEY"))
 
 	// Create workflow

traceloop-sdk/model/types.go

@@ -0,0 +1,10 @@
+package model
+
+type SpanKind string
+
+const (
+	SpanKindTool SpanKind = "tool"
+	SpanKindAgent SpanKind = "agent"
+	SpanKindTask SpanKind = "task"
+	SpanKindWorkflow SpanKind = "workflow"
+)

traceloop-sdk/sdk.go

@@ -21,6 +21,11 @@ import (
 
 const PromptsPath = "/v1/traceloop/prompts"
 
+const (
+	ToolType = "tool"
+	AgentType = "agent"
+)
+
 type Traceloop struct {
 	config         Config
 	promptRegistry model.PromptRegistry
@@ -184,17 +189,14 @@ func (llmSpan *LLMSpan) LogCompletion(ctx context.Context, completion Completion
 	return nil
 }
 
-// LogToolCall logs a tool call with the specified name and prompt
-func (instance *Traceloop) LogToolCall(ctx context.Context, attrs ToolCallAttributes, prompt Prompt, workflowAttrs WorkflowAttributes) (LLMSpan, error) {
+// LogToolCall logs a tool call with the specified name
+func (instance *Traceloop) LogToolCall(ctx context.Context, attrs ToolCallAttributes, workflowAttrs WorkflowAttributes) (LLMSpan, error) {
 	spanName := fmt.Sprintf("%s.tool", attrs.Name)
 	_, span := instance.getTracer().Start(ctx, spanName)
 
 	spanAttrs := []attribute.KeyValue{
-		semconvai.LLMVendor.String(prompt.Vendor),
-		semconvai.LLMRequestModel.String(prompt.Model),
-		semconvai.LLMRequestType.String(prompt.Mode),
 		semconvai.TraceloopWorkflowName.String(workflowAttrs.Name),
-		semconvai.TraceloopSpanKind.String("tool"),
+		semconvai.TraceloopSpanKind.String(ToolType),
 		semconvai.TraceloopEntityName.String(attrs.Name),
 	}
 
@@ -204,25 +206,20 @@ func (instance *Traceloop) LogToolCall(ctx context.Context, attrs ToolCallAttrib
 	}
 
 	span.SetAttributes(spanAttrs...)
-	setMessagesAttribute(span, "llm.prompts", prompt.Messages)
-	setToolsAttribute(span, prompt.Tools)
 
 	return LLMSpan{
 		span: span,
 	}, nil
 }
 
-// LogAgent logs an agent with the specified name and prompt
-func (instance *Traceloop) LogAgent(ctx context.Context, attrs AgentAttributes, prompt Prompt, workflowAttrs WorkflowAttributes) (LLMSpan, error) {
+// LogAgent logs an agent with the specified name
+func (instance *Traceloop) LogAgent(ctx context.Context, attrs AgentAttributes, workflowAttrs WorkflowAttributes) (LLMSpan, error) {
 	spanName := fmt.Sprintf("%s.agent", attrs.Name)
 	_, span := instance.getTracer().Start(ctx, spanName)
 
 	spanAttrs := []attribute.KeyValue{
-		semconvai.LLMVendor.String(prompt.Vendor),
-		semconvai.LLMRequestModel.String(prompt.Model),
-		semconvai.LLMRequestType.String(prompt.Mode),
 		semconvai.TraceloopWorkflowName.String(workflowAttrs.Name),
-		semconvai.TraceloopSpanKind.String("agent"),
+		semconvai.TraceloopSpanKind.String(AgentType),
 		semconvai.LLMAgentName.String(attrs.Name),
 	}
 
@@ -232,8 +229,6 @@ func (instance *Traceloop) LogAgent(ctx context.Context, attrs AgentAttributes,
 	}
 
 	span.SetAttributes(spanAttrs...)
-	setMessagesAttribute(span, "llm.prompts", prompt.Messages)
-	setToolsAttribute(span, prompt.Tools)
 
 	return LLMSpan{
 		span: span,

traceloop-sdk/task.go

@@ -0,0 +1,29 @@
+package traceloop
+
+import (
+	"context"
+
+	"go.opentelemetry.io/otel/trace"
+)
+
+type Task struct {
+	workflow *Workflow
+	ctx      context.Context
+	Name     string `json:"name"`
+}
+
+func (task *Task) End() {
+	trace.SpanFromContext(task.ctx).End()
+}
+
+func (task *Task) LogPrompt(prompt Prompt) (LLMSpan, error) {
+	return task.workflow.sdk.LogPrompt(task.ctx, prompt, task.workflow.Attributes)
+}
+
+func (task *Task) LogAgent(attrs AgentAttributes) (LLMSpan, error) {
+	return task.workflow.sdk.LogAgent(task.ctx, attrs, task.workflow.Attributes)
+}
+
+func (task *Task) LogToolCall(attrs ToolCallAttributes) (LLMSpan, error) {
+	return task.workflow.sdk.LogToolCall(task.ctx, attrs, task.workflow.Attributes)
+}

traceloop-sdk/workflow.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 
+	"github.com/traceloop/go-openllmetry/traceloop-sdk/model"
 	semconvai "github.com/traceloop/go-openllmetry/semconv-ai"
 	"go.opentelemetry.io/otel/trace"
 )
@@ -14,18 +15,12 @@ type Workflow struct {
 	Attributes WorkflowAttributes `json:"workflow_attributes"`
 }
 
-type Task struct {
-	workflow *Workflow
-	ctx      context.Context
-	Name     string `json:"name"`
-}
-
 func (instance *Traceloop) NewWorkflow(ctx context.Context, attrs WorkflowAttributes) *Workflow {
 	wCtx, span := instance.getTracer().Start(ctx, fmt.Sprintf("%s.workflow", attrs.Name), trace.WithNewRoot())
 
 	span.SetAttributes(
 		semconvai.TraceloopWorkflowName.String(attrs.Name),
-		semconvai.TraceloopSpanKind.String("workflow"),
+		semconvai.TraceloopSpanKind.String(string(model.SpanKindWorkflow)),
 		semconvai.TraceloopEntityName.String(attrs.Name),
 	)
 
@@ -49,7 +44,7 @@ func (workflow *Workflow) NewTask(name string) *Task {
 
 	span.SetAttributes(
 		semconvai.TraceloopWorkflowName.String(workflow.Attributes.Name),
-		semconvai.TraceloopSpanKind.String("task"),
+		semconvai.TraceloopSpanKind.String(string(model.SpanKindTask)),
 		semconvai.TraceloopEntityName.String(name),
 	)
 
@@ -60,10 +55,10 @@ func (workflow *Workflow) NewTask(name string) *Task {
 	}
 }
 
-func (task *Task) End() {
-	trace.SpanFromContext(task.ctx).End()
+func (workflow *Workflow) LogAgent(attrs AgentAttributes) (LLMSpan, error) {
+	return workflow.sdk.LogAgent(workflow.ctx, attrs, workflow.Attributes)
 }
 
-func (task *Task) LogPrompt(prompt Prompt) (LLMSpan, error) {
-	return task.workflow.sdk.LogPrompt(task.ctx, prompt, task.workflow.Attributes)
+func (workflow *Workflow) LogToolCall(attrs ToolCallAttributes) (LLMSpan, error) {
+	return workflow.sdk.LogToolCall(workflow.ctx, attrs, workflow.Attributes)
 }