fix custom

Author: nina-kollman

packages/sample-app/src/sample_associations.ts

@@ -32,35 +32,42 @@ class ChatbotWithAssociations {
     console.log(`User ID: ${this.userId}`);
     console.log(`Session ID: ${this.sessionId}\n`);
 
-    // Set associations at the beginning of the conversation
+    // Set standard associations at the beginning of the conversation
     // These will be automatically attached to all spans within this context
     traceloop.Associations.set([
       [traceloop.AssociationProperty.CONVERSATION_ID, this.conversationId],
       [traceloop.AssociationProperty.USER_ID, this.userId],
       [traceloop.AssociationProperty.SESSION_ID, this.sessionId],
     ]);
 
-    // First message
-    const greeting = await this.sendMessage(
-      "Hello! What's the weather like today?",
+    // Use withAssociationProperties to add custom properties
+    // Custom properties (like chat_subject) will be prefixed with traceloop.association.properties
+    return traceloop.withAssociationProperties(
+      { chat_subject: "general" },
+      async () => {
+        // First message
+        const greeting = await this.sendMessage(
+          "Hello! What's the weather like today?",
+        );
+        console.log(`Bot: ${greeting}\n`);
+
+        // Second message in the same conversation
+        const followup = await this.sendMessage(
+          "What should I wear for that weather?",
+        );
+        console.log(`Bot: ${followup}\n`);
+
+        // Third message
+        const final = await this.sendMessage("Thanks for the advice!");
+        console.log(`Bot: ${final}\n`);
+
+        return {
+          greeting,
+          followup,
+          final,
+        };
+      },
     );
-    console.log(`Bot: ${greeting}\n`);
-
-    // Second message in the same conversation
-    const followup = await this.sendMessage(
-      "What should I wear for that weather?",
-    );
-    console.log(`Bot: ${followup}\n`);
-
-    // Third message
-    const final = await this.sendMessage("Thanks for the advice!");
-    console.log(`Bot: ${final}\n`);
-
-    return {
-      greeting,
-      followup,
-      final,
-    };
   }
 
   /**
@@ -138,7 +145,7 @@ async function main() {
   console.log("============================================");
 
   try {
-    // Example 1: Multi-turn chatbot conversation
+    // Example 1: Multi-turn chatbot conversation with custom properties
     const chatbot = new ChatbotWithAssociations(
       "conv-abc-123", // conversation_id
       "user-alice-456", // user_id
@@ -155,7 +162,7 @@ async function main() {
       "Check your Traceloop dashboard to see the associations attached to traces!",
     );
     console.log(
-      "You can filter and search by conversation_id, user_id, session_id, or customer_id.",
+      "You can filter and search by conversation_id, user_id, session_id, customer_id, or custom properties like chat_subject.",
     );
   } catch (error) {
     console.error("Error running demo:", error);

packages/traceloop-sdk/src/lib/tracing/ai-sdk-transformations.ts

@@ -3,6 +3,7 @@ import {
   SpanAttributes,
   TraceloopSpanKindValues,
 } from "@traceloop/ai-semantic-conventions";
+import { STANDARD_ASSOCIATION_PROPERTIES } from "./associations";
 
 const AI_GENERATE_TEXT = "ai.generateText";
 const AI_STREAM_TEXT = "ai.streamText";
@@ -601,8 +602,11 @@ const transformTelemetryMetadata = (
         const stringValue = typeof value === "string" ? value : String(value);
         metadataAttributes[metadataKey] = stringValue;
 
-        // Also set as association property attribute
-        attributes[metadataKey] = stringValue;
+        // Standard properties are set directly, custom properties get prefix
+        const attributeKey = STANDARD_ASSOCIATION_PROPERTIES.has(metadataKey)
+          ? metadataKey
+          : `${SpanAttributes.TRACELOOP_ASSOCIATION_PROPERTIES}.${metadataKey}`;
+        attributes[attributeKey] = stringValue;
       }
     }
   }

packages/traceloop-sdk/src/lib/tracing/associations.ts

@@ -12,6 +12,14 @@ export enum AssociationProperty {
   SESSION_ID = "session_id",
 }
 
+/**
+ * Set of standard association property keys (without prefix).
+ * Use this to check if a property should be set directly or with the TRACELOOP_ASSOCIATION_PROPERTIES prefix.
+ */
+export const STANDARD_ASSOCIATION_PROPERTIES = new Set<string>(
+  Object.values(AssociationProperty)
+);
+
 /**
  * Type alias for a single association
  */

packages/traceloop-sdk/src/lib/tracing/span-processor.ts

@@ -20,6 +20,7 @@ import {
   transformAiSdkSpanNames,
 } from "./ai-sdk-transformations";
 import { parseKeyPairsIntoRecord } from "./baggage-utils";
+import { STANDARD_ASSOCIATION_PROPERTIES } from "./associations";
 
 export const ALL_INSTRUMENTATION_LIBRARIES = "all" as const;
 type AllInstrumentationLibraries = typeof ALL_INSTRUMENTATION_LIBRARIES;
@@ -197,7 +198,11 @@ const onSpanStart = (span: Span): void => {
     .getValue(ASSOCATION_PROPERTIES_KEY);
   if (associationProperties) {
     for (const [key, value] of Object.entries(associationProperties)) {
-      span.setAttribute(key, value);
+      // Standard properties are set directly, custom properties get prefix
+      const attributeKey = STANDARD_ASSOCIATION_PROPERTIES.has(key)
+        ? key
+        : `${SpanAttributes.TRACELOOP_ASSOCIATION_PROPERTIES}.${key}`;
+      span.setAttribute(attributeKey, value);
     }
   }