refactor(tests): remove unused Mock import and clean up assertion formatting in attachment tests

Author: galzilber

packages/traceloop-sdk/tests/dataset/test_attachments.py

@@ -3,7 +3,7 @@
 import pytest
 import tempfile
 import os
-from unittest.mock import Mock, patch
+from unittest.mock import patch
 from traceloop.sdk.dataset import (
     Attachment,
     ExternalAttachment,
@@ -193,4 +193,4 @@ def test_attachment_reference():
     assert ref.storage_type == FileStorageType.INTERNAL
     assert ref.storage_key == "bucket/key.pdf"
     assert ref.get_url() is None  # No download URL implementation yet
-    assert str(ref) == "<AttachmentReference(internal, key=bucket/key.pdf)>"
+    assert str(ref) == "<AttachmentReference(internal, key=bucket/key.pdf)>"

packages/traceloop-sdk/tests/dataset/test_dataset_with_attachments.py

@@ -3,12 +3,11 @@
 import pytest
 import tempfile
 import os
-from unittest.mock import Mock, patch
+from unittest.mock import patch
 from traceloop.sdk.dataset import (
     Attachment,
     ExternalAttachment,
     FileCellType,
-    FileStorageType,
 )
 from traceloop.sdk.dataset.model import CreateDatasetRequest, ColumnDefinition, ColumnType
 
@@ -283,4 +282,4 @@ def test_create_dataset_without_attachments(datasets):
     assert dataset.rows[0].values["id"] == "A"
     assert dataset.rows[0].values["value"] == 100
     assert dataset.rows[1].values["id"] == "B"
-    assert dataset.rows[1].values["value"] == 200
+    assert dataset.rows[1].values["value"] == 200

packages/traceloop-sdk/traceloop/sdk/dataset/attachment.py

@@ -8,7 +8,6 @@
 import requests
 from typing import Optional, Dict, Any, Union, BinaryIO
 from pathlib import Path
-from datetime import datetime
 
 from traceloop.sdk.client.http import HTTPClient
 from .model import (
@@ -87,7 +86,9 @@ def __init__(
         if content_type:
             self.content_type = content_type
         elif file_path:
-            self.content_type = mimetypes.guess_type(file_path)[0] or "application/octet-stream"
+            self.content_type = (
+                mimetypes.guess_type(file_path)[0] or "application/octet-stream"
+            )
         else:
             self.content_type = "application/octet-stream"
 
@@ -168,8 +169,7 @@ def upload(
         success = self._upload_to_s3(upload_response.upload_url)
         if not success:
             self._confirm_upload(
-                http_client, dataset_slug, row_id, column_slug,
-                status="failed"
+                http_client, dataset_slug, row_id, column_slug, status="failed"
             )
             raise Exception(f"Failed to upload file to S3: {self.filename}")
 
@@ -182,8 +182,12 @@ def upload(
         final_metadata["size_bytes"] = self._get_file_size()
 
         self._confirm_upload(
-            http_client, dataset_slug, row_id, column_slug,
-            status="success", metadata=final_metadata
+            http_client,
+            dataset_slug,
+            row_id,
+            column_slug,
+            status="success",
+            metadata=final_metadata,
         )
 
         # Return reference to uploaded file
@@ -475,4 +479,4 @@ def __repr__(self) -> str:
         if self.storage_type == FileStorageType.EXTERNAL:
             return f"<AttachmentReference(external, url={self.url})>"
         else:
-            return f"<AttachmentReference(internal, key={self.storage_key})>"
+            return f"<AttachmentReference(internal, key={self.storage_key})>"