Add ERROR_TYPE Attribute from OpenTelemetry Semconv to catch Tools error in LangChain Instrumentor (#3230)

Author: divyapathak24

packages/opentelemetry-instrumentation-langchain/opentelemetry/instrumentation/langchain/callback_handler.py

@@ -66,6 +66,7 @@
 from opentelemetry.trace import SpanKind, Tracer, set_span_in_context
 from opentelemetry.trace.span import Span
 from opentelemetry.trace.status import Status, StatusCode
+from opentelemetry.semconv.attributes.error_attributes import ERROR_TYPE
 
 
 def _extract_class_name_from_serialized(serialized: Optional[dict[str, Any]]) -> str:
@@ -240,7 +241,11 @@ def _create_span(
         # Set metadata as span attributes if available
         if metadata is not None:
             for key, value in sanitized_metadata.items():
-                _set_span_attribute(span, f"{SpanAttributes.TRACELOOP_ASSOCIATION_PROPERTIES}.{key}", value)
+                _set_span_attribute(
+                    span,
+                    f"{SpanAttributes.TRACELOOP_ASSOCIATION_PROPERTIES}.{key}",
+                    value,
+                )
 
         self.spans[run_id] = SpanHolder(
             span, token, None, [], workflow_name, entity_name, entity_path
@@ -300,7 +305,9 @@ def _create_llm_span(
             metadata=metadata,
         )
 
-        vendor = detect_vendor_from_class(_extract_class_name_from_serialized(serialized))
+        vendor = detect_vendor_from_class(
+            _extract_class_name_from_serialized(serialized)
+        )
 
         _set_span_attribute(span, SpanAttributes.LLM_SYSTEM, vendor)
         _set_span_attribute(span, SpanAttributes.LLM_REQUEST_TYPE, request_type.value)
@@ -425,7 +432,12 @@ def on_chat_model_start(
 
         name = self._get_name_from_callback(serialized, kwargs=kwargs)
         span = self._create_llm_span(
-            run_id, parent_run_id, name, LLMRequestTypeValues.CHAT, metadata=metadata, serialized=serialized
+            run_id,
+            parent_run_id,
+            name,
+            LLMRequestTypeValues.CHAT,
+            metadata=metadata,
+            serialized=serialized,
         )
         set_request_params(span, kwargs, self.spans[run_id])
         if should_emit_events():
@@ -451,7 +463,11 @@ def on_llm_start(
 
         name = self._get_name_from_callback(serialized, kwargs=kwargs)
         span = self._create_llm_span(
-            run_id, parent_run_id, name, LLMRequestTypeValues.COMPLETION, serialized=serialized
+            run_id,
+            parent_run_id,
+            name,
+            LLMRequestTypeValues.COMPLETION,
+            serialized=serialized,
         )
         set_request_params(span, kwargs, self.spans[run_id])
         if should_emit_events():
@@ -479,7 +495,9 @@ def on_llm_end(
                 "model_name"
             ) or response.llm_output.get("model_id")
             if model_name is not None:
-                _set_span_attribute(span, SpanAttributes.LLM_RESPONSE_MODEL, model_name or "unknown")
+                _set_span_attribute(
+                    span, SpanAttributes.LLM_RESPONSE_MODEL, model_name or "unknown"
+                )
 
                 if self.spans[run_id].request_model is None:
                     _set_span_attribute(
@@ -539,7 +557,9 @@ def on_llm_end(
                         SpanAttributes.LLM_RESPONSE_MODEL: model_name or "unknown",
                     },
                 )
-        set_chat_response_usage(span, response, self.token_histogram, token_usage is None, model_name)
+        set_chat_response_usage(
+            span, response, self.token_histogram, token_usage is None, model_name
+        )
         if should_emit_events():
             self._emit_llm_end_events(response)
         else:
@@ -705,6 +725,8 @@ def on_tool_error(
         **kwargs: Any,
     ) -> None:
         """Run when tool errors."""
+        span = self._get_span(run_id)
+        span.set_attribute(ERROR_TYPE, type(error).__name__)
         self._handle_error(error, run_id, parent_run_id, **kwargs)
 
     @dont_throw