Skip to content

Commit a0b2156

Browse files
committed
wip
1 parent a6ab630 commit a0b2156

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

packages/traceloop-sdk/traceloop/sdk/experiment/experiment.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,7 @@ async def run_in_github(
270270

271271
# Prepare request payload
272272
request_body = RunInGithubRequest(
273+
experiment_slug=experiment_slug,
273274
dataset_slug=dataset_slug,
274275
dataset_version=dataset_version,
275276
evaluator_slugs=evaluator_slugs,
@@ -280,7 +281,7 @@ async def run_in_github(
280281
)
281282

282283
response = self._http_client.post(
283-
f"/experiments/{experiment_slug}/run-in-github",
284+
"/experiments/run-in-github",
284285
request_body.model_dump(mode="json", exclude_none=True),
285286
)
286287

@@ -376,12 +377,12 @@ async def run_single_row(row) -> TaskResult:
376377
try:
377378
task_output = await task(row)
378379
return TaskResult(
379-
task_input=row,
380-
task_output=task_output,
380+
input=row,
381+
output=task_output,
381382
)
382383
except Exception as e:
383384
return TaskResult(
384-
task_input=row,
385+
input=row,
385386
error=str(e),
386387
)
387388

@@ -400,7 +401,7 @@ async def run_with_semaphore(row: Dict[str, Any]) -> TaskResult:
400401
task_results.append(result)
401402
except Exception as e:
402403
task_results.append(TaskResult(
403-
task_input=completed_task.task_input,
404+
input=completed_task.task_input,
404405
error=str(e),
405406
))
406407
continue

packages/traceloop-sdk/traceloop/sdk/experiment/model.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ class CreateTaskResponse(BaseModel):
7171
class TaskResult(BaseModel):
7272
"""Model for a single task result"""
7373

74-
task_input: Dict[str, Any]
75-
task_output: Optional[Dict[str, Any]] = None
74+
input: Dict[str, Any]
75+
output: Optional[Dict[str, Any]] = None
7676
error: Optional[str] = None
7777

7878

@@ -86,6 +86,7 @@ class GithubContext(BaseModel):
8686
class RunInGithubRequest(BaseModel):
8787
"""Model for bulk GitHub experiment execution request"""
8888

89+
experiment_slug: str
8990
dataset_slug: Optional[str] = None
9091
dataset_version: Optional[str] = None
9192
evaluator_slugs: Optional[List[str]] = None

0 commit comments

Comments
 (0)