packages/opentelemetry-instrumentation-writer/tests/cassettes/test_chat/test_writer_streaming_chat_tool_calls_with_events_with_no_content.yaml (1)

1-186: Apply cassette sanitization as noted in sibling file.

Same recommendation to scrub id/chatcmpl-tool-*/created/system_fingerprint for stability.

packages/opentelemetry-instrumentation-writer/tests/cassettes/test_chat/test_writer_streaming_chat_multiple_tool_call_requests_with_events_with_content.yaml (1)

1-121: Sanitize volatile identifiers and timestamps.

Mirror the before_record scrubbing to mask ids, tool ids, created, and system_fingerprint.

packages/opentelemetry-instrumentation-writer/tests/cassettes/test_chat/test_writer_async_streaming_chat_tool_calls_with_events_with_content.yaml (1)

1-186: Apply identifier/timestamp scrubbing as elsewhere.

packages/opentelemetry-instrumentation-writer/tests/cassettes/test_chat/test_writer_async_streaming_chat_multiple_tool_call_requests_legacy.yaml (1)

1-121: Scrub volatile IDs and timestamps for deterministic replays.

packages/opentelemetry-instrumentation-writer/opentelemetry/instrumentation/writer/__init__.py (4)

177-183: TTFT/TTG capture moved to first chunk — good fix.

Setting first_token_time on the first received chunk corrects TTFT/TTG. Thanks for addressing the earlier feedback.

Also applies to: 192-200

---

226-232: Async TTFT/TTG capture is correct too.

Same positive note for the async path.

Also applies to: 241-249

---

337-339: Unified LLM system casing (“writer”).

Matches metrics attributes and avoids cardinality skew.

---

438-440: Async span uses “writer” casing consistently.

Good.

packages/opentelemetry-instrumentation-writer/opentelemetry/instrumentation/writer/__init__.py (4)

72-74: Nit: merge isinstance checks.

Use a tuple for a single isinstance call (matches Ruff SIM101).

-def is_streaming_response(response):
-    return isinstance(response, Stream) or isinstance(response, AsyncStream)
+def is_streaming_response(response):
+    return isinstance(response, (Stream, AsyncStream))

---

92-103: Harden index handling in streamed deltas (avoid IndexError/TypeError).

choice_index/tool_index may be missing/None in some deltas. Default to 0 and guard math with int().

-            choice_index = chunk.choices[0].index
+            choice_index = chunk.choices[0].index or 0
@@
-                    tool_index = chunk.choices[0].delta.tool_calls[0].index
+                    tool_index = chunk.choices[0].delta.tool_calls[0].index or 0
@@
-                        enhance_list_size(
+                        enhance_list_size(
                             accumulated_response.choices[
                                 choice_index
                             ].message.tool_calls,
-                            tool_index + 1,
+                            int(tool_index) + 1,
                         )

If Writer’s SDK guarantees non-null indexes, feel free to ignore; otherwise this avoids hard crashes mid-stream.

Also applies to: 112-150

---

545-547: Optional: accept common truthy/falsey values for metrics env.

Support “1/0, yes/no, on/off” for robustness.

-def is_metrics_collection_enabled() -> bool:
-    return (os.getenv("TRACELOOP_METRICS_ENABLED") or "true").lower() == "true"
+def is_metrics_collection_enabled() -> bool:
+    val = (os.getenv("TRACELOOP_METRICS_ENABLED") or "true").strip().lower()
+    return val in {"true", "1", "yes", "on"}

---

594-609: Style: use contextlib.suppress for import-optional wrappers (Ruff SIM105).

Cleaner than try/except/pass.

+from contextlib import suppress
@@
-        for wrapped_method in WRAPPED_METHODS:
+        for wrapped_method in WRAPPED_METHODS:
@@
-            try:
-                wrap_function_wrapper(
+            with suppress(ModuleNotFoundError):
+                wrap_function_wrapper(
                     wrap_package,
                     f"{wrap_object}.{wrap_method}",
                     _wrap(
                         tracer,
                         token_histogram,
                         duration_histogram,
                         streaming_time_to_first_token,
                         streaming_time_to_generate,
                         event_logger,
                         wrapped_method,
                     ),
                 )
-            except ModuleNotFoundError:
-                pass
@@
-        for wrapped_method in WRAPPED_AMETHODS:
+        for wrapped_method in WRAPPED_AMETHODS:
@@
-            try:
-                wrap_function_wrapper(
+            with suppress(ModuleNotFoundError):
+                wrap_function_wrapper(
                     wrap_package,
                     f"{wrap_object}.{wrap_method}",
                     _awrap(
                         tracer,
                         token_histogram,
                         duration_histogram,
                         streaming_time_to_first_token,
                         streaming_time_to_generate,
                         event_logger,
                         wrapped_method,
                     ),
                 )
-            except ModuleNotFoundError:
-                pass

Also applies to: 615-630

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

packages/opentelemetry-instrumentation-writer/opentelemetry/instrumentation/writer/__init__.py (1)

40-41: Update instrumentation dependency to correct PyPI package name.

Based on the imports using from writerai.*, the correct package name should be writerai, not writer-sdk. This mismatch would prevent auto-instrumentation from working correctly.

Apply this diff to fix the package dependency:

-_instruments = ("writer-sdk >= 2.2.1, < 3",)
+_instruments = ("writerai >= 4.0.1, < 5",)

packages/opentelemetry-instrumentation-writer/opentelemetry/instrumentation/writer/__init__.py (6)

72-74: Simplify isinstance check by merging conditions.

The static analyzer correctly suggests merging the multiple isinstance calls for better readability.

-def is_streaming_response(response):
-    return isinstance(response, Stream) or isinstance(response, AsyncStream)
+def is_streaming_response(response):
+    return isinstance(response, (Stream, AsyncStream))

---

178-222: Missing exception recording on span in streaming processor.

The exception handling properly sets error status but doesn't record the exception details on the span, which reduces observability.

     except Exception as ex:
         error = ex
         if span.is_recording():
             span.set_status(Status(StatusCode.ERROR))
+            span.record_exception(ex)
         raise

---

238-281: Missing exception recording on span in async streaming processor.

Same issue as the sync version - exception details should be recorded on the span for better observability.

     except Exception as ex:
         error = ex
         if span.is_recording():
             span.set_status(Status(StatusCode.ERROR))
+            span.record_exception(ex)
         raise

---

369-380: Add exception recording to sync wrapper error handling.

While the error handling correctly sets span status and ends the span, it should also record the exception for better observability.

     except Exception as ex:  # pylint: disable=broad-except
         end_time = time.time()

         if duration_histogram:
             duration = end_time - start_time
             duration_histogram.record(duration, attributes=error_metrics_attributes(ex))

         if span.is_recording():
             span.set_status(Status(StatusCode.ERROR))
+            span.record_exception(ex)

         span.end()
         raise

---

470-481: Add exception recording to async wrapper error handling.

Mirror the improvement needed in the sync wrapper for consistent exception handling.

     except Exception as ex:  # pylint: disable=broad-except
         end_time = time.time()

         if duration_histogram:
             duration = end_time - start_time
             duration_histogram.record(duration, attributes=error_metrics_attributes(ex))

         if span.is_recording():
             span.set_status(Status(StatusCode.ERROR))
+            span.record_exception(ex)

         span.end()
         raise

---

616-631: Consider using contextlib.suppress for cleaner exception handling.

The static analyzer suggests using contextlib.suppress for the ModuleNotFoundError handling, which would be cleaner.

Add the import at the top:

+import contextlib
 import logging

Then apply these changes:

-            try:
-                wrap_function_wrapper(
+            with contextlib.suppress(ModuleNotFoundError):
+                wrap_function_wrapper(
                     wrap_package,
                     f"{wrap_object}.{wrap_method}",
                     _wrap(
                         tracer,
                         token_histogram,
                         duration_histogram,
                         streaming_time_to_first_token,
                         streaming_time_to_generate,
                         event_logger,
                         wrapped_method,
                     ),
                 )
-            except ModuleNotFoundError:
-                pass

Apply the same pattern to the async methods block.

Also applies to: 637-652

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: traceloop/openllmetry#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-17T15:06:48.109Z
Learning: Instrumentation packages must leverage the semantic conventions package and emit OTel-compliant spans

packages/opentelemetry-instrumentation-writer/opentelemetry/instrumentation/writer/__init__.py (7)

355-362: LLM system attribute casing is now consistent (“writer”). LGTM.

Also applies to: 456-463

---

368-381: Record exceptions on the span in the sync wrapper.

You set ERROR but don’t record the exception.

Apply:

     except Exception as ex:  # pylint: disable=broad-except
         end_time = time.time()
@@
         if span.is_recording():
-            span.set_status(Status(StatusCode.ERROR))
+            span.set_status(Status(StatusCode.ERROR))
+            span.record_exception(ex)
 
         span.end()
         raise

---

395-405: Streaming setup failure: include traceback in logs and record exception on span.

Apply:

-        except Exception as ex:
-            logger.warning(
-                "Failed to process streaming response for writer span, error: %s",
-                str(ex),
-            )
-            if span.is_recording():
-                span.set_status(Status(StatusCode.ERROR))
-
-            span.end()
-            raise
+        except Exception as ex:
+            logger.warning(
+                "Failed to process streaming response for writer span, error: %s",
+                str(ex),
+                exc_info=True,
+            )
+            if span.is_recording():
+                span.set_status(Status(StatusCode.ERROR))
+                span.record_exception(ex)
+            span.end()
+            raise

---

496-506: Async streaming setup failure: mirror logging and exception recording.

Apply:

-        except Exception as ex:
-            logger.warning(
-                "Failed to process streaming response for writer span, error: %s",
-                str(ex),
-            )
-            if span.is_recording():
-                span.set_status(Status(StatusCode.ERROR))
-
-            span.end()
-            raise
+        except Exception as ex:
+            logger.warning(
+                "Failed to process streaming response for writer span, error: %s",
+                str(ex),
+                exc_info=True,
+            )
+            if span.is_recording():
+                span.set_status(Status(StatusCode.ERROR))
+                span.record_exception(ex)
+            span.end()
+            raise

---

180-195: Stream metrics correctness: update last_token_time per chunk and record exceptions.

Without updating last_token_time inside the loop, TTG is wrong on early-terminated/erroring streams (can even go negative). Also record the exception on the span.

Apply:

-    try:
-        for chunk in response:
-            if first_token_time is None:
-                first_token_time = time.time()
-
-            _update_accumulated_response(accumulated_response, chunk)
-
-            yield chunk
-
-        last_token_time = time.time()
+    try:
+        for chunk in response:
+            if first_token_time is None:
+                first_token_time = time.time()
+            _update_accumulated_response(accumulated_response, chunk)
+            yield chunk
+            last_token_time = time.time()
     except Exception as ex:
         error = ex
         if span.is_recording():
-            span.set_status(Status(StatusCode.ERROR))
+            span.set_status(Status(StatusCode.ERROR))
+            span.record_exception(ex)
         raise

---

240-255: Async stream metrics: same fix as sync (update last_token_time and record exceptions).

Apply:

-    try:
-        async for chunk in response:
-            if first_token_time is None:
-                first_token_time = time.time()
-
-            _update_accumulated_response(accumulated_response, chunk)
-
-            yield chunk
-
-        last_token_time = time.time()
+    try:
+        async for chunk in response:
+            if first_token_time is None:
+                first_token_time = time.time()
+            _update_accumulated_response(accumulated_response, chunk)
+            yield chunk
+            last_token_time = time.time()
     except Exception as ex:
         error = ex
         if span.is_recording():
-            span.set_status(Status(StatusCode.ERROR))
+            span.set_status(Status(StatusCode.ERROR))
+            span.record_exception(ex)
         raise

---

40-41: Fix instrumentation dependency: switch to the writerai package (4.x)

Verified via PyPI that the canonical package names and versions are:

• writerai → latest 4.0.1
• writer-sdk → latest 2.3.1

The auto-instrumentation tuple must reference writerai >= 4, < 5, not the old writer-sdk range.

Affected file:

• packages/opentelemetry-instrumentation-writer/opentelemetry/instrumentation/writer/init.py

Please apply:

-_instruments = ("writer-sdk >= 2.2.1, < 3",)
+_instruments = ("writerai >= 4, < 5",)

packages/opentelemetry-instrumentation-writer/opentelemetry/instrumentation/writer/__init__.py (2)

611-632: Use contextlib.suppress for import-optional wrappers (Ruff SIM105).

Apply:

+import contextlib
@@
-        for wrapped_method in WRAPPED_METHODS:
+        for wrapped_method in WRAPPED_METHODS:
             wrap_package = wrapped_method.get("package")
             wrap_object = wrapped_method.get("object")
             wrap_method = wrapped_method.get("method")
-
-            try:
-                wrap_function_wrapper(
+            with contextlib.suppress(ModuleNotFoundError):
+                wrap_function_wrapper(
                     wrap_package,
                     f"{wrap_object}.{wrap_method}",
                     _wrap(
                         tracer,
                         token_histogram,
                         duration_histogram,
                         streaming_time_to_first_token,
                         streaming_time_to_generate,
                         event_logger,
                         wrapped_method,
                     ),
                 )
-            except ModuleNotFoundError:
-                pass
@@
-        for wrapped_method in WRAPPED_AMETHODS:
+        for wrapped_method in WRAPPED_AMETHODS:
             wrap_package = wrapped_method.get("package")
             wrap_object = wrapped_method.get("object")
             wrap_method = wrapped_method.get("method")
-            try:
-                wrap_function_wrapper(
+            with contextlib.suppress(ModuleNotFoundError):
+                wrap_function_wrapper(
                     wrap_package,
                     f"{wrap_object}.{wrap_method}",
                     _awrap(
                         tracer,
                         token_histogram,
                         duration_histogram,
                         streaming_time_to_first_token,
                         streaming_time_to_generate,
                         event_logger,
                         wrapped_method,
                     ),
                 )
-            except ModuleNotFoundError:
-                pass

Also applies to: 633-652

---

91-149: Streaming accumulator only processes the first choice/tool_call; iterate over all.

Writer can stream multiple choices and multiple tool_calls per chunk; handling only index 0 can drop data.

Apply (illustrative):

-        if chunk.choices:
-            choice_index = chunk.choices[0].index or 0
+        if chunk.choices:
+            for choice in chunk.choices:
+                choice_index = choice.index or 0
@@
-            if chunk.choices[0].delta:
-                if content := chunk.choices[0].delta.content:
+            if choice.delta:
+                if content := choice.delta.content:
                     accumulated_response.choices[
                         choice_index
                     ].message.content += content
-                if role := chunk.choices[0].delta.role:
+                if role := choice.delta.role:
                     accumulated_response.choices[choice_index].message.role = role
-                if chunk.choices[0].delta.tool_calls:
-                    tool_index = chunk.choices[0].delta.tool_calls[0].index or 0
+                for tool_call in (choice.delta.tool_calls or []):
+                    tool_index = tool_call.index or 0
@@
-                    if name := chunk.choices[0].delta.tool_calls[0].function.name:
+                    if name := tool_call.function.name:
                         accumulated_response.choices[choice_index].message.tool_calls[
                             tool_index
                         ].function.name += name
-                    if (
-                        arguments := chunk.choices[0]
-                        .delta.tool_calls[0]
-                        .function.arguments
-                    ):
+                    if (arguments := tool_call.function.arguments):
                         accumulated_response.choices[choice_index].message.tool_calls[
                             tool_index
                         ].function.arguments += arguments
-                    if tool_id := chunk.choices[0].delta.tool_calls[0].id:
+                    if tool_id := tool_call.id:
                         accumulated_response.choices[choice_index].message.tool_calls[
                             tool_index
                         ].id = tool_id

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: traceloop/openllmetry#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-17T15:06:48.109Z
Learning: Instrumentation packages must leverage the semantic conventions package and emit OTel-compliant spans