Merge pull request #1 from trustwallet/master

Adds Safety and Codecov CI (trustwallet#4408)

Author: tracyharbutte13

.github/workflows/flutter-ci.yml

@@ -0,0 +1,70 @@
+name: Flutter CI
+
+on:
+  push:
+    branches: [ dev, master ]
+  pull_request:
+    branches: [ dev, master ]
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  build:
+    runs-on: ubuntu-24.04
+    if: github.event.pull_request.draft == false
+    steps:
+    - uses: actions/checkout@v3
+    - name: Install system dependencies
+      run: |
+        tools/install-sys-dependencies-linux
+        tools/install-rust-dependencies
+    - name: Cache internal dependencies
+      id: internal_cache
+      uses: actions/cache@v3
+      with:
+        path: build/local
+        key: ${{ runner.os }}-${{ runner.arch }}-${{ hashFiles('tools/install-sys-dependencies-linux') }}-internal-${{ hashFiles('tools/install-dependencies') }}-${{ hashFiles('tools/dependencies-version') }}
+    - name: Install internal dependencies
+      run: |
+        tools/install-dependencies
+      env:
+        CC: /usr/bin/clang
+        CXX: /usr/bin/clang++
+      if: steps.internal_cache.outputs.cache-hit != 'true'
+
+    - name: Cache Rust
+      uses: Swatinem/rust-cache@v2
+      with:
+        workspaces: |
+          rust
+
+    - name: Code generation
+      run: |
+        tools/generate-files native
+      env:
+        CC: /usr/bin/clang
+        CXX: /usr/bin/clang++
+
+    - name: Setup Dart
+      uses: dart-lang/setup-dart@v1
+      with:
+        sdk: '3.8.1'
+        cache: true
+        cache-key: dart-3.8.1
+        cache-path: ${{ github.workspace }}/.pub-cache
+
+    - name: Install Dart dependencies
+      run: |
+        cd flutter
+        dart pub get
+        dart pub upgrade
+    
+    - name: Flutter build
+      run: |
+        tools/flutter-build
+      env:
+        CC: /usr/bin/clang
+        CXX: /usr/bin/clang++
+

.github/workflows/linux-ci-rust.yml .github/workflows/rust.yml.github/workflows/linux-ci-rust.yml renamed to .github/workflows/rust.yml

@@ -1,4 +1,4 @@
-name: Linux CI Rust
+name: Rust CI
 
 on:
   push:
@@ -16,7 +16,7 @@ concurrency:
 
 jobs:
   # Check formatting, clippy warnings, run tests and check code coverage.
-  build-and-test:
+  rust-lints:
     permissions:
       contents: read
       checks: write
@@ -51,18 +51,6 @@ jobs:
           cargo clippy -- -D warnings
         working-directory: rust
 
-      - name: Run tests
-        run: |
-          tools/rust-coverage
-
-      - name: Gather and check Rust code coverage
-        run: |
-          tools/check-coverage rust/coverage.stats rust/coverage.info
-
-      - name: Run Doc tests
-        run: |
-          tools/rust-test doc
-
   # Run Rust tests in WASM.
   test-wasm:
     runs-on: ubuntu-24.04
@@ -163,3 +151,113 @@ jobs:
           comment-author: 'github-actions[bot]'
           edit-mode: replace
           body-path: 'report-diff.md'
+
+  memory-profiler:
+    runs-on: ubuntu-24.04
+    if: github.event.pull_request.draft == false
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          submodules: true
+
+      - name: Run sccache-cache
+        uses: mozilla-actions/sccache-action@v0.0.8
+
+      - name: Cache Rust
+        uses: Swatinem/rust-cache@v2
+        with:
+          workspaces: |
+            rust
+
+      - name: Install llvm
+        run: |
+          # to get the symbolizer for debug symbol resolution
+          sudo apt install llvm
+
+      - name: Install nightly
+        uses: dtolnay/rust-toolchain@nightly
+
+      - name: Enable debug symbols
+        run: |
+            cd rust
+            # to fix buggy leak analyzer:
+            # https://github.com/japaric/rust-san#unrealiable-leaksanitizer
+            # ensure there's a profile.dev section
+            if ! grep -qE '^[ \t]*[profile.dev]' Cargo.toml; then
+                echo >> Cargo.toml
+                echo '[profile.dev]' >> Cargo.toml
+            fi
+            # remove pre-existing opt-levels in profile.dev
+            sed -i '/^\s*\[profile.dev\]/,/^\s*\[/ {/^\s*opt-level/d}' Cargo.toml
+            # now set opt-level to 1
+            sed -i '/^\s*\[profile.dev\]/a opt-level = 1' Cargo.toml
+            cat Cargo.toml
+        
+      - name: cargo test -Zsanitizer=address
+        # only --lib --tests b/c of https://github.com/rust-lang/rust/issues/53945
+        run: |
+          cd rust
+          cargo test --lib --tests --all-features --target x86_64-unknown-linux-gnu
+        env:
+          ASAN_OPTIONS: "detect_odr_violation=0:detect_leaks=0"
+          RUSTFLAGS: "-Z sanitizer=address"
+
+      - name: cargo test -Zsanitizer=leak
+        if: always()
+        run: |
+          cd rust
+          cargo test --all-features --target x86_64-unknown-linux-gnu
+        env:
+          RUSTFLAGS: "-Z sanitizer=leak"
+
+  coverage:
+    runs-on: ubuntu-24.04
+    if: github.event.pull_request.draft == false
+
+    steps:
+      - uses: actions/checkout@v3
+      - name: Install system dependencies
+        run: |
+          tools/install-sys-dependencies-linux
+
+      - name: Run sccache-cache
+        uses: mozilla-actions/sccache-action@v0.0.8
+
+      - name: Cache Rust
+        uses: Swatinem/rust-cache@v2
+        with:
+          workspaces: |
+            rust
+
+      - name: Install Rust dependencies
+        run: |
+          tools/install-rust-dependencies dev
+        
+      - name: cargo generate-lockfile
+        if: hashFiles('Cargo.lock') == ''
+        run: |
+          cd rust
+          cargo generate-lockfile
+      
+      - name: Run tests
+        run: |
+          tools/rust-coverage
+    
+      - name: Run Doc tests
+        run: |
+          tools/rust-test doc
+      
+      - name: Record Rust version
+        run: echo "RUST=$(rustc --version)" >> "$GITHUB_ENV"
+      
+      # TODO: Uncomment this when we have a codecov token
+      # - name: Upload to codecov.io
+      #   uses: codecov/codecov-action@v5
+      #   with:
+      #     fail_ci_if_error: true
+      #     token: ${{ secrets.CODECOV_TOKEN }}
+      #     env_vars: OS,RUST
+
+      - name: Gather and check Rust code coverage
+        run: |
+          tools/check-coverage rust/coverage.stats rust/lcov.info

.gitignore

@@ -57,6 +57,7 @@ emsdk/
 wasm-build/
 
 # Code coverage files
+lcov.info
 coverage.info
 coverage/
 swift/test_output/

CMakeLists.txt

@@ -91,6 +91,11 @@ elseif (${TW_COMPILE_JAVA})
     find_package(JNI REQUIRED)
     target_include_directories(TrustWalletCore PRIVATE ${JNI_INCLUDE_DIRS})
     target_link_libraries(TrustWalletCore PUBLIC ${WALLET_CORE_BINDGEN} ${PROJECT_NAME}_INTERFACE PRIVATE TrezorCrypto protobuf Boost::boost)
+elseif (${FLUTTER})
+    message("Configuring for Flutter")
+    file(GLOB_RECURSE sources src/*.c src/*.cc src/*.cpp src/*.h)
+    add_library(TrustWalletCore SHARED ${sources} ${PROTO_SRCS} ${PROTO_HDRS})
+    target_link_libraries(TrustWalletCore PUBLIC ${WALLET_CORE_BINDGEN} ${PROJECT_NAME}_INTERFACE PRIVATE TrezorCrypto protobuf Boost::boost)
 else ()
     message("Configuring standalone")
     file(GLOB_RECURSE sources src/*.c src/*.cc src/*.cpp src/*.h)

android/app/src/androidTest/java/com/trustwallet/core/app/blockchains/theopennetwork/TestTheOpenNetworkSigner.kt

@@ -26,7 +26,7 @@ class TestTheOpenNetworkSigner {
 
         val transfer = TheOpenNetwork.Transfer.newBuilder()
             .setDest("EQBm--PFwDv1yCeS-QTJ-L8oiUpqo9IT1BwgVptlSq3ts90Q")
-            .setAmount(10)
+            .setAmount(ByteString.copyFrom("0A".toHexByteArray())) // 10
             .setMode(TheOpenNetwork.SendMode.PAY_FEES_SEPARATELY_VALUE or TheOpenNetwork.SendMode.IGNORE_ACTION_PHASE_ERRORS_VALUE)
             .setBounceable(true)
             .build()
@@ -52,15 +52,15 @@ class TestTheOpenNetworkSigner {
         val privateKey = PrivateKey("c054900a527538c1b4325688a421c0469b171c29f23a62da216e90b0df2412ee".toHexByteArray())
 
         val jettonTransfer = TheOpenNetwork.JettonTransfer.newBuilder()
-            .setJettonAmount(500 * 1000 * 1000)
+            .setJettonAmount(ByteString.copyFrom("1DCD6500".toHexByteArray())) // 500 * 1000 * 1000
             .setToOwner("EQAFwMs5ha8OgZ9M4hQr80z9NkE7rGxUpE1hCFndiY6JnDx8")
             .setResponseAddress("EQBaKIMq5Am2p_rfR1IFTwsNWHxBkOpLTmwUain5Fj4llTXk")
-            .setForwardAmount(1)
+            .setForwardAmount(ByteString.copyFrom("01".toHexByteArray())) // 1
             .build()
 
         val transfer = TheOpenNetwork.Transfer.newBuilder()
             .setDest("EQBiaD8PO1NwfbxSkwbcNT9rXDjqhiIvXWymNO-edV0H5lja")
-            .setAmount(100 * 1000 * 1000)
+            .setAmount(ByteString.copyFrom("05F5E100".toHexByteArray())) // 100 * 1000 * 1000
             .setMode(TheOpenNetwork.SendMode.PAY_FEES_SEPARATELY_VALUE or TheOpenNetwork.SendMode.IGNORE_ACTION_PHASE_ERRORS_VALUE)
             .setComment("test comment")
             .setBounceable(true)
@@ -100,7 +100,7 @@ class TestTheOpenNetworkSigner {
         val transfer = TheOpenNetwork.Transfer.newBuilder()
             .setDest(dogeChatbotDeployingAddress)
             // 0.069 TON
-            .setAmount(69_000_000)
+            .setAmount(ByteString.copyFrom("041CDB40".toHexByteArray())) // 69_000_000
             .setMode(TheOpenNetwork.SendMode.PAY_FEES_SEPARATELY_VALUE or TheOpenNetwork.SendMode.IGNORE_ACTION_PHASE_ERRORS_VALUE)
             .setBounceable(false)
             .setStateInit(dogeChatbotStateInit)

android/gradlew

@@ -15,7 +15,7 @@ if isHelp; then
 fi
 
 echo "#### Installing system dependencies ... ####"
-if [[ $(uname) == "Darwin" ]]; then
+if [[ $(uname -s) == "Darwin" ]]; then
   tools/install-sys-dependencies-mac
 else
   tools/install-sys-dependencies-linux

bootstrap.sh

@@ -1,7 +1,9 @@
 #
 # Default settings
 #
-set(CMAKE_CXX_VISIBILITY_PRESET hidden)
+if (NOT FLUTTER)
+    set(CMAKE_CXX_VISIBILITY_PRESET hidden)
+endif ()
 set(CMAKE_POSITION_INDEPENDENT_CODE ON)
 set(CMAKE_EXPORT_COMPILE_COMMANDS 1)
 set(CMAKE_OSX_DEPLOYMENT_TARGET "10.15" CACHE STRING "Minimum OS X deployment version" FORCE)
@@ -66,7 +68,7 @@ endif ()
 option(TW_UNIT_TESTS "Enable the unit tests of the project" ON)
 option(TW_BUILD_EXAMPLES "Enable the examples builds of the project" ON)
 
-if (ANDROID OR IOS_PLATFORM OR TW_COMPILE_WASM OR TW_COMPILE_JAVA)
+if (ANDROID OR IOS_PLATFORM OR TW_COMPILE_WASM OR TW_COMPILE_JAVA OR FLUTTER)
     set(TW_UNIT_TESTS OFF)
     set(TW_BUILD_EXAMPLES OFF)
 endif()

cmake/StandardSettings.cmake

@@ -0,0 +1,5 @@
+# https://dart.dev/guides/libraries/private-files
+# Created by `dart pub`
+.dart_tool/
+*.dylib
+wallet_core_bindings.dart

flutter/.gitignore

@@ -0,0 +1,3 @@
+## 1.0.0
+
+- Initial version.