Skip to content

Commit bba61c5

Browse files
authored
fix(Traefik Hub): fail when upgrading with --reuse-values
1 parent b83a095 commit bba61c5

File tree

3 files changed

+14
-4
lines changed

3 files changed

+14
-4
lines changed

traefik/tests/requirements-config_test.yaml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ tests:
176176
tag: v3.0.0
177177
tracing:
178178
safeQueryParams:
179-
- foo
179+
- foo
180180
asserts:
181181
- failedTemplate:
182182
errorMessage: "ERROR: safeQueryParams is a feature only available for traefik >= v3.1.0."
@@ -282,3 +282,10 @@ tests:
282282
asserts:
283283
- failedTemplate:
284284
errorMessage: "ERROR: consulCatalogEnterprise provider is a feature only available for traefik-hub >= v3.6.0."
285+
- it: should fail when not using default values
286+
set:
287+
hub:
288+
namespaces: null
289+
asserts:
290+
- failedTemplate:
291+
errorPattern: "namespaces is required"

traefik/values.schema.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -596,6 +596,9 @@
596596
"type": "object"
597597
}
598598
},
599+
"required": [
600+
"namespaces"
601+
],
599602
"type": "object"
600603
},
601604
"image": {

traefik/values.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -598,8 +598,8 @@ tracing: # @schema additionalProperties: false
598598

599599
# -- Global command arguments to be passed to all traefik's pods
600600
globalArguments:
601-
- "--global.checknewversion"
602-
- "--global.sendanonymoususage"
601+
- "--global.checknewversion"
602+
- "--global.sendanonymoususage"
603603

604604
# -- Additional arguments to be passed at Traefik's binary
605605
# See [CLI Reference](https://docs.traefik.io/reference/static-configuration/cli/)
@@ -942,7 +942,7 @@ hub:
942942
# It enables API Gateway.
943943
token: ""
944944
# -- By default, Traefik Hub provider watches all namespaces. When using `rbac.namespaced`, it will watch helm release namespace and namespaces listed in this array.
945-
namespaces: []
945+
namespaces: [] # @schema required:true
946946
apimanagement:
947947
# -- Set to true in order to enable API Management. Requires a valid license token.
948948
enabled: false

0 commit comments

Comments
 (0)