fix: empty gql errors in logging

jmattheis · jmattheis · commit 50ae8ea1fe24 · 2025-02-15T18:38:26.000+01:00
diff --git a/logger/gql.go b/logger/gql.go
@@ -25,12 +25,12 @@ func GQLLog() graphql.ResponseMiddleware {
 		rawQuery := graphql.GetRequestContext(ctx).RawQuery
 
 		if len(errs) > 0 {
-			var errs []string
+			var errorStrings []string
 			for _, err := range errs {
-				errs = append(errs, err)
+				errorStrings = append(errorStrings, err.Error())
 			}
 
-			log.Error().Strs("error", errs).Str("took", elapsed.String()).Msg("GQL: " + toOneLine(hidePassword(rawQuery)))
+			log.Error().Strs("error", errorStrings).Str("took", elapsed.String()).Msg("GQL: " + toOneLine(hidePassword(rawQuery)))
 		} else if log.Debug().Enabled() {
 			log.Debug().Str("took", elapsed.String()).Msg("GQL: " + toOneLine(hidePassword(rawQuery)))
 		}

Original file line number	Diff line number	Diff line change
`@@ -25,12 +25,12 @@ func GQLLog() graphql.ResponseMiddleware {`
`25`	`25`	`rawQuery := graphql.GetRequestContext(ctx).RawQuery`
`26`	`26`
`27`	`27`	`if len(errs) > 0 {`
`28`		`- var errs []string`
	`28`	`+ var errorStrings []string`
`29`	`29`	`for _, err := range errs {`
`30`		`- errs = append(errs, err)`
	`30`	`+ errorStrings = append(errorStrings, err.Error())`
`31`	`31`	`}`
`32`	`32`
`33`		`- log.Error().Strs("error", errs).Str("took", elapsed.String()).Msg("GQL: " + toOneLine(hidePassword(rawQuery)))`
	`33`	`+ log.Error().Strs("error", errorStrings).Str("took", elapsed.String()).Msg("GQL: " + toOneLine(hidePassword(rawQuery)))`
`34`	`34`	`} else if log.Debug().Enabled() {`
`35`	`35`	`log.Debug().Str("took", elapsed.String()).Msg("GQL: " + toOneLine(hidePassword(rawQuery)))`
`36`	`36`	`}`