feat: add includeInputValueOnNoMatch to useSuggest

Author: spl3g

ui/src/tag/TagFilterSelector.tsx

@@ -51,9 +51,7 @@ export const TagFilterSelector: React.FC<TagFilterSelectorProps> = ({value: sele
     const [inputValue, setInputValue] = React.useState('');
 
     const tagsResult = useQuery<Tags>(gqlTags.Tags);
-    const suggestions = useSuggest(tagsResult, inputValue, [])
-        .filter((t) => !t.tag.create && !t.tag.alreadyUsed)
-        .reverse();
+    const suggestions = useSuggest(tagsResult, inputValue, [], false, false).filter((t) => !t.tag.create && !t.tag.alreadyUsed);
 
     if (tagsResult.error || tagsResult.loading || !tagsResult.data || !tagsResult.data.tags) {
         return null;
@@ -104,7 +102,7 @@ export const TagFilterSelector: React.FC<TagFilterSelectorProps> = ({value: sele
                     <div className={classes.container}>
                         <TextField
                             InputLabelProps={getLabelProps()}
-                            required={true}
+                            required={false}
                             disabled={disabled}
                             InputProps={{
                                 classes: {

ui/src/tag/suggest.ts

@@ -9,7 +9,8 @@ export const useSuggest = (
     tagResult: QueryResult<Tags, {}>,
     inputValue: string,
     usedTags: string[],
-    skipValue = false
+    skipValue = false,
+    includeInputValueOnNoMatch = true
 ): TagSelectorEntry[] => {
     const [tagKeySomeCase, tagValue] = inputValue.split(':');
     const tagKey = tagKeySomeCase.toLowerCase();
@@ -22,7 +23,7 @@ export const useSuggest = (
     });
 
     if (exactMatch && tagValue !== undefined && usedTags.indexOf(exactMatch.key) === -1 && !skipValue) {
-        return suggestTagValue(exactMatch, tagValue, valueResult);
+        return suggestTagValue(exactMatch, tagValue, valueResult, includeInputValueOnNoMatch);
     } else {
         return suggestTag(exactMatch, tagResult, tagKey, usedTags);
     }
@@ -59,11 +60,12 @@ const suggestTag = (
 const suggestTagValue = (
     exactMatch: TagSelectorEntry['tag'],
     tagValue: string,
-    valueResult: QueryResult<SuggestTagValue, SuggestTagValueVariables>
+    valueResult: QueryResult<SuggestTagValue, SuggestTagValueVariables>,
+    includeInputValueOnNoMatch: boolean
 ): TagSelectorEntry[] => {
     let someValues = (valueResult.data && valueResult.data.values) || [];
 
-    if (someValues.indexOf(tagValue) === -1) {
+    if (includeInputValueOnNoMatch && someValues.indexOf(tagValue) === -1) {
         someValues = [tagValue, ...someValues];
     }