Options hash is same instance passed to each cell when using collections

[samstickland]

All,

Is this deliberate here?

cells/lib/cell/collection.rb

Line 34 in 7b2a52d

cell = @cell_class.build(model, @options)

I would prefer this to be @options.clone, as we have some cells that can be passed options or use their own default values (which might be dependent on the model). As we mutate the cells options, the same options then get used in the next render from the collection.

FWIW, we only have this idea of default values for options, because there's no actual control over how a cell is built. Something to think about for v5 perhaps.

[apotonick]

I think a quick solution would be to let Ruby do this by doing build(model, **options). In v5 we will enforce such an interface for constructors.

Ouch, that sounds like you had some fun figuring out why all collection items are rendered with the wrong options, or something along those lines? 😆